Module:Annotated link - Revision history

Habst: Add new optional parameter prefix_parentheses, documented at Module:Annotated link/doc#prefix parentheses and tested at Module:Annotated link/sandbox/testcases

2024-01-02T16:59:29Z

Add new optional parameter prefix_parentheses, documented at Module:Annotated link/doc#prefix parentheses and tested at Module:Annotated link/sandbox/testcases

← Previous revision		Revision as of 16:59, 2 January 2024
Line 52:		Line 52:
	end		end

	local function formatResult(result, dash, description)		local function formatResult(result, dash, description, prefix_parentheses)
	if notEmpty(description) then		if notEmpty(description) then
			if prefix_parentheses then
			local startIdx = description:find("%(")
			if startIdx then
			local beforeParens = description:sub(1, startIdx - 2)
			local insideParens = description:sub(startIdx, -1)
			return result..' '..insideParens..dash..' '..beforeParens
			end
			end
	return result..dash..' '..description		return result..dash..' '..description
	end		end
Line 196:		Line 204:

	if isEmpty(short_description) or short_description.redlink then		if isEmpty(short_description) or short_description.redlink then
	return formatResult(result, dash, fallback)		return formatResult(result, dash, fallback, args.prefix_parentheses)
	end		end

Line 234:		Line 242:
	end		end
	if isEmpty(short_description) then		if isEmpty(short_description) then
	return formatResult(result, dash, fallback)		return formatResult(result, dash, fallback, args.prefix_parentheses)
	end		end
	else		else
Line 256:		Line 264:
	end		end
	if isEmpty(short_description) or lower_case_name:match(lower_case_short_description) then		if isEmpty(short_description) or lower_case_name:match(lower_case_short_description) then
	return formatResult(result, dash, fallback)		return formatResult(result, dash, fallback, args.prefix_parentheses)
	end		end
	if isEmpty(args.space_cat) then		if isEmpty(args.space_cat) then
Line 267:		Line 275:
	if lower_case_name == short_description:lower() then		if lower_case_name == short_description:lower() then
	if fellback then		if fellback then
	return formatResult(result, dash, fallback)		return formatResult(result, dash, fallback, args.prefix_parentheses)
	end		end
	maintenance = maintenance..optionallyVisibleCategory(		maintenance = maintenance..optionallyVisibleCategory(
Line 284:		Line 292:
	end		end

	return formatResult(result, dash, (short_description or fallback)..maintenance)		return formatResult(result, dash, (short_description or fallback)..maintenance, args.prefix_parentheses)
	end		end

Fred Gandt: applied coding conventions now I have to look at it less often

2023-02-15T20:13:45Z

applied coding conventions now I have to look at it less often

Show changes

Fred Gandt: exclude single word descriptions where that word is part of the link name e.g. Knaster–Tarski theorem – Theorem

2023-02-15T00:16:33Z

exclude single word descriptions where that word is part of the link name e.g. Knaster–Tarski theorem – Theorem

Fred Gandt: exclude Wikidata fallback descriptions that are the same as the linked article title; maintenance required is out of reasonable scope

2023-02-13T21:07:47Z

exclude Wikidata fallback descriptions that are the same as the linked article title; maintenance required is out of reasonable scope

← Previous revision		Revision as of 21:07, 13 February 2023
Line 175:		Line 175:
	maintenance = optionallyVisibleCategory( 'category-annotation-with-redirected-description', 'Pages displaying short descriptions of redirect targets' )		maintenance = optionallyVisibleCategory( 'category-annotation-with-redirected-description', 'Pages displaying short descriptions of redirect targets' )
	end		end

			local fellback

	if short_description.wikidata then		if short_description.wikidata then
	if short_description.fellback then		if short_description.fellback then
			fellback = true
	maintenance = maintenance .. optionallyVisibleCategory( 'category-wikidata-fallback-annotation', 'Pages displaying wikidata descriptions as a fallback' )		maintenance = maintenance .. optionallyVisibleCategory( 'category-wikidata-fallback-annotation', 'Pages displaying wikidata descriptions as a fallback' )
	end		end
Line 210:		Line 213:

	if name:lower() == short_description:lower() then		if name:lower() == short_description:lower() then
			if fellback then return formatResult( result, dash, fallback ) end
	maintenance = maintenance .. optionallyVisibleCategory( 'category-annotation-matches-name', 'Pages displaying short descriptions matching their page name' )		maintenance = maintenance .. optionallyVisibleCategory( 'category-annotation-matches-name', 'Pages displaying short descriptions matching their page name' )
	end		end

Fred Gandt: added application of maintenance Category:Pages displaying wikidata descriptions as a fallback via Module:Annotated link

2023-02-12T17:52:44Z

added application of maintenance Category:Pages displaying wikidata descriptions as a fallback via Module:Annotated link

← Previous revision		Revision as of 17:52, 12 February 2023
Line 171:		Line 171:

	local maintenance = ''		local maintenance = ''

			if short_description.redirected then
			maintenance = optionallyVisibleCategory( 'category-annotation-with-redirected-description', 'Pages displaying short descriptions of redirect targets' )
			end

	if short_description.wikidata then		if short_description.wikidata then
	if short_description.fellback then		if short_description.fellback then
	maintenance = optionallyVisibleCategory( 'category-wikidata-fallback-annotation', 'Pages displaying wikidata descriptions as a fallback' )		maintenance = maintenance .. optionallyVisibleCategory( 'category-wikidata-fallback-annotation', 'Pages displaying wikidata descriptions as a fallback' )
	end		end
	short_description = short_description.wikidata		short_description = short_description.wikidata

Fred Gandt: + changes required to work with the results of altered Module:GetShortDescription + optionally treat explicit short descriptions set to "none" as the end of the road when preferring them over Wikidata + removed redlink categorisation (the study was interesting though)

2023-02-12T03:38:16Z

+ changes required to work with the results of altered Module:GetShortDescription + optionally treat explicit short descriptions set to "none" as the end of the road when preferring them over Wikidata + removed redlink categorisation (the study was interesting though)

Show changes

Fred Gandt: case insensitive matching equality check for single word descs

2023-02-08T03:22:50Z

case insensitive matching equality check for single word descs

← Previous revision		Revision as of 03:22, 8 February 2023
Line 108:		Line 108:
	if notEmpty( not_wikidata_descriptions_including ) then		if notEmpty( not_wikidata_descriptions_including ) then
	-- Case insentive matching of terms to filter		-- Case insentive matching of terms to filter
	local ~~upper_case_short_description~~ = short_description:lower()		local lower_case_short_description = short_description:lower()
	for exclusion in hashDelimitedList( not_wikidata_descriptions_including:lower() ) do		for exclusion in hashDelimitedList( not_wikidata_descriptions_including:lower() ) do
	if ~~upper_case_short_description~~:match( exclusion ) then short_description = '' break end		if lower_case_short_description:match( exclusion ) then short_description = '' break end
	end		end
	end		end
Line 202:		Line 202:
	local not_single_word = args.not_single_word		local not_single_word = args.not_single_word
	if notEmpty( not_single_word ) then		if notEmpty( not_single_word ) then
			local lower_case_short_description = short_description:lower()
	for single_word in hashDelimitedList( not_single_word ) do
	if single_word == ~~short_description~~ ~~then~~ ~~short_description~~ ~~= '' break end~~		for single_word in hashDelimitedList( not_single_word:lower() ) do
			if single_word == lower_case_short_description then short_description = '' break end
	end		end
	end		end

Fred Gandt: add filter for single word descriptions to exclude

2023-02-08T02:46:38Z

add filter for single word descriptions to exclude

@@ Line 196: / Line 196: @@
 		return result
 	end
 	local maintenance = ''
 -- Short descriptions on en Wikipedia should be formatted with an uppercase first letter, but
@@ Line 209: / Line 221: @@
 	if desc_first_letter_case == 'upper' or desc_first_letter_case == 'lower' then
 		short_description = handleFirstLetterCase( short_description, desc_first_letter_case )
 	end

Fred Gandt: fix order of operations

2023-02-08T01:30:49Z

fix order of operations

← Previous revision		Revision as of 01:30, 8 February 2023
Line 177:		Line 177:
	} )		} )
	end		end

⚫	if isEmpty( short_description ) then return result end

	-- If Module:GetShortDescription indicates that name is for a nonexistent page; redlink will be true and there will be no short_description.		-- If Module:GetShortDescription indicates that name is for a nonexistent page; redlink will be true and there will be no short_description.
Line 198:		Line 196:
	return result		return result
	end		end

		⚫	if isEmpty( short_description ) then return result end

	local maintenance = ''		local maintenance = ''

Fred Gandt: fix script error for redlinks(?)

2023-02-08T00:57:49Z

fix script error for redlinks(?)

← Previous revision		Revision as of 00:57, 8 February 2023
Line 103:		Line 103:
	redlink = short_description.redlink		redlink = short_description.redlink
	wikidata = short_description		wikidata = short_description
	if wikidata then		if wikidata and isEmpty( redlink ) then
	short_description = short_description.wikidata		short_description = short_description.wikidata
	local not_wikidata_descriptions_including = args.not_wikidata_descriptions_including		local not_wikidata_descriptions_including = args.not_wikidata_descriptions_including

← Previous revision		Revision as of 00:16, 15 February 2023
Line 195:		Line 195:
	if isEmpty( short_description ) then return formatResult( result, dash, fallback ) end		if isEmpty( short_description ) then return formatResult( result, dash, fallback ) end
	else short_description = short_description.explicit end		else short_description = short_description.explicit end

			local lower_case_name = name:lower()

	if notEmpty( short_description ) and not short_description:match( ' ' ) then		if notEmpty( short_description ) and not short_description:match( ' ' ) then
	-- Filter against likely rubbish single word descriptions.		-- Filter against likely rubbish single word descriptions.
		⚫	local lower_case_short_description = short_description:lower()
	local not_single_word = args.not_single_word		local not_single_word = args.not_single_word
	if notEmpty( not_single_word ) then		if notEmpty( not_single_word ) then
	-- Case insentive matching.		-- Case insentive matching.
⚫	local lower_case_short_description = short_description:lower()
	for single_word in hashDelimitedList( not_single_word:lower() ) do		for single_word in hashDelimitedList( not_single_word:lower() ) do
	if single_word == lower_case_short_description then short_description = '' break end		if single_word == lower_case_short_description then short_description = '' break end
	end		end
	end		end
	if isEmpty( short_description ) then return formatResult( result, dash, fallback ) end		if isEmpty( short_description ) or lower_case_name:match( lower_case_short_description ) then return formatResult( result, dash, fallback ) end
	if isEmpty( args.space_cat ) then		if isEmpty( args.space_cat ) then
	maintenance = maintenance .. optionallyVisibleCategory( 'category-spaceless-annotation', 'Pages displaying short descriptions with no spaces' )		maintenance = maintenance .. optionallyVisibleCategory( 'category-spaceless-annotation', 'Pages displaying short descriptions with no spaces' )
Line 212:		Line 214:
	end		end

	if ~~name:lower()~~ == short_description:lower() then		if lower_case_name == short_description:lower() then
	if fellback then return formatResult( result, dash, fallback ) end		if fellback then return formatResult( result, dash, fallback ) end
	maintenance = maintenance .. optionallyVisibleCategory( 'category-annotation-matches-name', 'Pages displaying short descriptions matching their page name' )		maintenance = maintenance .. optionallyVisibleCategory( 'category-annotation-matches-name', 'Pages displaying short descriptions matching their page name' )