Module:Authority control - Revision history

MSGJ: some simplification and other tweaks

2024-10-12T10:11:14Z

some simplification and other tweaks

MSGJ: do not add categories for each identifier unless specified in config

2024-08-31T05:58:55Z

do not add categories for each identifier unless specified in config

← Previous revision		Revision as of 05:58, 31 August 2024
Line 2:		Line 2:
	local p = {}		local p = {}
	local frame = mw.getCurrentFrame()		local frame = mw.getCurrentFrame()
	local ~~arg~~ = frame.args.config		local config_file = frame.args.config and frame.args.config~='' and ('/' .. frame.args.config) or ''
	local config = mw.loadData('Module:Authority control/config' .. ~~(arg and arg~='' and ('/' .. arg) or '')~~)		local config = mw.loadData('Module:Authority control/config' .. config_file)
	local title = mw.title.getCurrentTitle()		local title = mw.title.getCurrentTitle()
	local namespace = title.namespace		local namespace = title.namespace
Line 29:		Line 29:
	return ''		return ''
	end		end
⚫	end

⚫	local ~~getCatForId~~ = function(id, ~~faulty~~)
	local cat = string.format(
⚫	config.i18n.cat,
⚫	~~(faulty and~~ config.i18n.faulty..' ' or '') .. id
	)
	return addCat(cat)
	end		end

Line 47:		Line 39:
	else		else
	return text		return text
			end
		⚫	end

		⚫	local getstatement = function(id, propid)
			local statement = mw.wikibase.getBestStatements('P' .. id, 'P' .. propid)
			local value
			if statement and statement[1] and statement[1].mainsnak.datavalue.value.id then
			value = statement[1].mainsnak.datavalue.value.id
			return value
			end
			end
			p.getname = function(property) -- function to lookup the name of a property and provide a link if one exists
			local item
			for _, propnameqid in ipairs(config.property_items) do
			item = getstatement(property, propnameqid)
			if item then break end
			end
			if item then
			local link = frame:expandTemplate{
			title = 'Wikidata fallback link',
			args = {item}
			}
			local raw = mw.wikibase.getLabel(item)
			return link, raw
			else
			return ''
	end		end
	end		end
Line 92:		Line 110:
	end		end
	if valid_value then		if valid_value then
	~~link:wikitext(getCatForId(~~id.category or id~~[1])~~)		local cat = id.category and string.format(config.i18n.cat, id.category)
			link:wikitext(addCat(cat))
	else		else
	local wdlink = qid and wikilink(':wikidata:' .. qid .. '#P' .. id.property) or ''		local wdlink = qid and wikilink(':wikidata:' .. qid .. '#P' .. id.property) or ''
			local _, name = p.getname(id.property)
	local tooltip = string.format(		local tooltip = string.format(
	config.i18n.idnotvalid,		config.i18n.idnotvalid,
	~~id[1]~~,		name,
	val.id		val.id
	)		)
	local ~~errorcat~~ = id.~~errorcat~~ and ~~addCat(id~~.~~errorcat) or getCatForId~~(~~id.category or id[1], true)~~		local cat = id.category and string.format(
		⚫	config.i18n.cat,
		⚫	config.i18n.faulty .. ' ' .. id.category
			)
	link:wikitext(wikilink('File:' .. config.i18n.warningicon .. '\|20px\|frameless\|link=' .. wdlink, tooltip .. '.'))		link:wikitext(wikilink('File:' .. config.i18n.warningicon .. '\|20px\|frameless\|link=' .. wdlink, tooltip .. '.'))
	:wikitext(~~errorcat~~)		:wikitext(addCat(cat))
	:wikitext(addCat(config.i18n.allfaultycat, ~~id[1]~~))		:wikitext(addCat(config.i18n.allfaultycat, name))
	end		end
	return link		return link
Line 193:		Line 216:
	end end end end end		end end end end end
	for _, part in ipairs(config.auto_additional) do		for _, part in ipairs(config.auto_additional) do
	checkparts('P' .. ~~tostring(~~part))		checkparts('P' .. part)
	end		end
	elseif parentArgs.additional and parentArgs.additional~='' then		elseif parentArgs.additional and parentArgs.additional~='' then

MSGJ: major code rewrite and simplification

2024-08-25T19:17:03Z

major code rewrite and simplification

Show changes

Pppery: Avoid Lua error when out of expensive parser function calls

2023-10-07T16:37:30Z

Avoid Lua error when out of expensive parser function calls

← Previous revision		Revision as of 16:37, 7 October 2023
Line 1:		Line 1:
	require('strict')		require('strict')
	local p = {}		local p = {}
⚫	local configfile = 'Module:Authority control/config' -- ~~default~~ ~~configuation~~ ~~module~~
	local arg = mw.getCurrentFrame().args.config		local arg = mw.getCurrentFrame().args.config
		⚫	local configfile = 'Module:Authority control/config' .. (arg and arg~='' and ('/' .. arg) or '')
	if arg and arg~='' then
		⚫	local config = mw.loadData(configfile)
	configfile = 'Module:Authority control/config/' .. arg
⚫	end
	local config
	if mw.title.new(configfile).exists then
⚫	config = mw.loadData(configfile)
	else
	return error('Invalid configuration file',0)
	end
	local title = mw.title.getCurrentTitle()		local title = mw.title.getCurrentTitle()
	local namespace = title.namespace		local namespace = title.namespace
Line 23:		Line 15:
	if cat and cat ~= '' and (namespace == 0 or namespace == 14 or testcases) then		if cat and cat ~= '' and (namespace == 0 or namespace == 14 or testcases) then
	local redlinkcat = ''		local redlinkcat = ''
	if testcases ~~== false and mw.title.new(cat, 14).exists~~ == false then		if testcases == false then
			local success, exists = pcall(function() return mw.title.new(cat, 14).exists end)
⚫	redlinkcat = needsAttention('N')
			if success and not exists then
		⚫	redlinkcat = needsAttention('N')
		⚫	end
	end		end
	if sortkey then		if sortkey then

MSGJ: don't track empty state parameter as error, tweak to messages

2023-07-18T10:01:56Z

don't track empty state parameter as error, tweak to messages

← Previous revision		Revision as of 10:01, 18 July 2023
Line 39:		Line 39:

	local function getCatForId(id,faulty)		local function getCatForId(id,faulty)
	local cat = ~~config~~.~~i18n.Articles_with .. ' '~~		local cat = string.format(
	~~if faulty then cat = cat ..~~ config.i18n.~~faulty .. ' ' end~~		config.i18n.cat,
			(faulty and config.i18n.faulty..' ' or '') .. id
	cat = cat .. id .. ' ' .. config.i18n.identifiers
			)
	return addCat(cat)		return addCat(cat)
	end		end
Line 127:		Line 128:
	--local preview = require("Module:If preview")		--local preview = require("Module:If preview")
	local wdlink = qid and '[[:wikidata:' .. qid .. '#P' .. conf.property .. ']]' or ''		local wdlink = qid and '[[:wikidata:' .. qid .. '#P' .. conf.property .. ']]' or ''
			local tooltip = string.format(
⚫	link = link .. '[[File:' .. config.i18n.warningicon .. '\|20px\|frameless\|link=' .. wdlink .. '\|' .. ~~config.i18n.The .. ' ' .. conf[1] .. ' ' .. config.i18n.identifier .. ' ' .. val.id .. ' ' .. config.i18n.isnotvalid~~ .. '.]]'
			config.i18n.idnotvalid,
			conf[1],
			val.id
			)
		⚫	link = link .. '[[File:' .. config.i18n.warningicon .. '\|20px\|frameless\|link=' .. wdlink .. '\|' .. tooltip .. '.]]'
	if conf.errorcat then		if conf.errorcat then
	link = link .. addCat(conf.errorcat)		link = link .. addCat(conf.errorcat)
Line 424:		Line 430:
	end		end

	if parentArgs.state ~~then~~		if parentArgs.state
	if (parentArgs.state ~= config.i18n.collapsed) and (parentArgs.state ~= config.i18n.expanded) and (parentArgs.state ~= config.i18n.autocollapse) then --invalid state parameter		and parentArgs.state~=''
			and parentArgs.state~=config.i18n.collapsed
			and parentArgs.state~=config.i18n.expanded
			and parentArgs.state~=config.i18n.autocollapse then --invalid state parameter
	auxCats = auxCats .. needsAttention('S')		auxCats = auxCats .. needsAttention('S')
	end
	end		end
	if testcases then		if testcases then

MSGJ: stop linking if target of redirect is same as current page

2023-05-25T08:36:15Z

stop linking if target of redirect is same as current page

@@ Line 159: / Line 159: @@
 	local rct = false -- boolean to track if there are any links to be returned
 	local qid,topic
 	if namespace == 0 then
 		qid = mw.wikibase.getEntityIdForCurrentPage()
@@ Line 366: / Line 384: @@
 				else -- section from additional qid
 					local qid = qids[c-numsections]
-					local label,sitelink = mw.wikibase.getLabel(qid), mw.wikibase.getSitelink(qid)
+					sectname = wikilink(qid) .. pencil(qid)
 				end
 				navboxArgs['group' .. c] = sectname

MSGJ: only check for additional items when additional=auto, add sitelinks to labels

2023-05-16T11:07:20Z

only check for additional items when additional=auto, add sitelinks to labels

@@ Line 185: / Line 185: @@
 	end
 	local qids = {} -- setup any additional QIDs
-	if parentArgs.additional and parentArgs.additional ~= '' then
+	if parentArgs.additional=='auto' and qid then  -- check P527 for parts to add additional qids
 		for _,v in ipairs(mw.text.split(parentArgs.additional,"%s*,%s*")) do
 			v = resolveQID(v)
@@ Line 195: / Line 208: @@
 			else -- invalid QID specified
 				auxCats = auxCats .. needsAttention('A')
 			end
 		end
@@ Line 364: / Line 365: @@
 					sectname = config.sections[c].name
 				else -- section from additional qid
-					if not mw.wikibase.getLabel(qids[c-numsections]) then
+					local qid = qids[c-numsections]
 						auxCats = auxCats .. needsAttention('L')
 					end
-					sectname = (mw.wikibase.getLabel(qids[c-numsections]) or qids[c-numsections]) .. pencil(qids[c-numsections])
+					sectname = sectname .. pencil(qid)
 				end
 				navboxArgs['group' .. c] = sectname

MSGJ: check qid is valid before adding to table

2023-05-14T20:15:48Z

check qid is valid before adding to table

← Previous revision		Revision as of 20:15, 14 May 2023
Line 202:		Line 202:
	for _,part in ipairs(parts) do		for _,part in ipairs(parts) do
	if part.mainsnak.datavalue and part.mainsnak.datavalue.value.id then		if part.mainsnak.datavalue and part.mainsnak.datavalue.value.id then
	~~table.insert(qids,~~resolveQID(part.mainsnak.datavalue.value.id))		local resolvedqid = resolveQID(part.mainsnak.datavalue.value.id)
			if resolvedqid then
			table.insert(qids,resolvedqid)
			end
	end		end
	end		end

MSGJ: bugs fixed

2023-05-12T11:02:49Z

bugs fixed

← Previous revision		Revision as of 11:02, 12 May 2023
Line 1:		Line 1:
	require('strict')		require('strict')
⚫	~~local config~~ = ~~mw.loadData(~~'Module:Authority control/config')
	local p = {}		local p = {}
			local configfile = 'Module:Authority control/config' -- default configuation module
			local arg = mw.getCurrentFrame().args.config
			if arg and arg~='' then
		⚫	configfile = 'Module:Authority control/config/' .. arg
		⚫	end
			local config
			if mw.title.new(configfile).exists then
			config = mw.loadData(configfile)
			else
			return error('Invalid configuration file',0)
			end
	local title = mw.title.getCurrentTitle()		local title = mw.title.getCurrentTitle()
	local namespace = title.namespace		local namespace = title.namespace
Line 160:		Line 170:
	if qid then -- qid parameter is valid, set topic to display		if qid then -- qid parameter is valid, set topic to display
	topic = mw.wikibase.getLabel(qid)		topic = mw.wikibase.getLabel(qid)
	if topic ~~and~~ (mw.ustring.lower(title.subpageText) == mw.ustring.lower(topic)) then -- suppress topic display if subpagename equals topic up to case change		if topic then
			if mw.ustring.lower(title.subpageText) == mw.ustring.lower(topic) then -- suppress topic display if subpagename equals topic up to case change
	topic = nil		topic = nil
			end
		⚫	if topic and mw.wikibase.getSitelink(qid) then -- make wikilink to article
		⚫	topic = '[[' .. mw.wikibase.getSitelink(qid) .. '\|' .. topic .. ']]'
			end
			else
			auxCats = auxCats .. needsAttention('L')
	end		end
	elseif parentArgs.qid and parentArgs.qid~='' then -- invalid qid has been supplied, add to tracking cat		elseif parentArgs.qid and parentArgs.qid~='' then -- invalid qid has been supplied, add to tracking cat
	auxCats = auxCats .. needsAttention('Q')		auxCats = auxCats .. needsAttention('Q')
	end		end
⚫	end
⚫	if topic and mw.wikibase.getSitelink(qid) then -- make wikilink to article
⚫	topic = '[[' .. mw.wikibase.getSitelink(qid) .. '\|' .. topic .. ']]'
	end		end
	local qids = {} -- setup any additional QIDs		local qids = {} -- setup any additional QIDs
Line 181:		Line 195:
	else -- invalid QID specified		else -- invalid QID specified
	auxCats = auxCats .. needsAttention('A')		auxCats = auxCats .. needsAttention('A')
			end
			end
			elseif qid then -- check P527 for parts to add additional qids
			local parts = mw.wikibase.getBestStatements(qid,'P527')
			if parts then
			for _,part in ipairs(parts) do
			if part.mainsnak.datavalue and part.mainsnak.datavalue.value.id then
			table.insert(qids,resolveQID(part.mainsnak.datavalue.value.id))
			end
	end		end
	end		end
Line 338:		Line 361:
	sectname = config.sections[c].name		sectname = config.sections[c].name
	else -- section from additional qid		else -- section from additional qid
	~~sectname~~ = mw.wikibase.getLabel(qids[c-numsections]) ~~.. pencil(qids[c-numsections])~~		if not mw.wikibase.getLabel(qids[c-numsections]) then
			auxCats = auxCats .. needsAttention('L')
			end
			sectname = (mw.wikibase.getLabel(qids[c-numsections]) or qids[c-numsections]) .. pencil(qids[c-numsections])
	end		end
	navboxArgs['group' .. c] = sectname		navboxArgs['group' .. c] = sectname

MSGJ: Undid revision 1154352304 by MSGJ (talk) causing errors

2023-05-12T06:27:17Z

Undid revision 1154352304 by MSGJ (talk) causing errors

@@ Line 1: / Line 1: @@
 require('strict')
 local p = {}
 local title = mw.title.getCurrentTitle()
 local namespace = title.namespace
@@ Line 170: / Line 160: @@
 		if qid then -- qid parameter is valid, set topic to display
 			topic = mw.wikibase.getLabel(qid)
 			end
 		elseif parentArgs.qid and parentArgs.qid~='' then -- invalid qid has been supplied, add to tracking cat
 			auxCats = auxCats .. needsAttention('Q')
 		end
 	end
 	local qids = {} -- setup any additional QIDs
@@ Line 195: / Line 181: @@
 			else -- invalid QID specified
 				auxCats = auxCats .. needsAttention('A')
 			end
 		end
@@ Line 361: / Line 338: @@
 					sectname = config.sections[c].name
 				else -- section from additional qid
 					sectname = mw.wikibase.getLabel(qids[c-numsections]) .. pencil(qids[c-numsections])
 				end