Module:Check DYK hook - Revision history

Mr. Stradivarius: fix whitespace trimming; only trim whitespace in p.isValidHook, not in the Lua p._isValidHook interface; add a "hook" keyword parameter; and check the type of the input in p._isValidHook

2020-11-29T12:31:57Z

fix whitespace trimming; only trim whitespace in p.isValidHook, not in the Lua p._isValidHook interface; add a "hook" keyword parameter; and check the type of the input in p._isValidHook

← Previous revision		Revision as of 12:31, 29 November 2020
Line 1:		Line 1:
	-- This module performs validation checks for [[WP:DYK]] hooks		-- This module performs validation checks for [[WP:DYK]] hooks

			local libraryUtil = require('libraryUtil')
	local p = {}		local p = {}

Line 7:		Line 8:
	-- Check that hooks start with three periods, followed by an acceptable		-- Check that hooks start with three periods, followed by an acceptable
	-- follow-on word.		-- follow-on word.
	"^ %.%.%. that",		"^%.%.%. *that",
	"^ %.%.%. about",		"^%.%.%. *about",
	},		},
	{		{
	-- Check that hooks end with a question mark, or another acceptable		-- Check that hooks end with a question mark, or another acceptable
	-- phrase.		-- phrase.
	[[.%?%]'"? *$]],		[[.%?%]'"?$]],
	[[.?</span>%]'"? *$]],		[[.?</span>%]'"?$]],
	"[Yy]ou probably did%.+ *$",		"[Yy]ou probably did%.+$",
	}		}
	}		}
Line 24:		Line 25:
	-- a hook is valid or not. Hooks are treated as valid if they match at least		-- a hook is valid or not. Hooks are treated as valid if they match at least
	-- one pattern from each group.		-- one pattern from each group.
			libraryUtil.checkType("_isValidHook", 1, hook, "string")
	for _, patternGroup in ipairs(validationPatternGroups) do		for _, patternGroup in ipairs(validationPatternGroups) do
	local found = false		local found = false
Line 40:		Line 42:

	function p.isValidHook(frame)		function p.isValidHook(frame)
	local ~~hook~~ = frame.args~~[1]~~		local args = frame.args
			local hook = args.hook or args[1]
	if not hook then		if not hook then
	error("No hook specified")		error("No hook specified")
	end		end
	hook = ~~mw.ustring.gsub~~(~~hook, "~~^%s(.?)%s*$~~", "%1"~~) -- Trim whitespace		hook = hook:match('^%s(.-)%s$') -- Trim whitespace
	if p._isValidHook(hook) then		if p._isValidHook(hook) then
	return "yes"		return "yes"

Frietjes: not sure why but this seems to fix it

2020-11-27T15:39:41Z

not sure why but this seems to fix it

← Previous revision		Revision as of 15:39, 27 November 2020
Line 44:		Line 44:
	error("No hook specified")		error("No hook specified")
	end		end
	hook = ~~hook:match~~("^%s(.?)%s*$") -- Trim whitespace		hook = mw.ustring.gsub(hook, "^%s(.?)%s*$", "%1") -- Trim whitespace
	if p._isValidHook(hook) then		if p._isValidHook(hook) then
	return "yes"		return "yes"

Headbomb: Undid revision 990847290 by Frietjes (talk) this broke the check

2020-11-27T15:13:30Z

Undid revision 990847290 by Frietjes (talk) this broke the check

← Previous revision		Revision as of 15:13, 27 November 2020
Line 27:		Line 27:
	local found = false		local found = false
	for _, pattern in ipairs(patternGroup) do		for _, pattern in ipairs(patternGroup) do
	if mw.ustring.find(hook ~~or ''~~, pattern) then		if mw.ustring.find(hook, pattern) then
	found = true		found = true
	break		break

Frietjes: remove pages like Talk:Girl on the Third Floor from Category:Pages with script errors

2020-11-26T21:05:51Z

remove pages like Talk:Girl on the Third Floor from Category:Pages with script errors

← Previous revision		Revision as of 21:05, 26 November 2020
Line 27:		Line 27:
	local found = false		local found = false
	for _, pattern in ipairs(patternGroup) do		for _, pattern in ipairs(patternGroup) do
	if mw.ustring.find(hook, pattern) then		if mw.ustring.find(hook or '', pattern) then
	found = true		found = true
	break		break

Mr. Stradivarius: Protected "Module:Check DYK hook": High-risk Lua module: used in Template:DYK talk and Module:Article history/config ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

2020-10-25T16:25:57Z

Protected "Module:Check DYK hook": High-risk Lua module: used in Template:DYK talk and Module:Article history/config ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

← Previous revision	Revision as of 16:25, 25 October 2020
(No difference)

Mr. Stradivarius: copy from Module:Check DYK hook/sandbox

2020-10-25T14:02:20Z

copy from Module:Check DYK hook/sandbox

New page

-- This module performs validation checks for [[WP:DYK]] hooks

local p = {}

local validationPatternGroups = {
{
-- Check that hooks start with three periods, followed by an acceptable
-- follow-on word.
"^ *%.%.%. *that",
"^ *%.%.%. *about",
},
{
-- Check that hooks end with a question mark, or another acceptable
-- phrase.
[[.%?%]*'*"? *$]],
[[.?</span>%]*'*"? *$]],
"[Yy]ou probably did%.+ *$",
}
}

function p._isValidHook(hook)
-- Whether the given hook is valid.
-- We use the patterns in the validationPatternGroups table to find whether
-- a hook is valid or not. Hooks are treated as valid if they match at least
-- one pattern from each group.
for _, patternGroup in ipairs(validationPatternGroups) do
local found = false
for _, pattern in ipairs(patternGroup) do
if mw.ustring.find(hook, pattern) then
found = true
break
end
end
if not found then
return false
end
end
return true
end

function p.isValidHook(frame)
local hook = frame.args[1]
if not hook then
error("No hook specified")
end
hook = hook:match("^%s*(.*?)%s*$") -- Trim whitespace
if p._isValidHook(hook) then
return "yes"
else
return ""
end
end

return p