Module:Commons link/sandbox - Revision history

Hike395: lazy load module

2024-10-24T10:40:20Z

lazy load module

← Previous revision		Revision as of 10:40, 24 October 2024
Line 3:		Line 3:
	-- Module to find commons galleries and categories based on wikidata entries		-- Module to find commons galleries and categories based on wikidata entries
	local getArgs = require('Module:Arguments').getArgs		local getArgs = require('Module:Arguments').getArgs
⚫	local yesNo = require('Module:Yesno')
	local p = {}		local p = {}

Line 507:		Line 506:
	local formatting = {}		local formatting = {}
	formatting.linktext = args.linktext		formatting.linktext = args.linktext
		⚫	local yesNo = require('Module:Yesno')
	formatting.lcfirst = yesNo(args.lcfirst)		formatting.lcfirst = yesNo(args.lcfirst)
	formatting.bold = yesNo(args.bold)		formatting.bold = yesNo(args.bold)

Od1n: underscores are in the ASCII range, therefore there is no need at all to use a (slow) mw.ustring.* function here; see UTF-8#Encoding

2024-09-08T11:52:43Z

underscores are in the ASCII range, therefore there is no need at all to use a (slow) mw.ustring.* function here; see UTF-8#Encoding

← Previous revision		Revision as of 11:52, 8 September 2024
Line 59:		Line 59:
	local titleObject = mw.title.getCurrentTitle()		local titleObject = mw.title.getCurrentTitle()
	-- look up qid for current page (if not testing)		-- look up qid for current page (if not testing)
	local nsText = ~~mw.ustring~~.gsub(titleObject.nsText,"_"," ") -- [[phab:T369784]]		local nsText = string.gsub(titleObject.nsText,"_"," ") -- [[phab:T369784]]
	if not _validQID(qid) then		if not _validQID(qid) then
	qid = mw.wikibase.getEntityIdForCurrentPage()		qid = mw.wikibase.getEntityIdForCurrentPage()

Od1n: Add reference to T369784 (but I couldn't add the reference to the main module, which is edit-protected). The local fix here has been added by Hike395 in 980561090 and 980647925.

2024-07-18T11:28:05Z

Add reference to T369784 (but I couldn't add the reference to the main module, which is edit-protected). The local fix here has been added by Hike395 in 980561090 and 980647925.

← Previous revision		Revision as of 11:28, 18 July 2024
Line 59:		Line 59:
	local titleObject = mw.title.getCurrentTitle()		local titleObject = mw.title.getCurrentTitle()
	-- look up qid for current page (if not testing)		-- look up qid for current page (if not testing)
	local nsText = mw.ustring.gsub(titleObject.nsText,"_"," ")		local nsText = mw.ustring.gsub(titleObject.nsText,"_"," ") -- [[phab:T369784]]
	if not _validQID(qid) then		if not _validQID(qid) then
	qid = mw.wikibase.getEntityIdForCurrentPage()		qid = mw.wikibase.getEntityIdForCurrentPage()

Hike395: lazy load module

2023-07-22T10:40:54Z

lazy load module

← Previous revision		Revision as of 10:40, 22 July 2023
Line 4:		Line 4:
	local getArgs = require('Module:Arguments').getArgs		local getArgs = require('Module:Arguments').getArgs
	local yesNo = require('Module:Yesno')		local yesNo = require('Module:Yesno')
⚫	local generateWarning = require('Module:If preview')._warning
	local p = {}		local p = {}

Line 440:		Line 439:
	local warning = ""		local warning = ""
	if wikidata then		if wikidata then
		⚫	local generateWarning = require('Module:If preview')._warning
	warning = generateWarning({		warning = generateWarning({
	"Commons link does not match Wikidata – [[Template:Commons_category#Resolving_discrepancies\|please check]]"		"Commons link does not match Wikidata – [[Template:Commons_category#Resolving_discrepancies\|please check]]"

WOSlinker: use require('strict') instead of require('Module:No globals')

2022-10-21T09:56:24Z

use require('strict') instead of require('Module:No globals')

← Previous revision		Revision as of 09:56, 21 October 2022
Line 1:		Line 1:
	require('~~Module:No globals~~')		require('strict')

	-- Module to find commons galleries and categories based on wikidata entries		-- Module to find commons galleries and categories based on wikidata entries

Hike395: fix globals

2021-12-04T06:09:45Z

fix globals

← Previous revision		Revision as of 06:09, 4 December 2021
Line 493:		Line 493:
	end		end
	if fetchCategory then		if fetchCategory then
	cat_wikidata, cat_consistent = p._hasCategoryConsistent(qid,true)		local cat_wikidata, cat_consistent = p._hasCategoryConsistent(qid,true)
	if not fetchGallery or (cat_consistent and cat_wikidata) then		if not fetchGallery or (cat_consistent and cat_wikidata) then
	return selectTrackingCat(categoryTrackingCats,cat_wikidata,		return selectTrackingCat(categoryTrackingCats,cat_wikidata,
Line 505:		Line 505:

	local function _createFormatting(args)		local function _createFormatting(args)
	formatting = {}		local formatting = {}
	formatting.linktext = args.linktext		formatting.linktext = args.linktext
	formatting.lcfirst = yesNo(args.lcfirst)		formatting.lcfirst = yesNo(args.lcfirst)

Hike395: check for globals

2021-12-04T06:08:44Z

check for globals

← Previous revision		Revision as of 06:08, 4 December 2021
Line 1:		Line 1:
			require('Module:No globals')

	-- Module to find commons galleries and categories based on wikidata entries		-- Module to find commons galleries and categories based on wikidata entries
	local getArgs = require('Module:Arguments').getArgs		local getArgs = require('Module:Arguments').getArgs

Hike395: use CSS for italic/bold

2021-08-29T02:39:08Z

use CSS for italic/bold

@@ Line 38: / Line 38: @@
 	if formatting.lcfirst then
 		resultVal = _lcfirst(resultVal)
 	end
 	return resultVal
 end

Hike395: add another bail point for inconsistency

2021-08-02T14:56:00Z

add another bail point for inconsistency

← Previous revision		Revision as of 14:56, 2 August 2021
Line 176:		Line 176:
	if categoryLink and categoryLink ~= fallback then		if categoryLink and categoryLink ~= fallback then
	consistent = false		consistent = false
			qid = nil
	else		else
	categoryLink = fallback		categoryLink = fallback

Hike395: check for valid qid before fetching P373

2021-08-02T12:50:53Z

check for valid qid before fetching P373

← Previous revision		Revision as of 12:50, 2 August 2021
Line 161:		Line 161:
	categoryLink = mw.ustring.sub(commonsSitelink,10)		categoryLink = mw.ustring.sub(commonsSitelink,10)
	end		end
	-- purposefully do not look in P373 ("commons category" property)
	-- if P373 is desired, then restore search code here

	-- P910 is the "topic's main category". Look for commons sitelink there		-- P910 is the "topic's main category". Look for commons sitelink there
	local fallback = _lookupFallback(qid,"P910")		local fallback = _lookupFallback(qid,"P910")
Line 185:		Line 182:
	-- P373 is the "commons category" property for this article. This is		-- P373 is the "commons category" property for this article. This is
	-- a low-quality field, so should only be used as a last resort.		-- a low-quality field, so should only be used as a last resort.
		⚫	if categoryLink == nil and _validQID(qid) then
	local P373 = mw.wikibase.getBestStatements(qid, "P373")[1]		local P373 = mw.wikibase.getBestStatements(qid, "P373")[1]
⚫	if categoryLink == nil and ~~P373 and P373.mainsnak.datavalue~~ then
	~~categoryLink~~ = P373.mainsnak.datavalue~~.value~~		if P373 and P373.mainsnak.datavalue then
			categoryLink = P373.mainsnak.datavalue.value
	consistent = true -- P373 is never used if anything else is available		consistent = true -- P373 is never used if anything else is available
			end
	end		end
	return categoryLink, consistent, commonsSitelink		return categoryLink, consistent, commonsSitelink