WOSlinker: use require('strict') instead of require('Module:No globals')

2022-10-21T10:04:39Z

use require('strict') instead of require('Module:No globals')

← Previous revision		Revision as of 10:04, 21 October 2022
Line 2:		Line 2:

	-- Load modules		-- Load modules
	require('~~Module:No globals~~')		require('strict')
	local yesno = require('Module:Yesno')		local yesno = require('Module:Yesno')
	local data = mw.loadData('Module:DYK checklist/data')		local data = mw.loadData('Module:DYK checklist/data')

Mr. Stradivarius: replace newlines with spaces in escapeUserString

2018-10-08T02:36:32Z

replace newlines with spaces in escapeUserString

← Previous revision		Revision as of 02:36, 8 October 2018
Line 65:		Line 65:

	-- Format a user-supplied string for display in error messages.		-- Format a user-supplied string for display in error messages.
	-- This prevents input from being displayed as special wiki markup, ~~and~~		-- This prevents input from being displayed as special wiki markup, converts
	-- truncates long strings so that they ~~are easier to read.~~		-- multi-line strings to a single line, and truncates long strings so that they
			-- are easier to read.
	local function escapeUserString(s)		local function escapeUserString(s)
	if #s > 28 then		if #s > 28 then
	s = s:sub(1, 12) .. '...' .. s:sub(-12, -1)		s = s:sub(1, 12) .. '...' .. s:sub(-12, -1)
	end		end
			s = s:gsub("\n", " ")
	return mw.text.nowiki(s)		return mw.text.nowiki(s)
	end		end

Mr. Stradivarius: Make user-supplied strings easier to read in error messages

2018-10-08T02:29:56Z

Make user-supplied strings easier to read in error messages

← Previous revision		Revision as of 02:29, 8 October 2018
Line 62:		Line 62:
	local function makeWikitextError(msg)		local function makeWikitextError(msg)
	return string.format([['''<span style="color: red;">%s</span>''']], msg)		return string.format([['''<span style="color: red;">%s</span>''']], msg)
			end

			-- Format a user-supplied string for display in error messages.
			-- This prevents input from being displayed as special wiki markup, and
			-- truncates long strings so that they are easier to read.
			local function escapeUserString(s)
			if #s > 28 then
			s = s:sub(1, 12) .. '...' .. s:sub(-12, -1)
			end
			return mw.text.nowiki(s)
	end		end

Line 281:		Line 291:
	return makeWikitextError(string.format(		return makeWikitextError(string.format(
	'Invalid status "%s" - use one of "y", "?", "maybe", "no" or "again"',		'Invalid status "%s" - use one of "y", "?", "maybe", "no" or "again"',
	args.status		escapeUserString(args.status)
	))		))
	end		end

Mr. Stradivarius: put the invalid string in the status error message

2018-10-03T11:26:18Z

put the invalid string in the status error message

← Previous revision		Revision as of 11:26, 3 October 2018
Line 279:		Line 279:
	and args.status ~= 'again'		and args.status ~= 'again'
	then		then
	return makeWikitextError('Invalid status - use one of "y", "?", "maybe", "no" or "again"')		return makeWikitextError(string.format(
			'Invalid status "%s" - use one of "y", "?", "maybe", "no" or "again"',
			args.status
			))
	end		end

Mr. Stradivarius: validate the status argument - now invalid values will produce a wikitext error

2018-10-03T11:22:00Z

validate the status argument - now invalid values will produce a wikitext error

← Previous revision		Revision as of 11:22, 3 October 2018
Line 57:		Line 57:
	end		end
	return false		return false
			end

			-- Make a wikitext error message.
			local function makeWikitextError(msg)
			return string.format([['''<span style="color: red;">%s</span>''']], msg)
	end		end

Line 267:		Line 272:
	local function makeStatusSection(args)		local function makeStatusSection(args)
	if not args.status then		if not args.status then
	return [['~~''<span style="color: red;">~~Review is incomplete - please fill in the "status" field~~</span>''~~']]		return makeWikitextError('Review is incomplete - please fill in the "status" field')
			elseif args.status ~= 'y'
			and args.status ~= '?'
			and args.status ~= 'maybe'
			and args.status ~= 'no'
			and args.status ~= 'again'
			then
			return makeWikitextError('Invalid status - use one of "y", "?", "maybe", "no" or "again"')
	end		end

Mr. Stradivarius: copy from Module:DYK checklist

2018-10-03T11:11:50Z

copy from Module:DYK checklist

New page

-- This module implements {{DYK checklist}}.

-- Load modules
require('Module:No globals')
local yesno = require('Module:Yesno')
local data = mw.loadData('Module:DYK checklist/data')
local responseIcons = data.responseIcons
local statusIcons = data.statusIcons

-- Template for making collapsed sections.
local COLLAPSED_WIKITABLE = [[
{| class="collapsible collapsed" border="1" style="border-collapse:collapse;"
|-
! style="font-weight:normal; " | %s
|-
| %s
|}]]

-- Template for making uncollapsed sections.
local UNCOLLAPSED_WIKITABLE = [[
{| border="1" style="border-collapse:collapse;"
|-
| %s
|}]]

--------------------------------------------------------------------------------
-- Helper functions
--------------------------------------------------------------------------------

-- Make the given key in args lowercase if when lowercased it equals val.
local function makeArgLowerCase(args, key, val)
if args[key] and string.lower(args[key]) == val then
args[key] = val
end
end

-- Normalize the args table to make it easier to work with elsewhere in the
-- module.
local function normalizeArguments(args)
-- Consolidate aliases
args.plagiarismfree = args.plagiarismfree or args.plagarismfree
args.plagarismfree = nil

-- Normalize special values
makeArgLowerCase(args, 'hookcited', 'agf')
makeArgLowerCase(args, 'picfree', 'na')
makeArgLowerCase(args, 'qpq', 'na')
end

-- If any of the keys in the keys array are in the table t, return true;
-- otherwise, return false.
local function anyKeysInTable(t, keys)
for i, key in ipairs(keys) do
if t[key] then
return true
end
end
return false
end

-- Make a collapsed wikitable with the given header and content.
local function makeCollapsedWikitable(header, content)
return string.format(COLLAPSED_WIKITABLE, header, content)
end

-- Make an uncollapsed wikitable with the given content.
local function makeUncollapsedWikitable(content)
return string.format(UNCOLLAPSED_WIKITABLE, content)
end

-- Make a bulleted list from an array of strings.
local function makeBulletedList(items)
local ret = {}
for i, item in ipairs(items) do
ret[i] = '* ' .. item
end
return table.concat(ret, '\n')
end

-- Make a checklist item from the given issue and status.
local function makeChecklistItem(issue, status, defaultMarker)
if not status then
return string.format('%s: %s', issue, responseIcons.UNKNOWN)
elseif yesno(status) then
return string.format('%s: %s', issue, responseIcons.YES)
else
return string.format(
'%s: %s - %s',
issue,
defaultMarker or responseIcons.NO,
status
)
end
end

-- Return true if all issues have been resolved; return false otherwise.
-- mainIssues is an array of tables as passed to makeSection. otherIssues is a
-- string value or nil (again, as passed to makeSection).
local function allIssuesAreResolved(mainIssues, otherIssues)
if otherIssues then
return false
end
for i, t in ipairs(mainIssues) do
if t.isResolved == false
or (
t.isResolved ~= true
and not yesno(t.status)
)
then
return false
end
end
return true
end

-- Assemble a section of the DYK checklist.
local function makeSection(options)
local issues = {}

-- Add main issues
options.mainIssues = options.mainIssues or {}
for i, t in ipairs(options.mainIssues) do
local checklistItem
if t.isResolved then
checklistItem = makeChecklistItem(t.issue, t.status, responseIcons.YES)
else
checklistItem = makeChecklistItem(t.issue, t.status)
end
table.insert(issues, checklistItem)
end

-- Add other issues
if options.otherIssues then
table.insert(issues, makeChecklistItem('Other problems', options.otherIssues))
end

-- Make the section output.
local content = makeBulletedList(issues)
if allIssuesAreResolved(options.mainIssues, options.otherIssues) then
return makeCollapsedWikitable(options.resolvedHeader, '\n' .. content)
else
return options.unresolvedHeader .. '\n' .. content
end
end

--------------------------------------------------------------------------------
-- Section functions
-- Each of these functions makes a single section of the DYK checklist.
--------------------------------------------------------------------------------

local function makeGeneralEligibilitySection(args)
return makeSection{
unresolvedHeader = "'''General eligiblity:'''",
resolvedHeader = "'''General:''' Article is new enough and long enough",
mainIssues = {
{
issue = '[[WP:Did you know#New|New Enough]]',
status = args.newness,
},
{
issue = '[[WP:Did you know#Long enough|Long Enough]]',
status = args.length,
},
},
otherIssues = args.eligibilityother,
}
end

local function makePolicyComplianceSection(args)
return makeSection{
unresolvedHeader = "'''Policy compliance:'''",
resolvedHeader = "'''Policy:''' Article is sourced, neutral, and free of copyright problems",
mainIssues = {
{
issue = '[[WP:Citing sources|Adequate sourcing]]',
status = args.sourced,
},
{
issue = '[[WP:NPOV|Neutral]]',
status = args.neutral,
},
{
issue = 'Free of [[Wikipedia:Copyright violations|copyright violations]], [[Wikipedia:Plagiarism|plagiarism]], and [[WP:close paraphrasing|close paraphrasing]]',
status = args.plagiarismfree,
},
},
otherIssues = args.policyother,
}
end

local function makeHookEligibilitySection(args)
-- Deal with AGF special case for hook citations
local hookCiteStatus, isHookSourceAGF
if args.hookcited == 'agf' then
hookCiteStatus = 'Offline/paywalled citation accepted in good faith'
isHookSourceAGF = true
else
hookCiteStatus = args.hookcited
isHookSourceAGF = nil -- use default behaviour
end

-- Generate output
return makeSection{
unresolvedHeader = "'''Hook eligiblity:'''",
resolvedHeader = "'''Hook:''' Hook has been verified by provided inline citation",
mainIssues = {
{
issue = '[[WP:Did you know#Cited hook|Cited]]',
status = hookCiteStatus,
isResolved = isHookSourceAGF
},
{
issue = 'Interesting',
status = args.hookinterest,
},
},
otherIssues = args.hookother,
}
end

local function makeImageEligibilitySection(args)
if args.status
and (args.picfree == 'na' or not args.picfree)
and not args.picused
and not args.picclear
then
return nil
end
return makeSection{
unresolvedHeader = "'''Image eligibility:'''",
resolvedHeader = "'''Image:''' Image is freely licensed, used in the article, and clear at 100px.",
mainIssues = {
{
issue = '[[WP:ICTIC|Freely licensed]]',
status = args.picfree,
},
{
issue = '[[WP:Did you know#Pictures|Used in article]]',
status = args.picused,
},
{
issue = 'Clear at 100px',
status = args.picclear,
},
},
}
end

local function makeQPQSection(args)
-- The QPQ section is different enough from the other sections that we
-- will just do everything here rather than trying to use the makeSection
-- function.
local isDone = yesno(args.qpq)
if isDone == true then
return makeUncollapsedWikitable("'''QPQ''': Done.")
elseif args.qpq == 'na' then
return makeUncollapsedWikitable("'''QPQ''': None required.")
else
local ret = makeChecklistItem(
"'''[[Wikipedia:Did you know#QPQ|QPQ]]'''",
isDone == false and 'Not done' or args.qpq
)
return ret .. '<br />'
end
end

local function makeStatusSection(args)
if not args.status then
return [['''<span style="color: red;">Review is incomplete - please fill in the "status" field</span>''']]
end

local ret = {}
table.insert(ret, "'''Overall''': ")
local isOK = yesno(args.status)
if isOK == true then
if args.hookcited == 'agf' then
table.insert(ret, statusIcons.YES_AGF)
else
table.insert(ret, statusIcons.YES)
end
elseif isOK == false then
table.insert(ret, statusIcons.NO)
elseif args.status == '?' then
table.insert(ret, statusIcons.QUESTION)
elseif args.status == 'maybe' then
table.insert(ret, statusIcons.MAYBE)
elseif args.status == 'again' then
table.insert(ret, statusIcons.AGAIN)
end
if args.comments then
table.insert(ret, ' ')
table.insert(ret, args.comments)
end
if args.sign then
table.insert(ret, ' ')
table.insert(ret, args.sign)
end
return table.concat(ret)
end

--------------------------------------------------------------------------------
-- Exports
--------------------------------------------------------------------------------

local p = {}

function p._main(args)
-- Normalize the args table to make it easier to work with in other
-- functions.
normalizeArguments(args)

-- Check whether the review has been started.
local params = {
'newness',
'length',
'eligibilityother',
'sourced',
'neutral',
'plagiarismfree',
'policyother',
'hookcited',
'hookother',
'hookcited',
'picfree',
'picused',
'picclear',
}
if not anyKeysInTable(args, params) then
return 'Review not started'
end

-- The review has been started, so assemble all the review sections.
local funcs = {
makeGeneralEligibilitySection,
makePolicyComplianceSection,
makeHookEligibilitySection,
makeImageEligibilitySection,
makeQPQSection,
makeStatusSection,
}
local ret = {}
for i, func in ipairs(funcs) do
table.insert(ret, func(args))
end
return table.concat(ret, '\n')
end

function p.main(frame)
local args = require('Module:Arguments').getArgs(frame, {
wrappers = 'Template:DYK checklist',
})
return p._main(args)
end

return p

Module:DYK checklist/sandbox - Revision history

WOSlinker: use require('strict') instead of require('Module:No globals')

Mr. Stradivarius: replace newlines with spaces in escapeUserString

Mr. Stradivarius: Make user-supplied strings easier to read in error messages

Mr. Stradivarius: put the invalid string in the status error message

Mr. Stradivarius: validate the status argument - now invalid values will produce a wikitext error

Mr. Stradivarius: copy from Module:DYK checklist