Module:DartsRankings/sandbox - Revision history

Aidan9382: loadData caches stuff itself (see mw:Extension:Scribunto/Lua_reference_manual#mw.loadData), so this is unlikely to improve much

2024-09-21T19:39:08Z

loadData caches stuff itself (see mw:Extension:Scribunto/Lua_reference_manual#mw.loadData), so this is unlikely to improve much

← Previous revision		Revision as of 19:39, 21 September 2024
Line 35:		Line 35:
	if parents.args['caption'] then templateArgs['caption'] = parents.args['caption'] end		if parents.args['caption'] then templateArgs['caption'] = parents.args['caption'] end
	end		end

	-- explicitly cache data to avoid calling mw.loadData too many times
	local dataCache = {}

	local function loadData(frame)		local function loadData(frame)
	~~local~~ ~~source~~ = ~~(templateArgs['org']~~ ~~and~~ templateArgs['org']~~..'~~ ~~Rankings') or frame.args[1]~~		if templateArgs['org'] then
		⚫	data = mw.loadData('Module:DartsRankings/data/' .. templateArgs['org'] .. ' Rankings');
	if dataCache[source] then
			else
	data = dataCache[source]
			local source = frame.args[1] -- source of rankings e.g. PDC Rankings
	return
			data = mw.loadData('Module:DartsRankings/data/'.. source);
	end		end
⚫	data = mw.loadData('Module:DartsRankings/data/'.. ~~source~~)
	dataCache[source] = data
	end		end

Hike395: explicitly cache data to avoid calling mw.loadData too many times

2024-09-21T19:13:33Z

explicitly cache data to avoid calling mw.loadData too many times

← Previous revision		Revision as of 19:13, 21 September 2024
Line 35:		Line 35:
	if parents.args['caption'] then templateArgs['caption'] = parents.args['caption'] end		if parents.args['caption'] then templateArgs['caption'] = parents.args['caption'] end
	end		end

			-- explicitly cache data to avoid calling mw.loadData too many times
			local dataCache = {}

	local function loadData(frame)		local function loadData(frame)
	if templateArgs['org'] ~~then~~		local source = (templateArgs['org'] and templateArgs['org']..' Rankings') or frame.args[1]
			if dataCache[source] then
⚫	data = mw.loadData('Module:DartsRankings/data/' .. ~~templateArgs['org'] .. ' Rankings'~~);
			data = dataCache[source]
	else
			return
	local source = frame.args[1] -- source of rankings e.g. PDC Rankings
		⚫	end
	data = mw.loadData('Module:DartsRankings/data/'.. source);
		⚫	data = mw.loadData('Module:DartsRankings/data/'.. source)
⚫	end
			dataCache[source] = data
	end		end

Hike395: caching doesn't work here

2024-09-21T19:03:20Z

caching doesn't work here

← Previous revision		Revision as of 19:03, 21 September 2024
Line 37:		Line 37:

	local function loadData(frame)		local function loadData(frame)
	if data then
	return
	end
	if templateArgs['org'] then		if templateArgs['org'] then
	data = mw.loadData('Module:DartsRankings/data/' .. templateArgs['org'] .. ' Rankings');		data = mw.loadData('Module:DartsRankings/data/' .. templateArgs['org'] .. ' Rankings');

Hike395: explicitly load once

2024-09-21T19:01:50Z

explicitly load once

← Previous revision		Revision as of 19:01, 21 September 2024
Line 37:		Line 37:

	local function loadData(frame)		local function loadData(frame)
			if data then
			return
			end
	if templateArgs['org'] then		if templateArgs['org'] then
	data = mw.loadData('Module:DartsRankings/data/' .. templateArgs['org'] .. ' Rankings');		data = mw.loadData('Module:DartsRankings/data/' .. templateArgs['org'] .. ' Rankings');
Line 83:		Line 86:
	}}		}}
	end		end

		⚫	local tableAccents = mw.loadData('Module:DartsRankings/data/other')

	local function noAc(str)		local function noAc(str)
⚫	local tableAccents = mw.loadData('Module:DartsRankings/data/other')
	return str:gsub("[%z\1-\127\194-\244][\128-\191]*", tableAccents)		return str:gsub("[%z\1-\127\194-\244][\128-\191]*", tableAccents)
	end		end

Hike395: typo

2024-09-21T18:56:00Z

typo

← Previous revision		Revision as of 18:56, 21 September 2024
Line 85:		Line 85:

	local function noAc(str)		local function noAc(str)
	local tableAccents = mw.loadData('Module:~~DartsRanking~~/data/other')		local tableAccents = mw.loadData('Module:DartsRankings/data/other')
	return str:gsub("[%z\1-\127\194-\244][\128-\191]*", tableAccents)		return str:gsub("[%z\1-\127\194-\244][\128-\191]*", tableAccents)
	end		end

Hike395: factor data out from Module:DartsRanking

2024-09-21T18:51:35Z

factor data out from Module:DartsRanking

@@ Line 85: / Line 85: @@
 local function noAc(str)
-    local tableAccents = {
+    local tableAccents = mw.loadData('Module:DartsRanking/data/other')
     return str:gsub("[%z\1-\127\194-\244][\128-\191]*", tableAccents)
 end

Aidan9382: minor loop improvements

2023-10-10T08:34:53Z

minor loop improvements

← Previous revision		Revision as of 08:34, 10 October 2023
Line 210:		Line 210:
	end		end
	flag= u[2] -- Flag string from libarary		flag= u[2] -- Flag string from libarary
		⚫	break
	end		end
	if templateArgs['flag'] then		end
			if templateArgs['flag'] then
	flag = templateArgs['flag']		flag = templateArgs['flag']
⚫	~~end~~
	end		end
	if side == 'right' then		if side == 'right' then

Aidan9382: test using mw.loadData

2023-10-10T08:18:58Z

test using mw.loadData

← Previous revision		Revision as of 08:18, 10 October 2023
Line 37:		Line 37:

	local function loadData(frame)		local function loadData(frame)
⚫	local source = frame.args[1] -- source of rankings e.g. PDC Rankings
⚫	data = ~~require~~('Module:DartsRankings/data/'.. source);
	if templateArgs['org'] then		if templateArgs['org'] then
	data = ~~require~~('Module:DartsRankings/data/' .. templateArgs['org'] .. ' Rankings');		data = mw.loadData('Module:DartsRankings/data/' .. templateArgs['org'] .. ' Rankings');
			else
		⚫	local source = frame.args[1] -- source of rankings e.g. PDC Rankings
		⚫	data = mw.loadData('Module:DartsRankings/data/'.. source);
	end		end
	end		end

Aidan9382: Sync to live

2023-10-10T08:14:31Z

Sync to live

← Previous revision		Revision as of 08:14, 10 October 2023
Line 186:		Line 186:

	if templateArgs['surname'] =='1' then		if templateArgs['surname'] =='1' then
	if ~~u[6]~~ ~~and~~ ~~u[6]~=""~~ then		if nlink == 1 then
			link = u[4]
			elseif u[6] and u[6]~="" then
	link = '[[' .. u[3] .. ' ' .. u[4] .. ' (' ..u[6] .. ')' .. '\|' .. u[4] ..']]'		link = '[[' .. u[3] .. ' ' .. u[4] .. ' (' ..u[6] .. ')' .. '\|' .. u[4] ..']]'
	else		else
Line 192:		Line 194:
	end		end
	elseif templateArgs['surname'] then		elseif templateArgs['surname'] then
	if ~~u[6]~~ ~~and~~ ~~u[6]~=""~~ then		if nlink == 1 then
			link = templateArgs['surname']
			elseif u[6] and u[6]~="" then
	link = '[[' .. u[3] .. ' ' .. u[4] .. ' (' ..u[6] .. ')' .. '\|' .. templateArgs['surname'] ..']]'		link = '[[' .. u[3] .. ' ' .. u[4] .. ' (' ..u[6] .. ')' .. '\|' .. templateArgs['surname'] ..']]'
	else		else
Line 203:		Line 207:
	link = frame:expandTemplate{title= 'sortname', args ={ u[3], u[4], nolink = nlink } }		link = frame:expandTemplate{title= 'sortname', args ={ u[3], u[4], nolink = nlink } }
	end		end

	end		end
	flag= u[2] -- Flag string from libarary		flag= u[2] -- Flag string from libarary
Line 299:		Line 302:

	if not templateArgs['nodate'] or templateArgs['nodate'] == "" then		if not templateArgs['nodate'] or templateArgs['nodate'] == "" then
	outputString = outputString .. ' ~~<small>~~(' .. getDate() .. ')~~</small>~~'		outputString = outputString .. ' (' .. getDate() .. ')'
	end		end
	if templateArgs['par'] and templateArgs['par'] ~= '' then		if templateArgs['par'] and templateArgs['par'] ~= '' then

WOSlinker: use require('strict') instead of require('Module:No globals')

2022-10-21T10:01:18Z

use require('strict') instead of require('Module:No globals')

← Previous revision		Revision as of 10:01, 21 October 2022
Line 1:		Line 1:
	require('~~Module:No globals~~');		require('strict');

	local p = {}		local p = {}