Module:Election results-STV - Revision history

Number 57: +

2025-03-02T01:07:43Z

← Previous revision		Revision as of 01:07, 2 March 2025
Line 333:		Line 333:
	row		row
	:tag('th')		:tag('th')
	:wikitext('First count')		:wikitext(args.firstround or 'First count')
	:attr('colspan', 2)		:attr('colspan', 2)

Line 348:		Line 348:
	row		row
	:tag('th')		:tag('th')
	:wikitext('Second count')		:wikitext(args.secondround or 'Second count')
	:attr('colspan', 2)		:attr('colspan', 2)
	end		end
Line 354:		Line 354:
	row		row
	:tag('th')		:tag('th')
	:wikitext('Third count')		:wikitext(args.thirdround or 'Third count')
	:attr('colspan', 2)		:attr('colspan', 2)
	end		end
Line 360:		Line 360:
	row		row
	:tag('th')		:tag('th')
	:wikitext('Fourth count')		:wikitext(args.fourthround or 'Fourth count')
	:attr('colspan', 2)		:attr('colspan', 2)
	end		end
Line 366:		Line 366:
	row		row
	:tag('th')		:tag('th')
	:wikitext('Fifth count')		:wikitext(args.fifthround or 'Fifth count')
	:attr('colspan', 2)		:attr('colspan', 2)
	end		end
Line 372:		Line 372:
	row		row
	:tag('th')		:tag('th')
	:wikitext('Sixth count')		:wikitext(args.sixthround or 'Sixth count')
	:attr('colspan', 2)		:attr('colspan', 2)
	end		end

Number 57: +

2024-11-15T20:32:46Z

← Previous revision		Revision as of 20:32, 15 November 2024
Line 717:		Line 717:
	:tag('td')		:tag('td')
	:attr('colspan', 3)		:attr('colspan', 3)
			:wikitext(args['row' .. v])
			end
			if args['row' .. v] and not has_party then
			row
			:css('background-color', rcolor)
			:tag('td')
	:wikitext(args['row' .. v])		:wikitext(args['row' .. v])
	end		end

Gonnym: There is a large amount of code duplication written in this module which makes it more complicated to debug. Consider using for loops and smaller functions to reduce the size of the code

2024-07-24T07:09:33Z

There is a large amount of code duplication written in this module which makes it more complicated to debug. Consider using for loops and smaller functions to reduce the size of the code

@@ Line 104: / Line 104: @@
 					has_party = true
 				end
 				if args['votes' .. i .. '_2'] then
 					has_votes2 = true
@@ Line 327: / Line 335: @@
 			:wikitext('First count')
 			:attr('colspan', 2)
 		if has_votes2 then
 			row

Number 57: Hmmm

2024-04-24T22:59:38Z

Hmmm

← Previous revision		Revision as of 22:59, 24 April 2024
Line 861:		Line 861:
	-- valid votes		-- valid votes

	local cs = 3		local cs = 3 - (has_party and 0 or 2)

	if args['invalidblank'] or args['invalid'] then		if args['invalidblank'] or args['invalid'] then

Number 57: Test

2024-04-24T22:59:00Z

Test

← Previous revision		Revision as of 22:59, 24 April 2024
Line 860:		Line 860:
	end		end
	-- valid votes		-- valid votes

			local cs = 3

	if args['invalidblank'] or args['invalid'] then		if args['invalidblank'] or args['invalid'] then

Number 57: Test

2024-04-24T22:58:36Z

Test

← Previous revision		Revision as of 22:58, 24 April 2024
Line 860:		Line 860:
	end		end
	-- valid votes		-- valid votes

	local cs = 3 - (has_party and 0 or 2)

	if args['invalidblank'] or args['invalid'] then		if args['invalidblank'] or args['invalid'] then

Number 57: +

2024-04-24T22:56:08Z

← Previous revision		Revision as of 22:56, 24 April 2024
Line 719:		Line 719:
	:wikitext(args['party' .. v])		:wikitext(args['party' .. v])
	end		end
			if has_votes then
	row:tag('td')		row:tag('td')
	:css('text-align', 'right')		:css('text-align', 'right')
Line 725:		Line 726:
	:css('text-align', 'right')		:css('text-align', 'right')
	:wikitext(pct(args['votes' .. v], valid[1]))		:wikitext(pct(args['votes' .. v], valid[1]))
			end
	if args['votes' .. v .. '_2'] then		if args['votes' .. v .. '_2'] then
	row:tag('td')		row:tag('td')

Number 57: ?

2024-04-24T22:53:59Z

← Previous revision		Revision as of 22:53, 24 April 2024
Line 224:		Line 224:
	local i = max_rows		local i = max_rows
	table.insert(index, i)		table.insert(index, i)
		⚫	args['row' .. i] = 'Total'
	args['votes' .. i] = showtotal.votes and valid[1] or nil		args['votes' .. i] = showtotal.votes and valid[1] or nil
	args['votes' .. i .. '_2'] = showtotal.votes_2 and valid[2] or nil		args['votes' .. i .. '_2'] = showtotal.votes_2 and valid[2] or nil
Line 239:		Line 240:
	args['colour' .. i] = 'inherit'		args['colour' .. i] = 'inherit'
	args['color' .. i] = 'inherit'		args['color' .. i] = 'inherit'
⚫	args['row' .. i] = 'Total'
	args['font-weight' .. i] = 'bold'		args['font-weight' .. i] = 'bold'
	args['class' .. i] = 'sortbottom'		args['class' .. i] = 'sortbottom'

Number 57: +

2024-04-24T20:25:00Z

← Previous revision		Revision as of 20:25, 24 April 2024
Line 62:		Line 62:
	local stop_flag = false		local stop_flag = false
	local i = 0		local i = 0
			local has_votes = args['votes' .. i]
	local has_votes2 = args['votes' .. i .. '_2']		local has_votes2 = args['votes' .. i .. '_2']
	local has_votes3 = args['votes' .. i .. '_3']		local has_votes3 = args['votes' .. i .. '_3']
Line 98:		Line 99:
	args['votes' .. i] = votesi		args['votes' .. i] = votesi
	valid[1] = valid[1] + votesi		valid[1] = valid[1] + votesi
			has_votes = true
	end		end
	if args['party' .. i] then		if args['party' .. i] then
Line 218:		Line 220:

	local ovalid = {valid[1], valid[2], valid[3], valid[4], valid[5], valid[6], valid[7], valid[8], valid[9], valid[10], valid[11], valid[12], valid[13]}		local ovalid = {valid[1], valid[2], valid[3], valid[4], valid[5], valid[6], valid[7], valid[8], valid[9], valid[10], valid[11], valid[12], valid[13]}
	if args['valid'] then		if has_votes or args['valid'] then
	max_rows = max_rows + 1		max_rows = max_rows + 1
	local i = max_rows		local i = max_rows

Number 57: +

2024-04-24T15:10:27Z

← Previous revision		Revision as of 15:10, 24 April 2024
Line 692:		Line 692:
	local rcolor = get_color(args['rcolour' .. v] or args['rcolor' .. v] or nil)		local rcolor = get_color(args['rcolour' .. v] or args['rcolor' .. v] or nil)

	if has_party then		if args['row' .. v] and has_party then
		⚫	row
		⚫	:css('background-color', rcolor)
		⚫	:tag('td')
			:attr('colspan', 3)
		⚫	:wikitext(args['row' .. v])
		⚫	end
		⚫	if has_party and not args['row' .. v] then
	row		row
	:tag('td')		:tag('td')
Line 705:		Line 712:
	:wikitext(args['cand' .. v])		:wikitext(args['cand' .. v])
	end		end
	if has_party then		if has_party and not args['row' .. v] then
	row		row
	:tag('td')		:tag('td')
	:wikitext(args['party' .. v])		:wikitext(args['party' .. v])
⚫	end
⚫	if args['row' .. v] then
⚫	row
⚫	:css('background-color', rcolor)
⚫	:tag('td')
⚫	:wikitext(args['row' .. v])
	end		end
	row:tag('td')		row:tag('td')