Module:External links/sandbox - Revision history

Lemondoge: Remove paranoid checks for if linkTemplate.[x] exists but is an empty string - that should be the config's problem, and if anything this should just error in that situation

2024-08-10T15:29:38Z

Remove paranoid checks for if linkTemplate.[x] exists but is an empty string - that should be the config's problem, and if anything this should just error in that situation

← Previous revision		Revision as of 15:29, 10 August 2024
Line 138:		Line 138:
	local langcode = linkTemplate.langcode		local langcode = linkTemplate.langcode
	if langcode		if langcode
	and langcode ~= ''
	and string.find(langcode, "[pP]%d+")		and string.find(langcode, "[pP]%d+")
	then		then
Line 311:		Line 310:
	-- to avoid deep tests		-- to avoid deep tests
	if not local_value or local_value == '' -- bail out if no value is present		if not local_value or local_value == '' -- bail out if no value is present
	or (linkTemplate.regex ~~and linkTemplate.regex ~= ''~~		or (linkTemplate.regex
	and not regexConverterTest(linkTemplate.regex, local_value))		and not regexConverterTest(linkTemplate.regex, local_value))
	then		then
Line 325:		Line 324:
	end		end
	end		end
	if wikidata_property or (linkTemplate.url ~~and linkTemplate.url ~= ''~~) or (linkTemplate.url_f) then		if wikidata_property or (linkTemplate.url) or (linkTemplate.url_f) then
	output[1] = {		output[1] = {
	langcode = string.find(linkTemplate.langcode, "[pP]%d+") and "" or linkTemplate.langcode,		langcode = string.find(linkTemplate.langcode, "[pP]%d+") and "" or linkTemplate.langcode,
Line 385:		Line 384:
	-- to avoid deep tests		-- to avoid deep tests
	if not local_value or local_value == '' -- bail out if no value is present		if not local_value or local_value == '' -- bail out if no value is present
	or (linkTemplate.regex ~~and linkTemplate.regex ~= ''~~		or (linkTemplate.regex
	and not regexConverterTest(linkTemplate.regex, local_value))		and not regexConverterTest(linkTemplate.regex, local_value))
	then		then
Line 399:		Line 398:
	end		end
	end		end
	if wikidata_property or (linkTemplate.url ~~and linkTemplate.url ~= ''~~) or (linkTemplate.url_f) then		if wikidata_property or (linkTemplate.url) or (linkTemplate.url_f) then
	output[1] = {		output[1] = {
	langcode = string.find(linkTemplate.langcode, "SL.+") and "" or linkTemplate.langcode,		langcode = string.find(linkTemplate.langcode, "SL.+") and "" or linkTemplate.langcode,

Lemondoge: turns out that I in fact DID goof this

2024-08-10T15:20:41Z

turns out that I in fact DID goof this

← Previous revision		Revision as of 15:20, 10 August 2024
Line 264:		Line 264:
	end		end
	if not (linkTemplate.regex and		if not (linkTemplate.regex and
	regexConverterTest(linkTemplate.regex, sitelink))		not regexConverterTest(linkTemplate.regex, sitelink))
	then		then
	output[1] = {		output[1] = {

Lemondoge: Update call to legacy function to new name

2024-08-04T16:04:29Z

Update call to legacy function to new name

← Previous revision		Revision as of 16:04, 4 August 2024
Line 16:		Line 16:
	label = mw.title.getCurrentTitle().text		label = mw.title.getCurrentTitle().text
	elseif not label then		elseif not label then
	label = mw.wikibase.~~label~~(entity.id) or mw.title.getCurrentTitle().text		label = mw.wikibase.getLabel(entity.id) or mw.title.getCurrentTitle().text
	end		end
	-- return use_genitive and genitive(label, 'sitt') or label		-- return use_genitive and genitive(label, 'sitt') or label

Lemondoge: Add detailed comment to getFormatterURL

2024-08-04T15:56:25Z

Add detailed comment to getFormatterURL

← Previous revision		Revision as of 15:56, 4 August 2024
Line 55:		Line 55:
	for _, claim in ipairs( statements ) do		for _, claim in ipairs( statements ) do
	local mainsnak = claim.mainsnak -- nil will be indexed if it doesn't exist		local mainsnak = claim.mainsnak -- nil will be indexed if it doesn't exist
			--[[
	-- get any qualifiers for this claim (we are interested in P1793 for
			Checks P1793 (format as a regular expression) qualifier of formatter URL to
	-- indication of which claim is correct)
			check if the given string matches the formatter URL's regex;
			will prioritize that formatter URL if true
			]]
	local qualifiers = claim.qualifiers or {}		local qualifiers = claim.qualifiers or {}
	-- now let's check the qualifier we are interested in
	local qualid = 'P1793' -- format as a regular expression		local qualid = 'P1793' -- format as a regular expression
	-- if the claim has this qualifier
	if qualifiers[qualid] then		if qualifiers[qualid] then
	-- ~~it's~~ ~~here,~~ ~~let's~~ ~~check~~ it ~~out!~~		-- we have a regex qualifier, traverse all snaks
	-- traverse all snaks in this qualifier
	for _, qualsnak in ipairs( qualifiers[qualid] ) do		for _, qualsnak in ipairs( qualifiers[qualid] ) do
	if qualsnak.snaktype == 'value'		if qualsnak.snaktype == 'value'

Lemondoge: Reduce paranoia

2024-08-03T17:26:53Z

Reduce paranoia

← Previous revision		Revision as of 17:26, 3 August 2024
Line 54:		Line 54:
	-- let's go through the claims		-- let's go through the claims
	for _, claim in ipairs( statements ) do		for _, claim in ipairs( statements ) do
	local mainsnak = claim.mainsnak or {}		local mainsnak = claim.mainsnak -- nil will be indexed if it doesn't exist
	-- get any qualifiers for this claim (we are interested in P1793 for		-- get any qualifiers for this claim (we are interested in P1793 for
	-- indication of which claim is correct)		-- indication of which claim is correct)

Lemondoge: reduce confidence in comment

2024-08-03T16:57:59Z

reduce confidence in comment

← Previous revision		Revision as of 16:57, 3 August 2024
Line 7:		Line 7:
	local hasdatafromwikidata = false		local hasdatafromwikidata = false
	local hasdatafromlocal = false		local hasdatafromlocal = false
	local haswikidatalink = true -- whether or not this page has a wikidata entity; we assume there is one at first		local haswikidatalink = true -- whether or not this page has a wikidata entity(?); we assume there is one at first

	local p = {}		local p = {}

Lemondoge: Undo "goof" fix when it actually wasn't a goof

2024-08-03T16:50:36Z

Undo "goof" fix when it actually wasn't a goof

← Previous revision		Revision as of 16:50, 3 August 2024
Line 264:		Line 264:
	end		end
	if not (linkTemplate.regex and		if not (linkTemplate.regex and
	~~not~~ regexConverterTest(linkTemplate.regex, sitelink))		regexConverterTest(linkTemplate.regex, sitelink))
	then		then
	output[1] = {		output[1] = {

Lemondoge: Improve clarity of "getValuesFromWikidata" by moving stuff around

2024-08-02T16:42:41Z

Improve clarity of "getValuesFromWikidata" by moving stuff around

← Previous revision		Revision as of 16:42, 2 August 2024
Line 131:		Line 131:
	-- let's go through the claims		-- let's go through the claims
	for _, claim in ipairs( statements ) do		for _, claim in ipairs( statements ) do
		⚫	output[#output + 1] = { value=stringFormatter(claim.mainsnak.datavalue) }
			--- Check if the linkTemplate wants us to search a qualifier for languagedata

	local qualifiers = claim.qualifiers or {}		local qualifiers = claim.qualifiers or {}
	-- get the content of the claim (the identifier)		-- get the content of the claim (the identifier)
Line 164:		Line 167:
	I'm not sure if that functionality would've had any purpose, given how cryptic this function is.		I'm not sure if that functionality would've had any purpose, given how cryptic this function is.
	]]		]]
⚫	output[#output+1] = { value=stringFormatter(claim.mainsnak.datavalue) }
	if langcode and langcode ~= '' then		if langcode and langcode ~= '' then
	output[#output]['langcode'] = langcode		output[#output].langcode = langcode
	end		end
	end		end

Lemondoge: Improve comment for clarity

2024-08-02T16:30:09Z

Improve comment for clarity

← Previous revision		Revision as of 16:30, 2 August 2024
Line 7:		Line 7:
	local hasdatafromwikidata = false		local hasdatafromwikidata = false
	local hasdatafromlocal = false		local hasdatafromlocal = false
	local haswikidatalink = true -- we assume ~~it's~~ ~~connected~~		local haswikidatalink = true -- whether or not this page has a wikidata entity; we assume there is one at first

	local p = {}		local p = {}

Lemondoge: fix goof I introduced accidentally

2024-08-01T18:05:21Z

fix goof I introduced accidentally

← Previous revision		Revision as of 18:05, 1 August 2024
Line 262:		Line 262:
	end		end
	if not (linkTemplate.regex and		if not (linkTemplate.regex and
	regexConverterTest(linkTemplate.regex, sitelink))		not regexConverterTest(linkTemplate.regex, sitelink))
	then		then
	output[1] = {		output[1] = {