Module:Goalscorers - Revision history

Jts1882: Undid revision 1284281081 by Jts1882 (talk) revert test for now

2025-04-06T17:01:31Z

Undid revision 1284281081 by Jts1882 (talk) revert test for now

@@ Line 732: / Line 732: @@
     -- if all scorers on one goal, tableString isn't updated in loop above (may need to generalise for other goal number)
     if  goalNumber == 1 and rank <= maxRank then
 		       local rowSpan = rankCount + 1

Jts1882: temporary test edit (see talk page)

2025-04-06T17:00:42Z

temporary test edit (see talk page)

@@ Line 732: / Line 732: @@
     -- if all scorers on one goal, tableString isn't updated in loop above (may need to generalise for other goal number)
     if  goalNumber == 1 and rank <= maxRank then
 		       local rowSpan = rankCount + 1

Jts1882: undo test until further testing

2025-03-27T18:16:01Z

undo test until further testing

← Previous revision		Revision as of 18:16, 27 March 2025
Line 708:		Line 708:
	else -- else generate previous rowspan		else -- else generate previous rowspan
	local rowSpan = rankCount		local rowSpan = rankCount
	if playerCount > maxRank * 1.5 ~~or (rankCount >10 )~~then		if playerCount > maxRank * 1.5 then
	firstplayerCell = '\n\| style="font-style:italic;text-align:center;"\|' .. rankCount .. " players"		firstplayerCell = '\n\| style="font-style:italic;text-align:center;"\|' .. rankCount .. " players"
	playerCells = ""		playerCells = ""
Line 727:		Line 727:
	end		end
	else -- else another player with same number of goals		else -- else another player with same number of goals
		⚫	playerCells = playerCells .. '\n\|-' .. '\n\|' .. goalscorerString -- add to player cell list
	local test = ""
	if rankCount > 10 then test ="ten" end

⚫	playerCells = playerCells .. '\n\|-' .. '\n\|' .. goalscorerString ~~.. test~~ -- add to player cell list
	end		end
	end -- reached end of list of goalscorers [for j,u loop]		end -- reached end of list of goalscorers [for j,u loop]

	-- if all scorers on one goal, tableString isn't updated in loop above (may need to generalise for other goal number)		-- if all scorers on one goal, tableString isn't updated in loop above (may need to generalise for other goal number)
	if goalNumber == 1 and rankCount > 10 then
	firstplayerCell = "\n\|''" .. rankCount .. " players''"
	playerCells = "" --goalNumber
	rankCount = 0
	end
	if goalNumber == 1 and rank <= maxRank then		if goalNumber == 1 and rank <= maxRank then
	local rowSpan = rankCount + 1		local rowSpan = rankCount + 1

Jts1882: test for issue on module talk page

2025-03-27T18:15:26Z

test for issue on module talk page

← Previous revision		Revision as of 18:15, 27 March 2025
Line 708:		Line 708:
	else -- else generate previous rowspan		else -- else generate previous rowspan
	local rowSpan = rankCount		local rowSpan = rankCount
	if playerCount > maxRank * 1.5 then		if playerCount > maxRank * 1.5 or (rankCount >10 )then
	firstplayerCell = '\n\| style="font-style:italic;text-align:center;"\|' .. rankCount .. " players"		firstplayerCell = '\n\| style="font-style:italic;text-align:center;"\|' .. rankCount .. " players"
	playerCells = ""		playerCells = ""
Line 727:		Line 727:
	end		end
	else -- else another player with same number of goals		else -- else another player with same number of goals
			local test = ""
⚫	playerCells = playerCells .. '\n\|-' .. '\n\|' .. goalscorerString -- add to player cell list
			if rankCount > 10 then test ="ten" end

		⚫	playerCells = playerCells .. '\n\|-' .. '\n\|' .. goalscorerString .. test -- add to player cell list
	end		end
	end -- reached end of list of goalscorers [for j,u loop]		end -- reached end of list of goalscorers [for j,u loop]

	-- if all scorers on one goal, tableString isn't updated in loop above (may need to generalise for other goal number)		-- if all scorers on one goal, tableString isn't updated in loop above (may need to generalise for other goal number)
			if goalNumber == 1 and rankCount > 10 then
			firstplayerCell = "\n\|''" .. rankCount .. " players''"
			playerCells = "" --goalNumber
			rankCount = 0
			end
	if goalNumber == 1 and rank <= maxRank then		if goalNumber == 1 and rank <= maxRank then
	local rowSpan = rankCount + 1		local rowSpan = rankCount + 1

Jkudlick: build 1 goal table if rank <= maxRank; weird error where not displaying at rank = 3

2025-03-24T01:37:08Z

build 1 goal table if rank <= maxRank; weird error where not displaying at rank = 3

← Previous revision		Revision as of 01:37, 24 March 2025
Line 732:		Line 732:

	-- if all scorers on one goal, tableString isn't updated in loop above (may need to generalise for other goal number)		-- if all scorers on one goal, tableString isn't updated in loop above (may need to generalise for other goal number)
	if goalNumber == 1 and rank == 1 then		if goalNumber == 1 and rank <= maxRank then
	local rowSpan = rankCount + 1		local rowSpan = rankCount + 1
	tableString = tableString .. '\n\|-\n\| style="text-align:center;" rowspan="' .. rowSpan .. '"\|' .. rank		tableString = tableString .. '\n\|-\n\| style="text-align:center;" rowspan="' .. rowSpan .. '"\|' .. rank

Jkudlick: fixing error where last goalscorers in table are repeated if on one goal

2025-03-23T23:51:40Z

fixing error where last goalscorers in table are repeated if on one goal

← Previous revision		Revision as of 23:51, 23 March 2025
Line 732:		Line 732:

	-- if all scorers on one goal, tableString isn't updated in loop above (may need to generalise for other goal number)		-- if all scorers on one goal, tableString isn't updated in loop above (may need to generalise for other goal number)
	if goalNumber == 1 then		if goalNumber == 1 and rank == 1 then
	local rowSpan = rankCount + 1		local rowSpan = rankCount + 1
	tableString = tableString .. '\n\|-\n\| style="text-align:center;" rowspan="' .. rowSpan .. '"\|' .. rank		tableString = tableString .. '\n\|-\n\| style="text-align:center;" rowspan="' .. rowSpan .. '"\|' .. rank

MusikBot II: Changed protection settings for "Module:Goalscorers": High-risk template or module: 2501 transclusions (more info) ([Edit=Require extended confirmed access] (indefinite) [Move=Require extended confirmed access] (indefinite))

2025-02-21T18:01:19Z

Changed protection settings for "Module:Goalscorers": High-risk template or module: 2501 transclusions (more info) ([Edit=Require extended confirmed access] (indefinite) [Move=Require extended confirmed access] (indefinite))

← Previous revision	Revision as of 18:01, 21 February 2025
(No difference)

Shonebrooks: I corrected the spelling of "function." WP:TYPO

2024-12-18T20:40:23Z

I corrected the spelling of "function." WP:TYPO

← Previous revision		Revision as of 20:40, 18 December 2024
Line 458:		Line 458:
	p.sortComment(comment)		p.sortComment(comment)
	p.getCountryName(country)		p.getCountryName(country)
	p.sortGoalscorers() -- the main sort ~~funtion~~		p.sortGoalscorers() -- the main sort function

	]]		]]

Jts1882: statNumber in useTemplateData() only needed for goals (assists is a flag)

2024-10-27T09:10:31Z

statNumber in useTemplateData() only needed for goals (assists is a flag)

← Previous revision		Revision as of 09:10, 27 October 2024
Line 898:		Line 898:
	{{#if:{{{extra\|}}}\|{{{extra}}}{{clear}}\|}}		{{#if:{{{extra\|}}}\|{{{extra}}}{{clear}}\|}}
	--]]		--]]
	local statNumber = mw.getLanguage('en'):formatNum( tonumber( g.args['goals'] ~~or g.args['assists']~~ or 0) ) --format number as string		local statNumber = mw.getLanguage('en'):formatNum( tonumber( g.args['goals'] or 0) ) --format goal number as string
	local matches = g.args['matches']		local matches = g.args['matches']
	local statType = "goal"		local statType = "goal"

Jts1882: format number as string in template parameter version (e.g. 2,452 goals)

2024-10-16T11:50:48Z

format number as string in template parameter version (e.g. 2,452 goals)

← Previous revision		Revision as of 11:50, 16 October 2024
Line 898:		Line 898:
	{{#if:{{{extra\|}}}\|{{{extra}}}{{clear}}\|}}		{{#if:{{{extra\|}}}\|{{{extra}}}{{clear}}\|}}
	--]]		--]]
	local statNumber = g.args['goals'] or g.args['assists'] or 0		local statNumber = mw.getLanguage('en'):formatNum( tonumber( g.args['goals'] or g.args['assists'] or 0) ) --format number as string
	local matches = g.args['matches']		local matches = g.args['matches']
	local statType = "goal"		local statType = "goal"
Line 934:		Line 934:
	local text = ""		local text = ""
	if g.args['goals'] then		if g.args['goals'] then
	text = string.format("%s %s %d %s%s scored%s",		text = string.format("%s %s %s %s%s scored%s",
	text1, text2, statNumber, statType, goalPlural, averageString..updateString..sep)		text1, text2, statNumber, statType, goalPlural, averageString..updateString..sep)
	end		end