Module:Icon/testcases - Revision history

Mr. Stradivarius: use descriptive sentences for test cases, and generate the test data table every time, just in case the main module does something funny with it

2021-08-29T06:12:51Z

use descriptive sentences for test cases, and generate the test data table every time, just in case the main module does something funny with it

Show changes

Mr. Stradivarius: test leaving link data out of the data table

2021-08-29T05:51:58Z

test leaving link data out of the data table

← Previous revision		Revision as of 05:51, 29 August 2021
Line 13:		Line 13:
	tooltip = "Good article",		tooltip = "Good article",
	link = false,		link = false,
			},
			wikipedia = {
			image = "Wikipedia-logo.svg",
			tooltip = "Wikipedia page",
	},		},
	_DEFAULT = {		_DEFAULT = {
Line 71:		Line 75:
	self:assertStringContains(linkPattern, icon{'ga'})		self:assertStringContains(linkPattern, icon{'ga'})
	self:assertNotStringContains(linkPattern, icon{'fa'})		self:assertNotStringContains(linkPattern, icon{'fa'})
			self:assertNotStringContains(linkPattern, icon{'wikipedia'})
	end		end

Mr. Stradivarius: define a data table locally to make the tests more stable, and add a test for link suppression

2021-08-29T05:46:17Z

define a data table locally to make the tests more stable, and add a test for link suppression

← Previous revision		Revision as of 05:46, 29 August 2021
Line 2:		Line 2:
	local ScribuntoUnit = require('Module:ScribuntoUnit')		local ScribuntoUnit = require('Module:ScribuntoUnit')
	local suite = ScribuntoUnit:new()		local suite = ScribuntoUnit:new()

			local ICON_DATA = {
			fa = {
			image = "Featured article star.svg",
			tooltip = "Featured article",
			link = true,
			},
			ga = {
			image = "Symbol support vote.svg",
			tooltip = "Good article",
			link = false,
			},
			_DEFAULT = {
			image = "Symbol question.svg",
			link = false,
			}
			}

			-- Use a shortcut function to call mIcon._main using the icon data we define
			-- above.
			local function icon(args)
			return mIcon._main(args, ICON_DATA)
		⚫	end

	function suite:assertIsFileLink(s)		function suite:assertIsFileLink(s)
Line 9:		Line 32:

	function suite:testIsFileLink()		function suite:testIsFileLink()
	self:assertIsFileLink(~~mIcon._main~~{})		self:assertIsFileLink(icon{})
	self:assertIsFileLink(~~mIcon._main~~{'fa'})		self:assertIsFileLink(icon{'fa'})
	self:assertIsFileLink(~~mIcon._main~~{'qwertyuiop'})		self:assertIsFileLink(icon{'qwertyuiop'})
	end		end

	function suite:testGA()		function suite:testGA()
	self:assertStringContains('Symbol support vote.svg', ~~mIcon._main~~{'ga'}, true)		self:assertStringContains('Symbol support vote.svg', icon{'ga'}, true)
	self:assertStringContains('Good article', ~~mIcon._main~~{'ga'}, true)		self:assertStringContains('Good article', icon{'ga'}, true)
	end		end

	function suite:testDefaultSize()		function suite:testDefaultSize()
	self:assertStringContains('16x16px', ~~mIcon._main~~{})		self:assertStringContains('16x16px', icon{})
	end		end

	function suite:testCustomSize()		function suite:testCustomSize()
	self:assertStringContains('320px', ~~mIcon._main~~{size = '320px'})		self:assertStringContains('320px', icon{size = '320px'})
⚫	end

⚫	function suite:testAlias()
⚫	self:assertStringContains('Former featured article', mIcon._main{'dfa'})
	end		end

	function suite:testCodeWhitespace()		function suite:testCodeWhitespace()
	self:assertStringContains('Featured article', ~~mIcon._main~~{' fa '})		self:assertStringContains('Featured article', icon{' fa '})
	end		end

	function suite:testCodeCapitalization()		function suite:testCodeCapitalization()
	self:assertStringContains('Featured article', ~~mIcon._main~~{'FA'})		self:assertStringContains('Featured article', icon{'FA'})
	end		end

	function suite:testClassParameter()		function suite:testClassParameter()
	self:assertStringContains('Featured article', ~~mIcon._main~~{class = 'fa'})		self:assertStringContains('Featured article', icon{class = 'fa'})
	end		end

	function suite:testClassParameterOverride()		function suite:testClassParameterOverride()
	self:assertNotStringContains('Featured article', ~~mIcon._main~~{'fa', class = 'ga'})		self:assertNotStringContains('Featured article', icon{'fa', class = 'ga'})
	self:assertNotStringContains('Featured article', ~~mIcon._main~~{'fa', class = ''})		self:assertNotStringContains('Featured article', icon{'fa', class = ''})
			end

			function suite:testLinkSuppression()
			local linkPattern = '\|link=[\|%]]'
			self:assertStringContains(linkPattern, icon{'ga'})
			self:assertNotStringContains(linkPattern, icon{'fa'})
			end

			-- Functions that test the original data

		⚫	function suite:testAlias()
		⚫	self:assertStringContains('Former featured article', mIcon._main{'dfa'})
	end		end

Mr. Stradivarius: add check for noviewer class

2021-08-29T00:51:51Z

add check for noviewer class

← Previous revision		Revision as of 00:51, 29 August 2021
Line 1:		Line 1:
	local mIcon = require('Module:Icon')		local mIcon = require('Module:Icon/sandbox')
	local ScribuntoUnit = require('Module:ScribuntoUnit')		local ScribuntoUnit = require('Module:ScribuntoUnit')
	local suite = ScribuntoUnit:new()		local suite = ScribuntoUnit:new()
Line 5:		Line 5:
	function suite:assertIsFileLink(s)		function suite:assertIsFileLink(s)
	self:assertStringContains('^%[%[File:[^%]]+%]%]$', s)		self:assertStringContains('^%[%[File:[^%]]+%]%]$', s)
			self:assertStringContains('\|class=noviewer', s, true)
	end		end

Mr. Stradivarius: remove template testing functionality, as it wasn't being used and we probably don't need it

2021-08-29T00:49:28Z

remove template testing functionality, as it wasn't being used and we probably don't need it

← Previous revision		Revision as of 00:49, 29 August 2021
Line 2:		Line 2:
	local ScribuntoUnit = require('Module:ScribuntoUnit')		local ScribuntoUnit = require('Module:ScribuntoUnit')
	local suite = ScribuntoUnit:new()		local suite = ScribuntoUnit:new()
	local frame = mw.getCurrentFrame()

	-- This function is used to run all the instances of Icon, so that we can easily
	-- switch between the module and the template.
	local function icon(args)
	-- return frame:expandTemplate{title = 'icon/sandbox', args = args}
	return mIcon._main(args)
	end

	function suite:assertIsFileLink(s)		function suite:assertIsFileLink(s)
Line 16:		Line 8:

	function suite:testIsFileLink()		function suite:testIsFileLink()
	self:assertIsFileLink(~~icon~~{})		self:assertIsFileLink(mIcon._main{})
	self:assertIsFileLink(~~icon~~{'fa'})		self:assertIsFileLink(mIcon._main{'fa'})
	self:assertIsFileLink(~~icon~~{'qwertyuiop'})		self:assertIsFileLink(mIcon._main{'qwertyuiop'})
	end		end

	function suite:testGA()		function suite:testGA()
	self:assertStringContains('Symbol support vote.svg', ~~icon~~{'ga'}, true)		self:assertStringContains('Symbol support vote.svg', mIcon._main{'ga'}, true)
	self:assertStringContains('Good article', ~~icon~~{'ga'}, true)		self:assertStringContains('Good article', mIcon._main{'ga'}, true)
	end		end

	function suite:testDefaultSize()		function suite:testDefaultSize()
	self:assertStringContains('16x16px', ~~icon~~{})		self:assertStringContains('16x16px', mIcon._main{})
	end		end

	function suite:testCustomSize()		function suite:testCustomSize()
	self:assertStringContains('320px', ~~icon~~{size = '320px'})		self:assertStringContains('320px', mIcon._main{size = '320px'})
	end		end

	function suite:testAlias()		function suite:testAlias()
	self:assertStringContains('Former featured article', ~~icon~~{'dfa'})		self:assertStringContains('Former featured article', mIcon._main{'dfa'})
	end		end

	function suite:testCodeWhitespace()		function suite:testCodeWhitespace()
	self:assertStringContains('Featured article', ~~icon~~{' fa '})		self:assertStringContains('Featured article', mIcon._main{' fa '})
	end		end

	function suite:testCodeCapitalization()		function suite:testCodeCapitalization()
	self:assertStringContains('Featured article', ~~icon~~{'FA'})		self:assertStringContains('Featured article', mIcon._main{'FA'})
	end		end

	function suite:testClassParameter()		function suite:testClassParameter()
	self:assertStringContains('Featured article', ~~icon~~{class = 'fa'})		self:assertStringContains('Featured article', mIcon._main{class = 'fa'})
	end		end

	function suite:testClassParameterOverride()		function suite:testClassParameterOverride()
	self:assertNotStringContains('Featured article', ~~icon~~{'fa', class = 'ga'})		self:assertNotStringContains('Featured article', mIcon._main{'fa', class = 'ga'})
	self:assertNotStringContains('Featured article', ~~icon~~{'fa', class = ''})		self:assertNotStringContains('Featured article', mIcon._main{'fa', class = ''})
	end		end

Mr. Stradivarius: simplify file link pattern check

2021-08-29T00:46:11Z

simplify file link pattern check

← Previous revision		Revision as of 00:46, 29 August 2021
Line 11:		Line 11:
	end		end

		⚫	function suite:assertIsFileLink(s)
	local fileLinkPattern
			self:assertStringContains('^%[%[File:[^%]]+%]%]$', s)
	do
	local spaces = '[_ \t]*'
	local titleChar = '[^\|<>%[%]{}]'
	local titleCharOrPipe = '[^<>%[%]{}]'
	fileLinkPattern = '^%[%[' .. spaces .. '(.-)' .. spaces .. ':' .. spaces ..
	titleChar .. '-' .. titleCharOrPipe .. '-\|' .. titleChar .. '-\|' ..
	spaces .. 'link=' .. spaces .. '%]%]$'
	end

⚫	function suite:~~assertFileLink~~(s)
	local nsText = s:match(fileLinkPattern)
	nsText = nsText and nsText:lower()
	self:assertTrue(nsText == 'file' or nsText == 'image')
	end		end

	function suite:testIsFileLink()		function suite:testIsFileLink()
	self:~~assertFileLink~~(icon{})		self:assertIsFileLink(icon{})
	self:~~assertFileLink~~(icon{'fa'})		self:assertIsFileLink(icon{'fa'})
	self:~~assertFileLink~~(icon{'qwertyuiop'})		self:assertIsFileLink(icon{'qwertyuiop'})
	end		end

Mr. Stradivarius: move declarations to the top

2015-01-23T10:28:21Z

move declarations to the top

← Previous revision		Revision as of 10:28, 23 January 2015
Line 1:		Line 1:
	local mIcon = require('Module:Icon')		local mIcon = require('Module:Icon')
		⚫	local ScribuntoUnit = require('Module:ScribuntoUnit')
		⚫	local suite = ScribuntoUnit:new()
		⚫	local frame = mw.getCurrentFrame()

	-- This function is used to run all the instances of Icon, so that we can easily		-- This function is used to run all the instances of Icon, so that we can easily
Line 7:		Line 10:
	return mIcon._main(args)		return mIcon._main(args)
	end		end

⚫	local ScribuntoUnit = require('Module:ScribuntoUnit')
⚫	local suite = ScribuntoUnit:new()
⚫	local frame = mw.getCurrentFrame()

	local fileLinkPattern		local fileLinkPattern

Mr. Stradivarius: make it clearer what we are running

2015-01-23T10:09:42Z

make it clearer what we are running

@@ Line 1: / Line 1: @@
 local mIcon = require('Module:Icon')
 local ScribuntoUnit = require('Module:ScribuntoUnit')
 local suite = ScribuntoUnit:new()
@@ Line 12: / Line 20: @@
 		titleChar .. '-' .. titleCharOrPipe .. '-|' .. titleChar .. '-|' ..
 		spaces .. 'link=' .. spaces .. '%]%]$'
 end

Mr. Stradivarius: only make the file link pattern once

2015-01-23T10:07:06Z

only make the file link pattern once

← Previous revision		Revision as of 10:07, 23 January 2015
Line 4:		Line 4:
	local frame = mw.getCurrentFrame()		local frame = mw.getCurrentFrame()

	local ~~function icon(args)~~		local fileLinkPattern
			do
⚫	-- return frame:expandTemplate{title = 'icon', args = args}
⚫	return mIcon._main(args)
⚫	end

⚫	function suite:assertFileLink(s)
	local spaces = '[_ \t]*'		local spaces = '[_ \t]*'
	local titleChar = '[^\|<>%[%]{}]'		local titleChar = '[^\|<>%[%]{}]'
	local titleCharOrPipe = '[^<>%[%]{}]'		local titleCharOrPipe = '[^<>%[%]{}]'
	~~local pattern~~ = '^%[%[' .. spaces .. '(.-)' .. spaces .. ':' .. spaces ..		fileLinkPattern = '^%[%[' .. spaces .. '(.-)' .. spaces .. ':' .. spaces ..
	titleChar .. '-' .. titleCharOrPipe .. '-\|' .. titleChar .. '-\|' ..		titleChar .. '-' .. titleCharOrPipe .. '-\|' .. titleChar .. '-\|' ..
	spaces .. 'link=' .. spaces .. '%]%]$'		spaces .. 'link=' .. spaces .. '%]%]$'
		⚫	end
⚫	local nsText = s:match(~~pattern~~)

			local function icon(args)
		⚫	return frame:expandTemplate{title = 'icon/sandbox', args = args}
		⚫	-- return mIcon._main(args)
			end

		⚫	function suite:assertFileLink(s)
		⚫	local nsText = s:match(fileLinkPattern)
	nsText = nsText and nsText:lower()		nsText = nsText and nsText:lower()
	self:assertTrue(nsText == 'file' or nsText == 'image')		self:assertTrue(nsText == 'file' or nsText == 'image')

Mr. Stradivarius: create

2015-01-23T09:47:39Z

create

New page

local mIcon = require('Module:Icon')
local ScribuntoUnit = require('Module:ScribuntoUnit')
local suite = ScribuntoUnit:new()
local frame = mw.getCurrentFrame()

local function icon(args)
-- return frame:expandTemplate{title = 'icon', args = args}
return mIcon._main(args)
end

function suite:assertFileLink(s)
local spaces = '[_ \t]*'
local titleChar = '[^|<>%[%]{}]'
local titleCharOrPipe = '[^<>%[%]{}]'
local pattern = '^%[%[' .. spaces .. '(.-)' .. spaces .. ':' .. spaces ..
titleChar .. '-' .. titleCharOrPipe .. '-|' .. titleChar .. '-|' ..
spaces .. 'link=' .. spaces .. '%]%]$'
local nsText = s:match(pattern)
nsText = nsText and nsText:lower()
self:assertTrue(nsText == 'file' or nsText == 'image')
end

function suite:testIsFileLink()
self:assertFileLink(icon{})
self:assertFileLink(icon{'fa'})
self:assertFileLink(icon{'qwertyuiop'})
end

function suite:testGA()
self:assertStringContains('Symbol support vote.svg', icon{'ga'}, true)
self:assertStringContains('Good article', icon{'ga'}, true)
end

function suite:testDefaultSize()
self:assertStringContains('16x16px', icon{})
end

function suite:testCustomSize()
self:assertStringContains('320px', icon{size = '320px'})
end

function suite:testAlias()
self:assertStringContains('Former featured article', icon{'dfa'})
end

function suite:testCodeWhitespace()
self:assertStringContains('Featured article', icon{' fa '})
end

function suite:testCodeCapitalization()
self:assertStringContains('Featured article', icon{'FA'})
end

function suite:testClassParameter()
self:assertStringContains('Featured article', icon{class = 'fa'})
end

function suite:testClassParameterOverride()
self:assertNotStringContains('Featured article', icon{'fa', class = 'ga'})
self:assertNotStringContains('Featured article', icon{'fa', class = ''})
end

return suite