Module:JCW - Revision history

Aidan9382: Discourage potentially creating linter errors

2022-10-21T10:51:19Z

Discourage potentially creating linter errors

← Previous revision		Revision as of 10:51, 21 October 2022
Line 175:		Line 175:
	else		else
	rows[i] = string.format("\n**<code>%s</code>", v		rows[i] = string.format("\n**<code>%s</code>", v
	:gsub("%.%", "<b><~~font~~ style=color:#006400;>.</~~font~~></b>")		:gsub("%.%", "<b><span style=color:#006400;>.</span></b>")
	:gsub("!", "<b><~~font~~ style=color:#8B0000;>!</~~font~~></b>")		:gsub("!", "<b><span style=color:#8B0000;>!</span></b>")
	:gsub("'", "’")		:gsub("'", "’")
	)		)

Headbomb: +UCG

2021-09-22T23:48:36Z

+UCG

← Previous revision		Revision as of 23:48, 22 September 2021
Line 65:		Line 65:
	['User:JL-Bot/Questionable.cfg'] = true,		['User:JL-Bot/Questionable.cfg'] = true,
	}		}
	--local abbrev = {BLJ = '[https://beallslist.weebly.com/standalone-journals.html BLJ]', BLJU='[https://beallslist.weebly.com/standalone-journals.html BLJU]', BLP='[https://beallslist.weebly.com/ BLP]', BLPU='[https://beallslist.weebly.com/ BLPU]', SPJJ = '[https://predatoryjournals.com/journals/ SPJJ]', SPJP = '[https://predatoryjournals.com/publishers/ SPJP]', DOAJ='[https://blog.doaj.org/2014/08/28/some-journals-say-they-are-in-doaj-when-they-are-not/ Lying about DOAJ]', QW ='[https://www.quackwatch.org/04ConsumerEducation/nonrecperiodicals.html QW]', DEPS ='[[WP:DEPS\|DEPS]]', URF ='[[#Unreliable fields\|URF]]'}		--local abbrev = {BLJ = '[https://beallslist.weebly.com/standalone-journals.html BLJ]', BLJU='[https://beallslist.weebly.com/standalone-journals.html BLJU]', BLP='[https://beallslist.weebly.com/ BLP]', BLPU='[https://beallslist.weebly.com/ BLPU]', SPJJ = '[https://predatoryjournals.com/journals/ SPJJ]', SPJP = '[https://predatoryjournals.com/publishers/ SPJP]', DOAJ='[https://blog.doaj.org/2014/08/28/some-journals-say-they-are-in-doaj-when-they-are-not/ Lying about DOAJ]', UCG='[https://www.ugc.ac.in/journallist/4305_Journals.pdf Removed from UGC]' QW ='[https://www.quackwatch.org/04ConsumerEducation/nonrecperiodicals.html QW]', DEPS ='[[WP:DEPS\|DEPS]]', URF ='[[#Unreliable fields\|URF]]'}
	local abbrev = {Bohannon = 'Bohannon', BLJ = 'BLJ', BLJU= 'BLJU', BLP = 'BLP', BLPU = 'BLPU', SPJJ ='SPJJ', SPJP ='SPJP', DOAJ = 'DOAJ', QW='QW', DEPS ='DEPS', URF = 'URF', Unknown = 'Unknown'}		local abbrev = {Bohannon = 'Bohannon', BLJ = 'BLJ', BLJU= 'BLJU', BLP = 'BLP', BLPU = 'BLPU', SPJJ ='SPJJ', SPJP ='SPJP', DOAJ = 'DOAJ', QW='QW', DEPS ='DEPS', UCG = 'UCG', URF = 'URF', Unknown = 'Unknown'}
	local source		local source
	if wantSource[mw.title.getCurrentTitle().fullText] then		if wantSource[mw.title.getCurrentTitle().fullText] then

Cupcake547: Made singular noun plural in a comment

2021-04-04T21:12:52Z

Made singular noun plural in a comment

← Previous revision		Revision as of 21:12, 4 April 2021
Line 12:		Line 12:

	local function getDoiArgs(args)		local function getDoiArgs(args)
	-- Return a list of \|doiN=xxx parameter values, omitting blanks and skipped N.		-- Return a list of \|doiN=xxx parameter values, omitting blanks and skipped N's.
	-- LATER Should expand this to work with each exported function.		-- LATER Should expand this to work with each exported function.
	local indices = {}		local indices = {}

Johnuniq: properly skip blanks for doilist

2020-12-13T00:06:10Z

properly skip blanks for doilist

← Previous revision		Revision as of 00:06, 13 December 2020
Line 2:		Line 2:
	local mArguments = require('Module:Arguments')		local mArguments = require('Module:Arguments')
	local TableTools = require('Module:TableTools')		local TableTools = require('Module:TableTools')

			local function stripToNil(text)
			-- If text is a non-empty string, return its trimmed content.
			-- Otherwise, return nothing (text is an empty string or is not a string).
			if type(text) == 'string' then
			return text:match('(%S.-)%s*$')
			end
			end

	local function getDoiArgs(args)		local function getDoiArgs(args)
	-- Return a list of \|doiN=xxx parameter values, omitting blanks.		-- Return a list of \|doiN=xxx parameter values, omitting blanks and skipped N.
	-- LATER Should ~~have~~ expand this to work with each exported function.		-- LATER Should expand this to work with each exported function.
	local indices = {}		local indices = {}
	for k, _ in pairs(args) do		for k, v in pairs(args) do
	if type(k) == 'string' then		if stripToNil(v) and type(k) == 'string' then
	local n = tonumber(k:match('^doi(%d+)$'))		local n = tonumber(k:match('^doi(%d+)$'))
	if n then		if n then
Line 17:		Line 25:
	table.sort(indices)		table.sort(indices)
	local parms = {}		local parms = {}
	if args.doi then		if stripToNil(args.doi) then
	if args.doi1 then		if args.doi1 then
	error('Use doi or doi1, not both', 0)		error('Use doi or doi1, not both', 0)

Johnuniq: middot needs double bold

2020-11-29T00:00:42Z

middot needs double bold

← Previous revision		Revision as of 00:00, 29 November 2020
Line 140:		Line 140:
	return		return
	" \| <b><span class=plainlinks>" ..		" \| <b><span class=plainlinks>" ..
	table.concat(doiList, ' · ') ..		table.concat(doiList, ' <b>·</b> ') .. -- middot is double bold
	"</span></b>"		"</span></b>"
	end		end

Johnuniq: implement {{#invoke:JCW|doilist}} to process doiN parameters for Template:JCW-PUB-rank and Template:JCW-CRAP-rank

2020-11-28T23:46:55Z

implement {{#invoke:JCW|doilist}} to process doiN parameters for Template:JCW-PUB-rank and Template:JCW-CRAP-rank

@@ Line 2: / Line 2: @@
 local mArguments = require('Module:Arguments')
 local TableTools = require('Module:TableTools')
 function p.selected(frame)
@@ Line 70: / Line 118: @@
 		addDoi(doi, i)
 	end
 	for i = 1, nrDoi do
 		local doi = listDoi[i]
 		table.insert(rows,
+		)
 	end
 	rows[1] = table.concat(rows[1], ' / ')
 	return table.concat(rows, '\n')
 end

Johnuniq: drastically prune search URL (not sure how this still works!) to fix :Category:Pages where template include size is exceeded problem at User:JL-Bot/Publishers.cfg

2020-11-02T06:08:00Z

drastically prune search URL (not sure how this still works!) to fix Category:Pages where template include size is exceeded problem at User:JL-Bot/Publishers.cfg

← Previous revision		Revision as of 06:08, 2 November 2020
Line 70:		Line 70:
	addDoi(doi, i)		addDoi(doi, i)
	end		end
	local search = 'https://en.wikipedia.org/w/index.php?~~sort=relevance&title=Special%3ASearch&profile=advanced&fulltext=1&advancedSearch-current={}&~~ns0=1&ns118=1&search=insource%3A'		local search = 'https://en.wikipedia.org/w/index.php?ns0=1&ns118=1&search=insource%3A'
	local suffix = '%5C%2F%20%2F' -- '%20' seems redundant but is needed for Special:Search to work ('x*' also works)		local suffix = '%5C%2F%20%2F' -- '%20' seems redundant but is needed for Special:Search to work ('x*' also works)
	for i = 1, nrDoi do		for i = 1, nrDoi do

Johnuniq: p.selected: positional (numbered) DOI parameters work the same as named parameters; merge both types if used together; remove a redundant backslash from insource gsub

2020-11-01T05:57:02Z

p.selected: positional (numbered) DOI parameters work the same as named parameters; merge both types if used together; remove a redundant backslash from insource gsub

← Previous revision		Revision as of 05:57, 1 November 2020
Line 25:		Line 25:
	else		else
	sourcenote = ''		sourcenote = ''
		⚫	end
			local listDoi, nrDoi = {}, 0
			local function addDoi(doi, i)
			if doi then
			nrDoi = nrDoi + 1
			if i and listDoi[i] then
			table.insert(listDoi, i, doi)
			else
			listDoi[nrDoi] = doi
			end
			end
	end		end
	local rows = {}		local rows = {}
	for i, v in ipairs(TableTools.compressSparseArray(n)) do		for i, v in ipairs(TableTools.compressSparseArray(n)) do
	if i == 1 then		if i == 1 then
	rows[i] = { string.format('* [[:%s]]%s', v, sourcenote) }		rows[1] = { string.format('*[[:%s]]%s', v, sourcenote) }
			elseif v:match('^10%.%d+$') then
			addDoi(v)
	else		else
	rows~~[i] =~~ string.format('** [[:%s]]', v)		table.insert(rows, string.format('**[[:%s]]', v))
	end		end
	end		end
Line 45:		Line 58:
	end		end
	end		end

	if n.doi and n.doi1 then		if n.doi and n.doi1 then
	error('Use doi or doi1, not both', 0)		error('Use doi or doi1, not both', 0)
	end		end
⚫	local search = 'https://en.wikipedia.org/w/index.php?sort=relevance&title=Special%3ASearch&profile=advanced&fulltext=1&advancedSearch-current={}&ns0=1&ns118=1&search=insource%3A'
	local suffix = '%5C%2F%20*%2F'
	for i = 1, 10 do		for i = 1, 10 do
	local doi		local doi
Line 58:		Line 68:
	doi = n['doi' .. i]		doi = n['doi' .. i]
	end		end
	~~if not~~ doi ~~then~~		addDoi(doi, i)
			end
	break
		⚫	local search = 'https://en.wikipedia.org/w/index.php?sort=relevance&title=Special%3ASearch&profile=advanced&fulltext=1&advancedSearch-current={}&ns0=1&ns118=1&search=insource%3A'
⚫	end
			local suffix = '%5C%2F%20%2F' -- '%20' seems redundant but is needed for Special:Search to work ('x*' also works)
			for i = 1, nrDoi do
			local doi = listDoi[i]
	table.insert(rows,		table.insert(rows,
	string.format('** <code>{{doi\|[%s%s%s %s]}}</code>', search, doi:gsub('10%.', '\/10\\.'), suffix, doi)		string.format('**<code>{{doi\|[%s%s%s %s]}}</code>', search, doi:gsub('10%.', '/10\\.'), suffix, doi)
	)		)
	end		end

Johnuniq: don't need ustring.gsub here, and this fixes "Lua error: not enough memory" and some hidden bugs at User:JL-Bot/Maintenance.cfg

2020-10-31T01:28:58Z

don't need ustring.gsub here, and this fixes "Lua error: not enough memory" and some hidden bugs at User:JL-Bot/Maintenance.cfg

@@ Line 56: / Line 56: @@
 			doi = n.doi or n.doi1
 		else
-			doi = n['doi'	.. i]
+			doi = n['doi' .. i]
 		end
 		if not doi then
@@ Line 76: / Line 76: @@
 	for _, v in ipairs(TableTools.compressSparseArray(n)) do
 		if length > 1 then
-			text = text..string.format(" ≠ [[:%s]]", v)
+			text = text .. string.format(" ≠ [[:%s]]", v)
 		end
 	end
@@ Line 83: / Line 83: @@
 function p.pattern(frame)
 	end
 end

Johnuniq: whitelist for source

2020-03-07T23:54:18Z

whitelist for source

← Previous revision		Revision as of 23:54, 7 March 2020
Line 6:		Line 6:
	local n = mArguments.getArgs(frame, {parentOnly = true})		local n = mArguments.getArgs(frame, {parentOnly = true})
	local note = n.note		local note = n.note
	local ~~source~~ = ~~n.source or 'Unknown'~~		local wantSource = {
			['User:JL-Bot/Questionable.cfg'] = true,
⚫	~~local title =~~ mw.title.getCurrentTitle().fullText
			}
	if title == 'User:JL-Bot/Publishers.cfg' or title == 'User:JL-Bot/Maintenance.cfg' then
	source = nil
⚫	end
	--local abbrev = {BLJ = '[https://beallslist.weebly.com/standalone-journals.html BLJ]', BLJU='[https://beallslist.weebly.com/standalone-journals.html BLJU]', BLP='[https://beallslist.weebly.com/ BLP]', BLPU='[https://beallslist.weebly.com/ BLPU]', SPJJ = '[https://predatoryjournals.com/journals/ SPJJ]', SPJP = '[https://predatoryjournals.com/publishers/ SPJP]', DOAJ='[https://blog.doaj.org/2014/08/28/some-journals-say-they-are-in-doaj-when-they-are-not/ Lying about DOAJ]', QW ='[https://www.quackwatch.org/04ConsumerEducation/nonrecperiodicals.html QW]', DEPS ='[[WP:DEPS\|DEPS]]', URF ='[[#Unreliable fields\|URF]]'}		--local abbrev = {BLJ = '[https://beallslist.weebly.com/standalone-journals.html BLJ]', BLJU='[https://beallslist.weebly.com/standalone-journals.html BLJU]', BLP='[https://beallslist.weebly.com/ BLP]', BLPU='[https://beallslist.weebly.com/ BLPU]', SPJJ = '[https://predatoryjournals.com/journals/ SPJJ]', SPJP = '[https://predatoryjournals.com/publishers/ SPJP]', DOAJ='[https://blog.doaj.org/2014/08/28/some-journals-say-they-are-in-doaj-when-they-are-not/ Lying about DOAJ]', QW ='[https://www.quackwatch.org/04ConsumerEducation/nonrecperiodicals.html QW]', DEPS ='[[WP:DEPS\|DEPS]]', URF ='[[#Unreliable fields\|URF]]'}
	local abbrev = {Bohannon = 'Bohannon', BLJ = 'BLJ', BLJU= 'BLJU', BLP = 'BLP', BLPU = 'BLPU', SPJJ ='SPJJ', SPJP ='SPJP', DOAJ = 'DOAJ', QW='QW', DEPS ='DEPS', URF = 'URF', Unknown = 'Unknown'}		local abbrev = {Bohannon = 'Bohannon', BLJ = 'BLJ', BLJU= 'BLJU', BLP = 'BLP', BLPU = 'BLPU', SPJJ ='SPJJ', SPJP ='SPJP', DOAJ = 'DOAJ', QW='QW', DEPS ='DEPS', URF = 'URF', Unknown = 'Unknown'}
	~~source = abbrev[source] or~~ source		local source
		⚫	if wantSource[mw.title.getCurrentTitle().fullText] then
			source = n.source or 'Unknown'
			source = abbrev[source] or source
		⚫	end
	local sourcenote		local sourcenote
	if note and source then		if note and source then
Line 85:		Line 87:
	n[1] = nil --make next loop only target arguments >=2		n[1] = nil --make next loop only target arguments >=2
	for _, v in ipairs(TableTools.compressSparseArray(n)) do		for _, v in ipairs(TableTools.compressSparseArray(n)) do
	text = text..string.format("\n** <code>%s</code>", v)		text = text..string.format("\n** <code>%s</code>", v)
	text = mw.ustring.gsub(text, "%.%", "<b><font style=color:#006400;>.</font></b>")		text = mw.ustring.gsub(text, "%.%", "<b><font style=color:#006400;>.</font></b>")
	text = mw.ustring.gsub(text, "!", "<b><font style=color:#8B0000;>!</font></b>")		text = mw.ustring.gsub(text, "!", "<b><font style=color:#8B0000;>!</font></b>")
	text = mw.ustring.gsub(text, "'", "’")		text = mw.ustring.gsub(text, "'", "’")
	end		end
	return text		return text