Module:Lockbox - Revision history

Pppery: ... I told you so! ...

2024-11-10T06:48:34Z

... I told you so! ...

← Previous revision		Revision as of 06:48, 10 November 2024
Line 44:		Line 44:
	-- This creates an extaneous self-transclusion for all pages using the		-- This creates an extaneous self-transclusion for all pages using the
	-- module, but we treat that as a necessary evil.		-- module, but we treat that as a necessary evil.

			--[[ This entire block no longer works following https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Scribunto/+/1074581
	do		do
	mw.title.getCurrentTitle():getContent() -- Generate self-transclusion		mw.title.getCurrentTitle():getContent() -- Generate self-transclusion
Line 54:		Line 56:
	end		end
	end		end
			--]]

	-- Generate transclusions to the templates, and build the output list.		-- Generate transclusions to the templates, and build the output list.

Izno: swap to error

2021-05-03T18:34:10Z

swap to error

← Previous revision		Revision as of 18:34, 3 May 2021
Line 15:		Line 15:

	local function make_wikitext_warning(msg)		local function make_wikitext_warning(msg)
	return string.format('<strong class="~~warning~~">Warning: %s.</strong>', msg)		return string.format('<strong class="error">Warning: %s.</strong>', msg)
	end		end

MSGJ: Avoid an unnecessary call to frame:preprocess, code by User:Jackmcbarn

2020-08-02T14:37:03Z

Avoid an unnecessary call to frame:preprocess, code by User:Jackmcbarn

← Previous revision		Revision as of 14:37, 2 August 2020
Line 44:		Line 44:
	-- This creates an extaneous self-transclusion for all pages using the		-- This creates an extaneous self-transclusion for all pages using the
	-- module, but we treat that as a necessary evil.		-- module, but we treat that as a necessary evil.
	--
	-- XXX: there seems to be no way to check for cascading protection using a
	-- Scribunto API, so we have to use frame:preprocess with the
	-- CASCADINGSOURCES parser function.
	do		do
	mw.title.getCurrentTitle():getContent() -- Generate self-transclusion		mw.title.getCurrentTitle():getContent() -- Generate self-transclusion
	local parent_title = frame:getParent():getTitle()		local parent_title = frame:getParent():getTitle()
	if ~~frame:preprocess('{{CASCADINGSOURCES:'~~ .. parent_title .. ~~'}}') == ''~~ then		if not mw.title.new(parent_title).cascadingProtection.sources[1] then
	warnings[#warnings + 1] = make_wikitext_warning(string.format(		warnings[#warnings + 1] = make_wikitext_warning(string.format(
	'the page "%s" is not cascade-protected',		'the page "%s" is not cascade-protected',

Mr. Stradivarius: don't show warnings on pages transcluding a lockbox, and make page-name-processing logic more robust by using mw.title objects

2017-03-17T03:39:48Z

don't show warnings on pages transcluding a lockbox, and make page-name-processing logic more robust by using mw.title objects

Show changes

Mr. Stradivarius: Protected "Module:Lockbox": High-risk Lua module ([Edit=Allow only administrators] (indefinite) [Move=Allow only administrators] (indefinite))

2016-01-10T02:27:47Z

Protected "Module:Lockbox": High-risk Lua module ([Edit=Allow only administrators] (indefinite) [Move=Allow only administrators] (indefinite))

← Previous revision	Revision as of 02:27, 10 January 2016
(No difference)

Mr. Stradivarius: remove trailing newline

2016-01-10T02:22:36Z

remove trailing newline

← Previous revision		Revision as of 02:22, 10 January 2016
Line 32:		Line 32:
	if not ns or not mw.site.namespaces[ns] then		if not ns or not mw.site.namespaces[ns] then
	generate_transclusion('Template:' .. item)		generate_transclusion('Template:' .. item)
	output[#output + 1] = '* [[Template:' .. item .. ']]\n'		output[#output + 1] = '* [[Template:' .. item .. ']]'
	elseif (ns == "File") or (ns == "Image") then		elseif (ns == "File") or (ns == "Image") then
	generate_transclusion(item)		generate_transclusion(item)
	output[#output + 1] = '* [[:' .. item .. ']]\n'		output[#output + 1] = '* [[:' .. item .. ']]'
	elseif ns == "Category" then		elseif ns == "Category" then
	generate_transclusion(item)		generate_transclusion(item)
	output[#output + 1] = '* [[:' .. item .. ']]\n'		output[#output + 1] = '* [[:' .. item .. ']]'
	elseif rest ~= '' then		elseif rest ~= '' then
	generate_transclusion(item)		generate_transclusion(item)
	output[#output + 1] = '* [[' .. item .. ']]\n'		output[#output + 1] = '* [[' .. item .. ']]'
	end		end
	end		end
Line 48:		Line 48:
	return ""		return ""
	else		else
	return table.concat(output)		return table.concat(output, '\n')
	end		end
	end		end

Kephir: avoid table.insert (2x speed improvement!)

2014-08-10T13:29:49Z

avoid table.insert (2x speed improvement!)

← Previous revision		Revision as of 13:29, 10 August 2014
Line 21:		Line 21:
	mw.title.getCurrentTitle():getContent() -- self-transclude; see [[mw:Extension:Scribunto/Lua reference manual#Title objects]]		mw.title.getCurrentTitle():getContent() -- self-transclude; see [[mw:Extension:Scribunto/Lua reference manual#Title objects]]
	if frame:preprocess "{{CASCADINGSOURCES}}" == "" then		if frame:preprocess "{{CASCADINGSOURCES}}" == "" then
	~~table.insert(~~output, '<strong class="warning">Warning: this page (' .. mw.title.getCurrentTitle().fullText .. ') is not cascade-protected.</strong>\n')		output[#output + 1] = '<strong class="warning">Warning: this page (' .. mw.title.getCurrentTitle().fullText .. ') is not cascade-protected.</strong>\n'
	end		end

Line 32:		Line 32:
	if not ns or not mw.site.namespaces[ns] then		if not ns or not mw.site.namespaces[ns] then
	generate_transclusion('Template:' .. item)		generate_transclusion('Template:' .. item)
	~~table.insert(~~output, '* [[Template:' .. item .. ']]\n')		output[#output + 1] = '* [[Template:' .. item .. ']]\n'
	elseif (ns == "File") or (ns == "Image") then		elseif (ns == "File") or (ns == "Image") then
	generate_transclusion(item)		generate_transclusion(item)
	~~table.insert(~~output, '* [[:' .. item .. ']]\n')		output[#output + 1] = '* [[:' .. item .. ']]\n'
	elseif ns == "Category" then		elseif ns == "Category" then
	generate_transclusion(item)		generate_transclusion(item)
	~~table.insert(~~output, '* [[:' .. item .. ']]\n')		output[#output + 1] = '* [[:' .. item .. ']]\n'
	elseif rest ~= '' then		elseif rest ~= '' then
	generate_transclusion(item)		generate_transclusion(item)
	~~table.insert(~~output, '* [[' .. item .. ']]\n')		output[#output + 1] = '* [[' .. item .. ']]\n'
	end		end
	end		end

Kephir: local getContent (though it should not matter)

2014-08-05T06:42:04Z

local getContent (though it should not matter)

← Previous revision		Revision as of 06:42, 5 August 2014
Line 6:		Line 6:
	do		do
	local mock_title = mw.title.new(mw.title.getCurrentTitle().id)		local mock_title = mw.title.new(mw.title.getCurrentTitle().id)
	~~rawset(mock_title,~~ 'getContent', mock_title.getContent)		local getContent = mock_title.getContent
	function generate_transclusion(title)		function generate_transclusion(title)
	rawset(mock_title, 'fullText', title)		rawset(mock_title, 'fullText', title)
	~~mock_title:~~getContent()		getContent(mock_title)
	end		end
			-- I can do the same thing without rawset.
	end		end

Kephir: playing dirty

2014-08-05T06:27:41Z

playing dirty

← Previous revision		Revision as of 06:27, 5 August 2014
Line 1:		Line 1:
	local export = {}		local export = {}

			-- XXX: OUTRAGEOUS ABUSE OF SCRIBUNTO API
			-- generates a transclusion without incrementing the "expensive function" count
			local generate_transclusion
			do
			local mock_title = mw.title.new(mw.title.getCurrentTitle().id)
			rawset(mock_title, 'getContent', mock_title.getContent)
			function generate_transclusion(title)
			rawset(mock_title, 'fullText', title)
			mock_title:getContent()
			end
			end

	function export.lock(frame)		function export.lock(frame)
Line 12:		Line 24:

	local match = string.match		local match = string.match
	local args = { }

	for _, item in ipairs(frame.args) do		for _, item in ipairs(frame.args) do
Line 19:		Line 30:
	local ns, rest = match(item, "^(.-):(.*)")		local ns, rest = match(item, "^(.-):(.*)")
	if not ns or not mw.site.namespaces[ns] then		if not ns or not mw.site.namespaces[ns] then
	~~mw.title.makeTitle~~('Template', item~~):getContent(~~)		generate_transclusion('Template:' .. item)
	table.insert(output, '* [[Template:' .. item .. ']]\n')		table.insert(output, '* [[Template:' .. item .. ']]\n')
	elseif (ns == "File") or (ns == "Image") then		elseif (ns == "File") or (ns == "Image") then
			generate_transclusion(item)
	mw.title.makeTitle('File', rest):getContent()
	table.insert(output, '* [[:' .. item .. ']]\n')		table.insert(output, '* [[:' .. item .. ']]\n')
	elseif ns == "Category" then		elseif ns == "Category" then
			generate_transclusion(item)
	mw.title.makeTitle('Category', rest):getContent()
	table.insert(output, '* [[:' .. item .. ']]\n')		table.insert(output, '* [[:' .. item .. ']]\n')
	elseif rest ~= '' then		elseif rest ~= '' then
			generate_transclusion(item)
	mw.title.makeTitle(ns, rest):getContent()
	table.insert(output, '* [[' .. item .. ']]\n')		table.insert(output, '* [[' .. item .. ']]\n')
	end		end

Kephir: ns, rest

2014-08-05T06:11:22Z

ns, rest

← Previous revision		Revision as of 06:11, 5 August 2014
Line 28:		Line 28:
	table.insert(output, '* [[:' .. item .. ']]\n')		table.insert(output, '* [[:' .. item .. ']]\n')
	elseif rest ~= '' then		elseif rest ~= '' then
	mw.title.makeTitle(~~item~~, ''):getContent()		mw.title.makeTitle(ns, rest):getContent()
	table.insert(output, '* [[' .. item .. ']]\n')		table.insert(output, '* [[' .. item .. ']]\n')
	end		end