Module:Lua call - Revision history

HouseBlaster: HouseBlaster moved page Module:LuaCall to Module:Lua call: expand module name in the spirit of WP:TPN

2025-02-12T06:59:57Z

HouseBlaster moved page Module:LuaCall to Module:Lua call: expand module name in the spirit of WP:TPN

← Previous revision	Revision as of 06:59, 12 February 2025
(No difference)

Lemondoge: Modified code formatting

2023-04-04T19:01:48Z

Modified code formatting

← Previous revision		Revision as of 19:01, 4 April 2023
Line 2:		Line 2:

	function p.main(frame)		function p.main(frame)
	local parent=frame.getParent(frame) or {}		local parent = frame.getParent(frame) or {}
	local reserved_value={}		local reserved_value = {}
	local reserved_function,reserved_contents		local reserved_function, reserved_contents
	for k,v in pairs(parent.args or {}) do		for k, v in pairs(parent.args or {}) do
	_G[k]=tonumber(v) or v -- transfer every parameter directly to the global variable table		_G[k] = tonumber(v) or v -- transfer every parameter directly to the global variable table
	end		end
	for k,v in pairs(frame.args or {}) do		for k, v in pairs(frame.args or {}) do
	_G[k]=tonumber(v) or v -- transfer every parameter directly to the global variable table		_G[k] = tonumber(v) or v -- transfer every parameter directly to the global variable table
	end		end
	--- Alas Scribunto does NOT implement coroutines, according to		--- Alas Scribunto does NOT implement coroutines, according to
Line 15:		Line 15:
	--- this will not stop us from trying to implement one single lousy function call		--- this will not stop us from trying to implement one single lousy function call
	if _G[1] then		if _G[1] then
	reserved_function,reserved_contents=mw.ustring.match(_G[1],"^%s(%a[^%s%(])%(([^%)])%)%s$")		reserved_function, reserved_contents = mw.ustring.match(_G[1], "^%s(%a[^%s%(])%(([^%)])%)%s$")
	end		end
	if reserved_contents then		if reserved_contents then
	local reserved_counter=0		local reserved_counter = 0
	repeat		repeat
	reserved_counter=reserved_counter+1		reserved_counter = reserved_counter + 1
	reserved_value[reserved_counter]=_G[mw.ustring.match(reserved_contents,"([^%,]+)")]		reserved_value[reserved_counter] = _G[mw.ustring.match(reserved_contents, "([^%,]+)")]
	reserved_contents=mw.ustring.match(reserved_contents,"[^%,]+,(.*)$")		reserved_contents = mw.ustring.match(reserved_contents, "[^%,]+,(.*)$")
	until not reserved_contents		until not reserved_contents
	end		end
	local reserved_arraypart=_G		local reserved_arraypart = _G
	while mw.ustring.match(reserved_function,"%.") do		while mw.ustring.match(reserved_function, "%.") do
	reserved_functionpart,reserved_function=mw.ustring.match(reserved_function,"^(%a[^%.])%.(.)$")		reserved_functionpart, reserved_function = mw.ustring.match(reserved_function, "^(%a[^%.])%.(.)$")
	reserved_arraypart=reserved_arraypart[reserved_functionpart]		reserved_arraypart = reserved_arraypart[reserved_functionpart]
	end		end
	local reserved_call=reserved_arraypart[reserved_function]		local reserved_call = reserved_arraypart[reserved_function]
	if type(reserved_call)~="function" then		if type(reserved_call) ~= "function" then
	return tostring(reserved_call)		return tostring(reserved_call)
	else		else
	reserved_output={reserved_call(unpack(reserved_value))}		reserved_output = {reserved_call(unpack(reserved_value))}
	return reserved_output[reserved_return or 1]		return reserved_output[reserved_return or 1]
	end		end

Lemondoge: Quick simplification - use "elseif" instead of "else if" (in addition, improve formatting slightly)

2023-04-03T19:24:14Z

Quick simplification - use "elseif" instead of "else if" (in addition, improve formatting slightly)

← Previous revision		Revision as of 19:24, 3 April 2023
Line 33:		Line 33:
	if type(reserved_call)~="function" then		if type(reserved_call)~="function" then
	return tostring(reserved_call)		return tostring(reserved_call)
	else reserved_output={reserved_call(unpack(reserved_value))}		else
			reserved_output={reserved_call(unpack(reserved_value))}
	return reserved_output[reserved_return or 1]		return reserved_output[reserved_return or 1]
	end		end
Line 152:		Line 153:
	pfargs[2], usedpargs[2] = pframe.args[2], true		pfargs[2], usedpargs[2] = pframe.args[2], true
	end		end
			elseif not pfargs[2] then
	else
	~~if not~~ pfargs[2] ~~then~~		pfargs[2], usedpargs[1] = pframe.args[1], true
	pfargs[2], usedpargs[1] = pframe.args[1], true
	end
	end		end
	-- repack sequential args		-- repack sequential args

50.53.12.84: convert "invoke" to do a true #invoke off the parent frame instead of mangling the frame args and attempting to emulate a #invoke as the emulation is error prone and can easily be detected

2021-12-29T04:21:53Z

convert "invoke" to do a true #invoke off the parent frame instead of mangling the frame args and attempting to emulate a #invoke as the emulation is error prone and can easily be detected

@@ Line 144: / Line 144: @@
 --]]
 function p.invoke(frame)
-	if frame.args[1] ~= nil then
+	local pfargs = setmetatable({frame.args[1], frame.args[2]}, {__index = table})
-			func = m[frame.args[2]]
+		if not pfargs[2] then
 		end
 	else
 	end
-	for _, v in ipairsAtOffset(frame.args, offset) do
+	for i, v in ipairs(pframe.args) do
-		table.insert(args, v)
+			pfargs:insert(v)
 	end
 end

Pppery: You can already force the value to be a string with a leading /, as Template:Nowiki2 already does

2020-10-11T15:11:45Z

You can already force the value to be a string with a leading /, as Template:Nowiki2 already does

@@ Line 42: / Line 42: @@
 end
-local function pairs2ArrayWithFunc(f, ...)
+local function callWithTonumberOrStringOnPairs(f, ...)
 	local args = {}
 	for _, v in ... do
-		table.insert(args, f(v))
+		table.insert(args, tonumberOrString(v))
 	end
-	return args
+	return (f(unpack(args)))
 end
@@ Line 79: / Line 71: @@
 	end
 	return G
 end
@@ Line 113: / Line 98: @@
 --]]
 function p.call(frame)
-	return call(frame.args[1],
+	return callWithTonumberOrStringOnPairs(get(frame.args[1]),
-		pairs2ArrayWithFunc(tonumberOrString, ipairsAtOffset(frame.args, 1)),
+		ipairsAtOffset(frame.args, 1)
+	)
 end

Ans: auto converting argument to number often lead to bug, ex. {{#invoke:LuaCall|call|mw.text.nowiki|0001}}, p.call_s is easier for user to use (and tend to produce less bug) than p.call when all argument is to be string

2020-10-11T15:02:44Z

auto converting argument to number often lead to bug, ex. {{#invoke:LuaCall|call|mw.text.nowiki|0001}}, p.call_s is easier for user to use (and tend to produce less bug) than p.call when all argument is to be string

@@ Line 42: / Line 42: @@
 end
-local function callWithTonumberOrStringOnPairs(f, ...)
+local function pairs2ArrayWithFunc(f, ...)
 	local args = {}
 	for _, v in ... do
-		table.insert(args, tonumberOrString(v))
+		table.insert(args, f(v))
 	end
-	return (f(unpack(args)))
+	return args
 end
@@ Line 71: / Line 79: @@
 	end
 	return G
 end
@@ Line 98: / Line 113: @@
 --]]
 function p.call(frame)
-	return callWithTonumberOrStringOnPairs(get(frame.args[1]),
+	return call(frame.args[1],
-		ipairsAtOffset(frame.args, 1)
+		pairs2ArrayWithFunc(tonumberOrString, ipairsAtOffset(frame.args, 1)),
+	)
 end

Pppery: This module is complicated enough as is. You don't need to add even more tangential functions, when p.call was working perfectly fine for months

2020-10-11T14:13:07Z

This module is complicated enough as is. You don't need to add even more tangential functions, when p.call was working perfectly fine for months

@@ Line 42: / Line 42: @@
 end
-local function pairs2ArrayWithFunc(f, ...)
+local function callWithTonumberOrStringOnPairs(f, ...)
 	local args = {}
 	for _, v in ... do
-		table.insert(args, f(v))
+		table.insert(args, tonumberOrString(v))
 	end
-	return args
+	return (f(unpack(args)))
 end
@@ Line 79: / Line 71: @@
 	end
 	return G
 end
@@ Line 113: / Line 98: @@
 --]]
 function p.call(frame)
-	return call(frame.args[1],
+	return callWithTonumberOrStringOnPairs(get(frame.args[1]),
-		pairs2ArrayWithFunc(tonumberOrString, ipairsAtOffset(frame.args, 1)),
+		ipairsAtOffset(frame.args, 1)
+	)
 end

Ans: fix

2020-10-11T12:49:25Z

fix

← Previous revision		Revision as of 12:49, 11 October 2020
Line 83:		Line 83:
	local function call(s, args, ret)		local function call(s, args, ret)
	if ret then		if ret then
	return ({get(s)(unpack(args))})[ret]		return ({get(s)(unpack(args))})[tonumber(ret)]
	end		end
	return get(s)(unpack(args))		return get(s)(unpack(args))

Ans: args.return

2020-10-11T12:45:06Z

args.return

← Previous revision		Revision as of 12:45, 11 October 2020
Line 115:		Line 115:
	return call(frame.args[1],		return call(frame.args[1],
	pairs2ArrayWithFunc(tonumberOrString, ipairsAtOffset(frame.args, 1)),		pairs2ArrayWithFunc(tonumberOrString, ipairsAtOffset(frame.args, 1)),
	frame['return']		frame.args['return']
	)		)
	end		end
Line 129:		Line 129:
	return call(frame.args[1],		return call(frame.args[1],
	pairs2ArrayWithFunc(tonumber, ipairsAtOffset(frame.args, 1)),		pairs2ArrayWithFunc(tonumber, ipairsAtOffset(frame.args, 1)),
	frame['return']		frame.args['return']
	)		)
	end		end
Line 146:		Line 146:
	return call(frame.args[1],		return call(frame.args[1],
	pairs2Array(ipairsAtOffset(frame.args, 1)),		pairs2Array(ipairsAtOffset(frame.args, 1)),
	frame['return']		frame.args['return']
	)		)
	end		end

Ans: +frame.return

2020-10-11T12:41:09Z

+frame.return

← Previous revision		Revision as of 12:41, 11 October 2020
Line 81:		Line 81:
	end		end

	function call(s, args, ret)		local function call(s, args, ret)
	if ret then		if ret then
	return ({get(s)(unpack(args))})[ret]		return ({get(s)(unpack(args))})[ret]
Line 113:		Line 113:
	--]]		--]]
	function p.call(frame)		function p.call(frame)
		⚫	return call(frame.args[1],
⚫	-- enclosing result in (), so that it will return only 1st element of result
		⚫	pairs2ArrayWithFunc(tonumberOrString, ipairsAtOffset(frame.args, 1)),
⚫	return ~~(get~~(frame.args[1])(
			frame['return']
⚫	~~unpack(~~pairs2ArrayWithFunc(tonumberOrString, ipairsAtOffset(frame.args, 1)))
	))		)
	end		end

Line 127:		Line 127:
	--]]		--]]
	function p.call_n(frame)		function p.call_n(frame)
	return ~~(get~~(frame.args[1])(		return call(frame.args[1],
	~~unpack(~~pairs2ArrayWithFunc(tonumber, ipairsAtOffset(frame.args, 1)))		pairs2ArrayWithFunc(tonumber, ipairsAtOffset(frame.args, 1)),
			frame['return']
	))		)
	end		end

Line 141:		Line 142:
	function p.call_s(frame)		function p.call_s(frame)
	-- unpack() not work on metatable		-- unpack() not work on metatable
		⚫	-- enclosing result in (), so that it will return only 1st element of result
	--return (get(frame.args[1])(unpack(frame.args, 2)))		--return (get(frame.args[1])(unpack(frame.args, 2)))
	return ~~(get~~(frame.args[1])(		return call(frame.args[1],
	~~unpack(~~pairs2Array(ipairsAtOffset(frame.args, 1)))		pairs2Array(ipairsAtOffset(frame.args, 1)),
			frame['return']
	))		)
	end		end