Module:Namespace detect/data - Revision history

MusikAnimal: 1 revision imported

2020-04-01T06:12:45Z

1 revision imported

← Previous revision	Revision as of 06:12, 1 April 2020
(No difference)

w>MusikAnimal: Protected "Module:Namespace detect/data": High-risk Lua module ([Edit=Allow only autoconfirmed users] (indefinite) [Move=Allow only autoconfirmed users] (indefinite))

2019-02-14T01:37:00Z

Protected "Module:Namespace detect/data": High-risk Lua module ([Edit=Allow only autoconfirmed users] (indefinite) [Move=Allow only autoconfirmed users] (indefinite))

← Previous revision	Revision as of 01:37, 14 February 2019
(No difference)

Mr. Stradivarius: bug fix - use the demospace parameter as both key and value in the argKeys table

2014-04-05T17:02:16Z

bug fix - use the demospace parameter as both key and value in the argKeys table

← Previous revision		Revision as of 17:02, 5 April 2014
Line 18:		Line 18:
	-- values can be added as a string, or as an array of strings.		-- values can be added as a string, or as an array of strings.

	local ~~argKeys~~ = {		local defaultKeys = {
	~~main = {~~'main'},		'main',
	~~talk = {~~'talk'},		'talk',
	~~other = {~~'other'},		'other',
	~~subjectns = {~~'subjectns'},		'subjectns',
	~~demospace = {~~'demospace'},		'demospace',
	~~page = {~~'demopage'}		'demopage'
	}		}

			local argKeys = {}
			for i, defaultKey in ipairs(defaultKeys) do
			argKeys[defaultKey] = {defaultKey}
			end

	for defaultKey, t in pairs(argKeys) do		for defaultKey, t in pairs(argKeys) do

Mr. Stradivarius: use "demopage" instead of "page" as the default page parameter - needed to fix bug on en.wikisource where "Page" is a namespace name

2014-04-05T05:40:57Z

use "demopage" instead of "page" as the default page parameter - needed to fix bug on en.wikisource where "Page" is a namespace name

← Previous revision		Revision as of 05:40, 5 April 2014
Line 24:		Line 24:
	subjectns = {'subjectns'},		subjectns = {'subjectns'},
	demospace = {'demospace'},		demospace = {'demospace'},
	page = {'~~page~~'}		page = {'demopage'}
	}		}

Mr. Stradivarius: Protected Module:Namespace detect/data: High-risk Lua module ([Edit=Allow only administrators] (indefinite) [Move=Allow only administrators] (indefinite))

2014-03-24T11:45:45Z

Protected Module:Namespace detect/data: High-risk Lua module ([Edit=Allow only administrators] (indefinite) [Move=Allow only administrators] (indefinite))

← Previous revision	Revision as of 11:45, 24 March 2014
(No difference)

Mr. Stradivarius: found it - mappings[nsname] was getting an upper-case key

2014-03-24T11:43:58Z

found it - mappings[nsname] was getting an upper-case key

← Previous revision		Revision as of 11:43, 24 March 2014
Line 52:		Line 52:
	-- }		-- }
	--]]		--]]
	local ustringLower = mw.ustring.lower
	local tinsert = table.insert
	local clone = mw.clone
⚫	~~local~~ ~~subjectNamespaces~~ = mw.site.subjectNamespaces
	local mappings = {}		local mappings = {}
	~~mappings[ustringLower(~~subjectNamespaces[0].name~~)] = clone(argKeys.main)~~		local mainNsName = mw.site.subjectNamespaces[0].name
			mainNsName = mw.ustring.lower(mainNsName)
⚫	mappings['talk'] = clone(argKeys.talk)
			mappings[mainNsName] = mw.clone(argKeys.main)
	for nsid, ns in pairs(subjectNamespaces) do
		⚫	mappings['talk'] = mw.clone(argKeys.talk)
		⚫	for nsid, ns in pairs(mw.site.subjectNamespaces) do
	if nsid ~= 0 then -- Exclude main namespace.		if nsid ~= 0 then -- Exclude main namespace.
	local nsname = ~~ustringLower~~(ns.name)		local nsname = mw.ustring.lower(ns.name)
	local canonicalName = ~~ustringLower~~(ns.canonicalName)		local canonicalName = mw.ustring.lower(ns.canonicalName)
	mappings[nsname] = {nsname}		mappings[nsname] = {nsname}
	if canonicalName ~= nsname then		if canonicalName ~= nsname then
	~~tinsert~~(mappings[nsname], canonicalName)		table.insert(mappings[nsname], canonicalName)
	end		end
	for _, alias in ipairs(ns.aliases) do		for _, alias in ipairs(ns.aliases) do
	~~tinsert~~(mappings[nsname], ~~ustringLower~~(alias))		table.insert(mappings[nsname], mw.ustring.lower(alias))
	end		end
	end		end

Mr. Stradivarius: Undid revision 601018314 by Mr. Stradivarius (talk) looks like that broke something

2014-03-24T11:37:34Z

Undid revision 601018314 by Mr. Stradivarius (talk) looks like that broke something

← Previous revision		Revision as of 11:37, 24 March 2014
Line 52:		Line 52:
	-- }		-- }
	--]]		--]]
			local ustringLower = mw.ustring.lower
			local tinsert = table.insert
			local clone = mw.clone
		⚫	local subjectNamespaces = mw.site.subjectNamespaces
	local mappings = {}		local mappings = {}
	~~local mainNsName = mw.site.~~subjectNamespaces[0].name		mappings[ustringLower(subjectNamespaces[0].name)] = clone(argKeys.main)
		⚫	mappings['talk'] = clone(argKeys.talk)
	mainNsName = mw.ustring.lower(mainNsName)
			for nsid, ns in pairs(subjectNamespaces) do
	mappings[mainNsName] = mw.clone(argKeys.main)
⚫	mappings['talk'] = ~~mw.~~clone(argKeys.talk)
⚫	~~for~~ ~~nsid,~~ ns ~~in pairs(~~mw.site.subjectNamespaces~~) do~~
	if nsid ~= 0 then -- Exclude main namespace.		if nsid ~= 0 then -- Exclude main namespace.
	local nsname = ns.name		local nsname = ustringLower(ns.name)
	local canonicalName = ns.canonicalName		local canonicalName = ustringLower(ns.canonicalName)
	mappings[nsname] = {~~mw.ustring.lower(~~nsname)}		mappings[nsname] = {nsname}
	if canonicalName ~= nsname then		if canonicalName ~= nsname then
	~~table.insert~~(mappings[nsname], ~~mw.ustring.lower(~~canonicalName))		tinsert(mappings[nsname], canonicalName)
	end		end
	for _, alias in ipairs(ns.aliases) do		for _, alias in ipairs(ns.aliases) do
	~~table.insert~~(mappings[nsname], ~~mw.ustring.lower~~(alias))		tinsert(mappings[nsname], ustringLower(alias))
	end		end
	end		end

Mr. Stradivarius: avoid using local variables to save table lookups per Jackmcbarn's suggestion, and because this will be cached with mw.loadData so performance of this function is not such a worry

2014-03-24T11:36:17Z

avoid using local variables to save table lookups per Jackmcbarn's suggestion, and because this will be cached with mw.loadData so performance of this function is not such a worry

← Previous revision		Revision as of 11:36, 24 March 2014
Line 52:		Line 52:
	-- }		-- }
	--]]		--]]
	local ustringLower = mw.ustring.lower
	local tinsert = table.insert
	local clone = mw.clone
⚫	~~local~~ ~~subjectNamespaces~~ = mw.site.subjectNamespaces
	local mappings = {}		local mappings = {}
	~~mappings[ustringLower(~~subjectNamespaces[0].name~~)] = clone(argKeys.main)~~		local mainNsName = mw.site.subjectNamespaces[0].name
			mainNsName = mw.ustring.lower(mainNsName)
⚫	mappings['talk'] = clone(argKeys.talk)
			mappings[mainNsName] = mw.clone(argKeys.main)
	for nsid, ns in pairs(subjectNamespaces) do
		⚫	mappings['talk'] = mw.clone(argKeys.talk)
		⚫	for nsid, ns in pairs(mw.site.subjectNamespaces) do
	if nsid ~= 0 then -- Exclude main namespace.		if nsid ~= 0 then -- Exclude main namespace.
	local nsname = ~~ustringLower(~~ns.name)		local nsname = ns.name
	local canonicalName = ~~ustringLower(~~ns.canonicalName)		local canonicalName = ns.canonicalName
	mappings[nsname] = {nsname}		mappings[nsname] = {mw.ustring.lower(nsname)}
	if canonicalName ~= nsname then		if canonicalName ~= nsname then
	~~tinsert~~(mappings[nsname], canonicalName)		table.insert(mappings[nsname], mw.ustring.lower(canonicalName))
	end		end
	for _, alias in ipairs(ns.aliases) do		for _, alias in ipairs(ns.aliases) do
	~~tinsert~~(mappings[nsname], ~~ustringLower~~(alias))		table.insert(mappings[nsname], mw.ustring.lower(alias))
	end		end
	end		end

Mr. Stradivarius: give the argKeys table global scope so that getParamMappings can access it without having to process the cfg table again

2014-03-22T07:03:48Z

give the argKeys table global scope so that getParamMappings can access it without having to process the cfg table again

← Previous revision		Revision as of 07:03, 22 March 2014
Line 13:		Line 13:
	end		end

		⚫	-- Get a table of parameters to query for each default parameter name.
	local function getArgKeys()
			-- This allows wikis to customise parameter names in the cfg table while
⚫	-- ~~Returns~~ a table of parameters to query for each default parameter name.
	-- ~~This~~ ~~allows~~ ~~wikis to customise~~ parameter names in ~~the~~ cfg table ~~while~~		-- ensuring that default parameter names will always work. The cfg table
		⚫	-- values can be added as a string, or as an array of strings.
	-- ensuring that default parameter names will always work. The cfg table

⚫	-- values can be added as a string, or as an array of strings.
	local argKeys = {		local argKeys = {
	main = {'main'},		main = {'main'},
	talk = {'talk'},		talk = {'talk'},
	other = {'other'},		other = {'other'},
	subjectns = {'subjectns'},		subjectns = {'subjectns'},
	demospace = {'demospace'},		demospace = {'demospace'},
	page = {'page'}		page = {'page'}
	}		}

	for defaultKey, t in pairs(argKeys) do		for defaultKey, t in pairs(argKeys) do
⚫	~~local~~ cfgValue ~~= cfg[~~defaultKey]
	local ~~cfgValueType~~ = ~~type(cfgValue)~~		local cfgValue = cfg[defaultKey]
	if cfgValueType =~~= 'string'~~ ~~then~~		local cfgValueType = type(cfgValue)
		⚫	if cfgValueType == 'string' then
⚫	addKey(t, ~~cfgValue~~, defaultKey)
		⚫	addKey(t, cfgValue, defaultKey)
⚫	~~elseif~~ cfgValueType == '~~table~~' then
			elseif cfgValueType == 'table' then
	for i, key in ipairs(cfgValue) do
	~~addKey(t~~, key, ~~defaultKey~~)		for i, key in ipairs(cfgValue) do
		⚫	addKey(t, key, defaultKey)
	end
	end		end
⚫	cfg[defaultKey] = nil -- Free the cfg value as we don't need it any more.
	end		end
		⚫	cfg[defaultKey] = nil -- Free the cfg value as we don't need it any more.
	return argKeys
	end		end

Line 55:		Line 54:
	local ustringLower = mw.ustring.lower		local ustringLower = mw.ustring.lower
	local tinsert = table.insert		local tinsert = table.insert
		⚫	local clone = mw.clone
	local subjectNamespaces = mw.site.subjectNamespaces		local subjectNamespaces = mw.site.subjectNamespaces
⚫	local ~~talk~~ = ~~cfg~~.~~talk~~
	local mappings = {}		local mappings = {}
	mappings[ustringLower(subjectNamespaces[0].name)] = ~~{cfg~~.main}		mappings[ustringLower(subjectNamespaces[0].name)] = clone(argKeys.main)
	mappings[talk] = {talk}		mappings['talk'] = clone(argKeys.talk)
	for nsid, ns in pairs(subjectNamespaces) do		for nsid, ns in pairs(subjectNamespaces) do
	if nsid ~= 0 then -- Exclude main namespace.		if nsid ~= 0 then -- Exclude main namespace.
Line 77:		Line 76:

	return {		return {
	argKeys = ~~getArgKeys()~~,		argKeys = argKeys,
	cfg = cfg,		cfg = cfg,
	mappings = getParamMappings()		mappings = getParamMappings()

Mr. Stradivarius: add a getArgKeys function, so that we can have multiple keys for each argument (helpful for localisation) and so that we only have to create that table once per page

2014-03-22T06:41:09Z

add a getArgKeys function, so that we can have multiple keys for each argument (helpful for localisation) and so that we only have to create that table once per page

@@ Line 6: / Line 6: @@
 local cfg = require('Module:Namespace detect/config')
 local function getParamMappings()
@@ Line 42: / Line 76: @@
 end
-return {cfg = cfg, mappings = getParamMappings()}
+return {