Module:Portal navigation - Revision history

Hike395: rename fcn

2023-01-07T18:49:14Z

rename fcn

← Previous revision		Revision as of 18:49, 7 January 2023
Line 59:		Line 59:
	end		end

	local function ~~generate_tag~~(body, index, args)		local function generate_tab(body, index, args)
	local container = body:tag('li')		local container = body:tag('li')
	container:css('display','inline-block')		container:css('display','inline-block')
Line 176:		Line 176:

	for _, index in ipairs(tabindex) do		for _, index in ipairs(tabindex) do
	~~generate_tag~~(body, index, args)		generate_tab(body, index, args)
	end		end
	end		end

2023-01-07T18:01:13Z

rm stub

← Previous revision		Revision as of 18:01, 7 January 2023
Line 3:		Line 3:
	local getArgs = require('Module:Arguments').getArgs		local getArgs = require('Module:Arguments').getArgs
	local yesno = require("Module:Yesno")		local yesno = require("Module:Yesno")

	local function get_portalicon(portalicon, root)

	return root
	end

	local function converttolinearrgb(c)		local function converttolinearrgb(c)

2023-01-07T17:58:56Z

factor out HTML generation code into functions

2023-01-07T15:01:45Z

move comment

← Previous revision		Revision as of 15:01, 7 January 2023
Line 131:		Line 131:
	container:css('vertical-align','top')		container:css('vertical-align','top')
	container:css('margin','0')		container:css('margin','0')
		⚫
		⚫	-- Create the tab itself

	local entry = container:tag('span')		local entry = container:tag('span')
	entry:css('display','inline-block')		entry:css('display','inline-block')
Line 136:		Line 139:
	entry:css('padding-bottom','0.5em')		entry:css('padding-bottom','0.5em')
	entry:css('font-weight','bold')		entry:css('font-weight','bold')

⚫	-- Create the tab itself
⚫
	if index == args.active then		if index == args.active then
	if not subtabs[index] or args.hidesubnav then		if not subtabs[index] or args.hidesubnav then

2023-01-07T14:54:12Z

← Previous revision		Revision as of 14:54, 7 January 2023
Line 163:		Line 163:
	subnav:css('margin','0 1em')		subnav:css('margin','0 1em')
	subnav:css('padding','1.125em 0')		subnav:css('padding','1.125em 0')
	local borderColor = '0.35em solid'..args.themecolor		local borderColor = '0.35em solid '..args.themecolor
	subnav:css('border-top',borderColor)		subnav:css('border-top',borderColor)
	subnav:css('border-bottom',borderColor)		subnav:css('border-bottom',borderColor)

2023-01-07T13:56:14Z

use ul/li for body, factor out function

@@ Line 25: / Line 25: @@
 	return c
 end
@@ Line 63: / Line 86: @@
 	-- Relevant variables: portalname, wrc, themecolor, headerstyle
 	local root = mw.html.create('div')
 	if args.wrc then
@@ Line 102: / Line 104: @@
 	header:css('padding','0.25em')
 	header:css('background',args.themecolor)
-	header:css('color',luminance > 0.179 and '#000' or '#fff')
+	header:css('color',luminance(args.themecolor) > 0.1791 and '#000' or '#fff')
 	header:cssText(args.headerstyle)
 	header:wikitext(args.portalname)
@@ Line 112: / Line 114: @@
 	if not args.hidenav then
-		local body = root:tag('div')
+		local body = root:tag('ul')
 		body:css('font-size','1.125em')
-		body:css('margin-bottom','1.125em')
+		body:css('list-style','none')
 		local tabindex = {}
@@ Line 123: / Line 126: @@
 		for _, index in ipairs(tabindex) do
-			local container = body:tag('div')
+			local container = body:tag('li')
 			container:css('display','inline-block')
 			container:css('position','relative')
 			container:css('vertical-align','top')
 			local entry = container:tag('span')
 			entry:css('display','inline-block')

2023-01-07T13:14:50Z

fix global

← Previous revision		Revision as of 13:14, 7 January 2023
Line 86:		Line 86:
	local root = mw.html.create('div')		local root = mw.html.create('div')
	if args.wrc then		if args.wrc then
	badgeargs = {}		local badgeargs = {}
	if wrcadditional then		if wrcadditional then
	badgeargs['additional'] = args.wrcadditional		badgeargs['additional'] = args.wrcadditional

2023-01-07T13:09:31Z

cleanup argument handling

2023-01-07T06:12:44Z

cleanup wrc code

← Previous revision		Revision as of 06:12, 7 January 2023
Line 31:		Line 31:
	local tabs = {}		local tabs = {}
	local subtabs = {}		local subtabs = {}
	local wrc = 0		local wrc = nil

	-- Default values (customizations)		-- Default values (customizations)
Line 53:		Line 53:
	active = tonumber(value)		active = tonumber(value)
	elseif key == 'wrc' then		elseif key == 'wrc' then
	wrc = value		wrc = yesno(value)
	elseif key == 'themecolor' then		elseif key == 'themecolor' then
	themecolor = value		themecolor = value
Line 111:		Line 111:

	local root = mw.html.create('div')		local root = mw.html.create('div')
			if wrc then
	if wrc == '1' or wrc == 1 or wrc == 'true' or wrc == true or wrc == 'yes' then
	badgeargs = {}		badgeargs = {}
	if wrcadditional ~~~= nil~~ then		if wrcadditional then
	badgeargs['additional'] = wrcadditional		badgeargs['additional'] = wrcadditional
	end		end

2023-01-07T06:04:17Z

cleanup if