Module:Redirect hatnote/sandbox - Revision history

Nihiltres: Migrated p._quote to Module:Hatnote

2022-09-05T18:20:21Z

Migrated p._quote to Module:Hatnote

@@ Line 22: / Line 22: @@
 	local success, titleObj = pcall(mw.title.new, ...)
 	return success and titleObj or nil
 end
@@ Line 81: / Line 64: @@
 	local formattedRedirect = {}
 	for k,v in pairs(redirect) do
-		formattedRedirect[k] = p._quote(v)
+		formattedRedirect[k] = mHatnote.quote(v)
 	end
 	local text = {

2022-09-05T18:07:50Z

Condensed a few lines in getTitle, and wrote a comment documentation line

← Previous revision		Revision as of 18:07, 5 September 2022
Line 19:		Line 19:

	local function getTitle(...)		local function getTitle(...)
			--Calls mw.title.new and returns either a title object, or nil on error
	local success, titleObj = pcall(mw.title.new, ...)		local success, titleObj = pcall(mw.title.new, ...)
	if success ~~then~~		return success and titleObj or nil
	return titleObj
	else
	return nil
	end
	end		end

2022-08-12T19:02:53Z

Rewrote p._quote to use mw.html and divided functions into helper functions and main functions

@@ Line 13: / Line 13: @@
 local p = {}
 local function getTitle(...)
@@ Line 22: / Line 26: @@
 	end
 end
 function p.redirect(frame)
@@ Line 119: / Line 144: @@
 	return mHatnote._hatnote(text, mhOptions) .. category
 end

2022-08-12T18:31:41Z

← Previous revision		Revision as of 18:31, 12 August 2022
Line 124:		Line 124:
	local quotationMarks = {["'"]=true, ['"']=true, ['“']=true, ["‘"]=true, ['”']=true, ["’"]=true}		local quotationMarks = {["'"]=true, ['"']=true, ['“']=true, ["‘"]=true, ['”']=true, ["’"]=true}
	local style = ""		local style = ""
			-- If string starts with anything in quotationMarks, kern to same degree {{-'}} does
	mw.log("starts with... " .. string.sub(title, 1, 1))
	if quotationMarks[string.sub(title, 1, 1)] then		if quotationMarks[string.sub(title, 1, 1)] then
	style = "padding-left:0.15em;"		style = "padding-left:0.15em;"
	end		end
			-- Likewise if it ends with any of them
	if quotationMarks[string.sub(title, -1, -1)] then		if quotationMarks[string.sub(title, -1, -1)] then
	style = style .. "padding-right:0.15em;"		style = style .. "padding-right:0.15em;"

2022-05-09T09:24:10Z

fix

← Previous revision		Revision as of 09:24, 9 May 2022
Line 131:		Line 131:
	style = style .. "padding-right:0.15em;"		style = style .. "padding-right:0.15em;"
	end		end
	return '"<span style="' .. style .. '">' .. title .. '</span>"' ~~and style~~ or '"' .. title .. '"'		return style ~= "" and '"<span style="' .. style .. '">' .. title .. '</span>"' or '"' .. title .. '"'
	end		end

2022-05-09T09:19:34Z

meh

← Previous revision		Revision as of 09:19, 9 May 2022
Line 131:		Line 131:
	style = style .. "padding-right:0.15em;"		style = style .. "padding-right:0.15em;"
	end		end
	return '"<span style="' .. style .. '">' .. title .. '</span>"'		return '"<span style="' .. style .. '">' .. title .. '</span>"' and style or '"' .. title .. '"'
	end		end

2022-05-09T08:38:19Z

kern quotation marks

← Previous revision		Revision as of 08:38, 9 May 2022
Line 59:		Line 59:
	local formattedRedirect = {}		local formattedRedirect = {}
	for k,v in pairs(redirect) do		for k,v in pairs(redirect) do
	formattedRedirect[k] = ~~'"'~~ .. v ~~.. '"'~~		formattedRedirect[k] = p._quote(v)
	end		end
	local text = {		local text = {
Line 119:		Line 119:

	return mHatnote._hatnote(text, mhOptions) .. category		return mHatnote._hatnote(text, mhOptions) .. category
			end

			function p._quote(title)
			local quotationMarks = {["'"]=true, ['"']=true, ['“']=true, ["‘"]=true, ['”']=true, ["’"]=true}
			local style = ""
			mw.log("starts with... " .. string.sub(title, 1, 1))
			if quotationMarks[string.sub(title, 1, 1)] then
			style = "padding-left:0.15em;"
			end
			if quotationMarks[string.sub(title, -1, -1)] then
			style = style .. "padding-right:0.15em;"
			end
			return '"<span style="' .. style .. '">' .. title .. '</span>"'
	end		end

2021-04-14T18:23:02Z

Colon, not dot…

← Previous revision		Revision as of 18:23, 14 April 2021
Line 87:		Line 87:
	addCategory('Missing redirects')		addCategory('Missing redirects')
	elseif not redirTitle.isRedirect then		elseif not redirTitle.isRedirect then
	if string.find(redirTitle.getContent(), '#invoke:RfD') then		if string.find(redirTitle:getContent(), '#invoke:RfD') then
	addCategory('Articles with redirect hatnotes impacted by RfD')		addCategory('Articles with redirect hatnotes impacted by RfD')
	else		else

2021-04-14T18:21:21Z

Prototyped some improvements: separate categorization for RfD'd redirects, using title.redirectTarget instead of Module:Redirect

← Previous revision		Revision as of 18:21, 14 April 2021
Line 87:		Line 87:
	addCategory('Missing redirects')		addCategory('Missing redirects')
	elseif not redirTitle.isRedirect then		elseif not redirTitle.isRedirect then
			if string.find(redirTitle.getContent(), '#invoke:RfD') then
⚫	addCategory('Articles with redirect hatnotes needing review')
			addCategory('Articles with redirect hatnotes impacted by RfD')
			else
		⚫	addCategory('Articles with redirect hatnotes needing review')
			end
	else		else
	local ~~mRedirect~~ = ~~require('Module:Redirect')~~		local target = targetTitle or redirTitle.redirectTarget
	local target = mRedirect.getTarget(redirTitle)
	target = targetTitle or target and getTitle(target)
	if target and target ~= currentTitle then		if target and target ~= currentTitle then
	addCategory('Articles with redirect hatnotes needing review')		addCategory('Articles with redirect hatnotes needing review')

2021-03-26T02:19:57Z

Declare variable earlier to fix scope error

← Previous revision		Revision as of 02:19, 26 March 2021
Line 76:		Line 76:
	--Generate tracking categories		--Generate tracking categories
	local mhOptions = {}		local mhOptions = {}
			local redirTitle
	for k,v in pairs(redirect) do		for k,v in pairs(redirect) do
	-- We don't need a tracking category if the template invocation has been		-- We don't need a tracking category if the template invocation has been
Line 82:		Line 83:
	and currentTitle.namespace == 0 or currentTitle.namespace == 14		and currentTitle.namespace == 0 or currentTitle.namespace == 14
	then		then
	~~local~~ redirTitle = redirectTitle or getTitle(v)		redirTitle = redirectTitle or getTitle(v)
	if not redirTitle or not redirTitle.exists then		if not redirTitle or not redirTitle.exists then
	addCategory('Missing redirects')		addCategory('Missing redirects')