Module:Reply to/sandbox - Revision history

Ahecht: rearrange

2022-04-06T02:23:55Z

rearrange

← Previous revision		Revision as of 02:23, 6 April 2022
Line 11:		Line 11:

	function p.replyto(frame)		function p.replyto(frame)
		⚫	local outArray, argIndex = {}, {}
	local args = frame:getParent().args		local args = frame:getParent().args
⚫	local outArray = {}
	args.label1 = args.label1 or args.label		args.label1 = args.label1 or args.label

	local argIndex = {}
	for k, v in pairs(args) do		for k, v in pairs(args) do
	if type(k) == 'number' and string.match(v,'%S') then		if type(k) == 'number' and string.match(v,'%S') then

Ahecht: simplify

2022-04-06T02:21:34Z

simplify

← Previous revision		Revision as of 02:21, 6 April 2022
Line 16:		Line 16:

	local argIndex = {}		local argIndex = {}
	for k, _ in pairs(args) do		for k, v in pairs(args) do
	if type(k) == 'number' then		if type(k) == 'number' and string.match(v,'%S') then
	table.insert(argIndex, k)		table.insert(argIndex, k)
	end		end
Line 23:		Line 23:
	table.sort(argIndex)		table.sort(argIndex)
	for _, k in ipairs(argIndex) do		for _, k in ipairs(argIndex) do
	if ~~string~~.~~match~~(args[k]~~,'%S'~~) ~~then~~		local title = mw.title.new(args[k])
		⚫	if not title then return makeError('Input contains forbidden characters.') end
	~~local~~ title = ~~mw.~~title.~~new(args[k])~~		title = title.rootText
⚫	if not title then return makeError('Input contains forbidden characters.') end
			local label = args['label'..tostring(k)]
	title = title.rootText
	~~local~~ label = ~~args[~~'label'~~..tostring(k)]~~		if label == '' then label = '' end
		⚫	table.insert( outArray, makeLink(title, label) )
	if label == '' then label = '' end
⚫	table.insert( outArray, makeLink(title, label) )
	end
	end		end

Ahecht: restore ability to skip nil, fix example handling

2022-04-06T02:16:42Z

restore ability to skip nil, fix example handling

← Previous revision		Revision as of 02:16, 6 April 2022
Line 4:		Line 4:
	msg ='Error in [[Template:Reply to]]: ' .. msg		msg ='Error in [[Template:Reply to]]: ' .. msg
	return mw.text.tag('strong', {['class']='error'}, msg)		return mw.text.tag('strong', {['class']='error'}, msg)
		⚫	end

			local function makeLink(u, l)
		⚫	return '[[User:' .. u .. '\|' .. (l or u) .. ']]'
	end		end

	function p.replyto(frame)		function p.replyto(frame)
	local args = frame:getParent().args		local args = frame:getParent().args
	local outArray~~, outStr~~ = {}~~, ""~~		local outArray = {}
	args.label1 = args.label1 or args.label		args.label1 = args.label1 or args.label

			local argIndex = {}
	for i, v in ~~ipairs~~(args) do		for k, _ in pairs(args) do
⚫	if string.match(v,'%S') then
		⚫	if type(k) == 'number' then
⚫	local title = mw.title.new(v)
			table.insert(argIndex, k)
		⚫	end
			end
			table.sort(argIndex)
			for _, k in ipairs(argIndex) do
		⚫	if string.match(args[k],'%S') then
		⚫	local title = mw.title.new(args[k])
	if not title then return makeError('Input contains forbidden characters.') end		if not title then return makeError('Input contains forbidden characters.') end
	title = title.rootText		title = title.rootText
	local label = args['label'..tostring(i)]		local label = args['label'..tostring(k)]
	if label == '' then		if label == '' then label = '' end
			table.insert( outArray, makeLink(title, label) )
	label = ''
⚫	end
⚫	~~table.insert(outArray,~~ '[[User:' .. ~~title~~ .. '\|' .. (~~label~~ or ~~title~~) .. ']]')
	end		end
	end		end
Line 28:		Line 37:
	end		end
	if #outArray < 1 then		if #outArray < 1 then
	if frame.args.example then ~~args~~[1] = frame.args.example else return makeError('Username not given.') end		if frame.args.example then
			outArray[1] = makeLink(frame.args.example)
			else
			return makeError('Username not given.')
			end
⚫	end
⚫	if ~~args.c~~ == '' then
	outStr = table.concat(outArray, ", ")
	else
⚫	~~outStr~~ = ~~mw.text.listToText(outArray, ', ',~~ (#outArray == 2 and ' ' or ', ') .. (args.c or 'and') .. ' ')
	end		end

		⚫	local conjuction = (#outArray == 2 and ' ' or ', ') .. (args.c or 'and') .. ' '
			local outStr = (args.c == '') and table.concat(outArray, ', ') or mw.text.listToText(outArray, ', ', conjuction)

	return mw.text.tag('span', {['class']='template-ping'}, (args.prefix or '@') .. outStr .. (args.p or ':'))		return mw.text.tag('span', {['class']='template-ping'}, (args.prefix or '@') .. outStr .. (args.p or ':'))
	end		end

Johnuniq: experimental edit to discuss at Template talk:Reply to#Rewrite; revert when done

2022-04-01T02:05:35Z

experimental edit to discuss at Template talk:Reply to#Rewrite; revert when done

← Previous revision		Revision as of 02:05, 1 April 2022
Line 10:		Line 10:
	local outArray, outStr = {}, ""		local outArray, outStr = {}, ""
	args.label1 = args.label1 or args.label		args.label1 = args.label1 or args.label

	local argIndex = {}
	for k, _ in ~~pairs~~(args) do		for i, v in ipairs(args) do
	if ~~type~~(~~k) ==~~ '~~number~~' then		if string.match(v,'%S') then
		⚫	local title = mw.title.new(v)
	table.insert(argIndex, k)
⚫	end
⚫	end
	table.sort(argIndex)
	for _, k in ipairs(argIndex) do
	if string.match(args[k],'%S') then
⚫	local title = mw.title.new(~~args[k]~~)
	if not title then return makeError('Input contains forbidden characters.') end		if not title then return makeError('Input contains forbidden characters.') end
	title = title.rootText		title = title.rootText
	local label = args['label'..tostring(k)]		local label = args['label'..tostring(i)]
	if label == '' then		if label == '' then
	label = ''		label = ''
	end		end
Line 32:		Line 26:
	if #outArray > (tonumber(frame.args.max) or 50) then		if #outArray > (tonumber(frame.args.max) or 50) then
	return makeError('More than ' .. tostring(frame.args.max or 50) .. ' names specified.')		return makeError('More than ' .. tostring(frame.args.max or 50) .. ' names specified.')
		⚫	end
		⚫	if #outArray < 1 then
		⚫	if frame.args.example then args[1] = frame.args.example else return makeError('Username not given.') end
		⚫	end
		⚫	if args.c == '' then
		⚫	outStr = table.concat(outArray, ", ")
	else		else
		⚫	outStr = mw.text.listToText(outArray, ', ', (#outArray == 2 and ' ' or ', ') .. (args.c or 'and') .. ' ')
⚫	if #outArray < 1 then
⚫	if frame.args.example then args[1] = frame.args.example else return makeError('Username not given.') end
	end
⚫	if args.c == '' then
⚫	outStr = table.concat(outArray, ", ")
	else
⚫	outStr = mw.text.listToText(outArray, ', ', (#outArray == 2 and ' ' or ', ') .. (args.c or 'and') .. ' ')
	end
⚫	return mw.text.tag('span', {['class']='template-ping'}, (args.prefix or '@') .. outStr .. (args.p or ':'))
	end		end
		⚫	return mw.text.tag('span', {['class']='template-ping'}, (args.prefix or '@') .. outStr .. (args.p or ':'))
	end		end

Ahecht: remove unneeded check

2022-03-31T14:53:37Z

remove unneeded check

← Previous revision		Revision as of 14:53, 31 March 2022
Line 18:		Line 18:
	table.sort(argIndex)		table.sort(argIndex)
	for _, k in ipairs(argIndex) do		for _, k in ipairs(argIndex) do
	if ~~args[k] and~~ string.match(args[k],'%S') then		if string.match(args[k],'%S') then
	local title = mw.title.new(args[k])		local title = mw.title.new(args[k])
	if not title then return makeError('Input contains forbidden characters.') end		if not title then return makeError('Input contains forbidden characters.') end

Ahecht: debug

2022-03-31T14:50:57Z

debug

← Previous revision		Revision as of 14:50, 31 March 2022
Line 17:		Line 17:
	end		end
	table.sort(argIndex)		table.sort(argIndex)
	for _, v in ipairs(argIndex) do		for _, k in ipairs(argIndex) do
	local k = argIndex[v]
	if args[k] and string.match(args[k],'%S') then		if args[k] and string.match(args[k],'%S') then
	local title = mw.title.new(args[k])		local title = mw.title.new(args[k])

Ahecht: sort

2022-03-31T14:47:19Z

sort

← Previous revision		Revision as of 14:47, 31 March 2022
Line 16:		Line 16:
	end		end
	end		end
			table.sort(argIndex)
	for _, v in ipairs(argIndex) do		for _, v in ipairs(argIndex) do
	local k = argIndex[v]		local k = argIndex[v]

Ahecht: try more efficient search

2022-03-31T14:40:33Z

try more efficient search

← Previous revision		Revision as of 14:40, 31 March 2022
Line 10:		Line 10:
	local outArray, outStr = {}, ""		local outArray, outStr = {}, ""
	args.label1 = args.label1 or args.label		args.label1 = args.label1 or args.label
	local ~~maxArg~~ = 0		local argIndex = {}
	for k, _ in pairs(args) do		for k, _ in pairs(args) do
	if type(k) == 'number' ~~and k > maxArg~~ then		if type(k) == 'number' then
			table.insert(argIndex, k)
	maxArg=k
	end		end
	end		end
	for k = 1, ~~maxArg~~ do		for _, v in ipairs(argIndex) do
			local k = argIndex[v]
	if args[k] and string.match(args[k],'%S') then		if args[k] and string.match(args[k],'%S') then
	local title = mw.title.new(args[k])		local title = mw.title.new(args[k])

Ahecht: use string.match

2022-03-31T14:07:58Z

use string.match

← Previous revision		Revision as of 14:07, 31 March 2022
Line 17:		Line 17:
	end		end
	for k = 1, maxArg do		for k = 1, maxArg do
	if args[k] and ~~mw.ustring~~.match(args[k],'%S') then		if args[k] and string.match(args[k],'%S') then
	local title = mw.title.new(args[k])		local title = mw.title.new(args[k])
	if not title then return makeError('Input contains forbidden characters.') end		if not title then return makeError('Input contains forbidden characters.') end

Ahecht: improve speed

2022-03-31T14:06:10Z

improve speed

← Previous revision		Revision as of 14:06, 31 March 2022
Line 17:		Line 17:
	end		end
	for k = 1, maxArg do		for k = 1, maxArg do
	if mw.ustring.match(args[k] ~~or ''~~,'%S') then		if args[k] and mw.ustring.match(args[k],'%S') then
	local title = mw.title.new(args[k])		local title = mw.title.new(args[k])
	if not title then return makeError('Input contains forbidden characters.') end		if not title then return makeError('Input contains forbidden characters.') end