Module:Requested move - Revision history

DannyS712: simplify some code (should be a no-op; if there are any errors no discussion is needed before reverting (WP:TPEDISPUTE))

2024-03-19T23:51:08Z

simplify some code (should be a no-op; if there are any errors no discussion is needed before reverting (WP:TPEDISPUTE))

← Previous revision		Revision as of 23:51, 19 March 2024
Line 91:		Line 91:
	if not validTitle then		if not validTitle then
	-- If invalid, the second parameter is the error message.		-- If invalid, the second parameter is the error message.
	~~local msg =~~ currentTitle		return currentTitle
	return msg
	end		end
	return 'yes'		return 'yes'
Line 193:		Line 192:
	-- multiple nomination.		-- multiple nomination.
	local argsByNumCount = #argsByNum		local argsByNumCount = #argsByNum
	local multi		local multi = (argsByNumCount >= 2)

	if argsByNumCount >= 2 then
	multi = true
	else
	multi = false
	end

	--[[		--[[
	-- Validate new params.		-- Validate new params.
Line 514:		Line 508:

	-- Talk blurb		-- Talk blurb
	local talk		local talk = ''
	if yesno(args.talk, true) then		if yesno(args.talk, true) then
	talk = frame:expandTemplate{title = 'Requested move/talk'}		talk = frame:expandTemplate{title = 'Requested move/talk'}
	else
	talk = ''
	end		end

SilverLocust: Instead putting the protection checks after the error checks for the same purpose

2024-03-19T02:46:32Z

Instead putting the protection checks after the error checks for the same purpose

Show changes

SilverLocust: Keep the error message for invalid titles like Wikipedia: (rather than having those cause a nil-index error).

2024-03-19T00:31:29Z

Keep the error message for invalid titles like [[Wikipedia:]] (rather than having those cause a nil-index error).

← Previous revision		Revision as of 00:31, 19 March 2024
Line 235:		Line 235:
	-- Consolidate duplicate titles (i.e., when moving A to B and B to C)		-- Consolidate duplicate titles (i.e., when moving A to B and B to C)
	for i = 1,argsByNumCount do		for i = 1,argsByNumCount do
	titles[mw.title.new(argsByNum[i]['current'])] = true		titles[mw.title.new(argsByNum[i]['current']) or ''] = true
	titles[mw.title.new(argsByNum[i]['new'])] = true		titles[mw.title.new(argsByNum[i]['new']) or ''] = true
	end		end
	-- Check each title t, while ignoring the "true" value		-- Check each title t, while ignoring the "true" value

SilverLocust: Automatically detect the highest protection level (if sysop or templateeditor level) that would prevent a "moved" outcome. Then {{RM/dated}} checks the title is still protected, and shows a green/pink padlock if so.

2024-03-18T23:45:59Z

Automatically detect the highest protection level (if sysop or templateeditor level) that would prevent a "moved" outcome. Then {{RM/dated}} checks the title is still protected, and shows a green/pink padlock if so.

@@ Line 95: / Line 95: @@
 	end
 	return 'yes'
 end
@@ Line 193: / Line 217: @@
 		if not new or new == 'NewName' then
 			argsByNum[1].new = defaultNewPagename
 		end
 	end
@@ Line 377: / Line 446: @@
 	rmd[#rmd + 1] = '|' .. new1param .. argsByNum[1].new
-	-- Add the rest of the arguments for multi.
+	-- Add more arguments for multi.
 	if multi then
 		for i = 2, argsByNumCount do
@@ Line 387: / Line 456: @@
 			rmd[#rmd + 1] = '|new' .. numString .. '=' .. new
 		end
 		rmd[#rmd + 1] = '|'
 	end

Wbm1058: Undid revision 941148733 by MSGJ (talk) per followup discussion at Template talk:Requested move#Hide advice when it was followed

2020-04-20T17:57:13Z

Undid revision 941148733 by MSGJ (talk) per followup discussion at Template talk:Requested move#Hide advice when it was followed

← Previous revision		Revision as of 17:57, 20 April 2020
Line 392:		Line 392:
	end		end

		⚫	rmd[#rmd + 1] = '}}'
	-- hide help of {{Requested move/dated}} when it is transcluded using
	-- {{Requested move}}
⚫	rmd[#rmd + 1] = '~~\|help=off~~}}'
	rmd = table.concat(rmd)		rmd = table.concat(rmd)

MSGJ: add help=off parameter to Template:Requested move/dated

2020-02-16T21:52:18Z

add help=off parameter to Template:Requested move/dated

← Previous revision		Revision as of 21:52, 16 February 2020
Line 392:		Line 392:
	end		end

			-- hide help of {{Requested move/dated}} when it is transcluded using
⚫	rmd[#rmd + 1] = '}}'
			-- {{Requested move}}
		⚫	rmd[#rmd + 1] = '\|help=off}}'
	rmd = table.concat(rmd)		rmd = table.concat(rmd)

JJMC89: Changed protection level for "Module:Requested move": Highly visible module ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

2019-03-17T01:12:54Z

Changed protection level for "Module:Requested move": Highly visible module ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

← Previous revision	Revision as of 01:12, 17 March 2019
(No difference)

Pppery: Syncing fix for templates with redirect talk pages

2018-10-24T01:14:05Z

Syncing fix for templates with redirect talk pages

← Previous revision		Revision as of 01:14, 24 October 2018
Line 5:		Line 5:
	local tableTools = require('Module:TableTools')		local tableTools = require('Module:TableTools')
	local yesno = require('Module:Yesno')		local yesno = require('Module:Yesno')
			local mRedirect = require('Module:Redirect')

	-- Set static values		-- Set static values
Line 14:		Line 15:
	-- Helper functions		-- Helper functions
	--------------------------------------------------------------------------------		--------------------------------------------------------------------------------
		⚫

	local function err(msg, numargs, reason, count)		local function err(msg, numargs, reason, count)
	-- Generates a wikitext error message		-- Generates a wikitext error message
Line 215:		Line 216:
	local msg = '[[Template:Requested move]] must be used in a TALKSPACE, e.g., [[%s:%s]]'		local msg = '[[Template:Requested move]] must be used in a TALKSPACE, e.g., [[%s:%s]]'
	msg = string.format(msg, mw.site.namespaces[title.namespace].talk.name, title.text)		msg = string.format(msg, mw.site.namespaces[title.namespace].talk.name, title.text)
⚫	return err(msg, argsByNum, args.reason, argsByNumCount)
⚫	end
⚫
⚫	-- Request to move a single page must be placed on that page's talk
⚫	if not multi and args.current1 ~= title.subjectPageTitle.prefixedText then
⚫	local msg = 'Request to move a single page must be placed on that page\'s talk'
	return err(msg, argsByNum, args.reason, argsByNumCount)		return err(msg, argsByNum, args.reason, argsByNumCount)
	end		end
Line 276:		Line 271:
	.. '<br>If you cannot move it yourself, see [[Wikipedia:Requested moves#Requesting technical moves\|Requesting technical moves]].'		.. '<br>If you cannot move it yourself, see [[Wikipedia:Requested moves#Requesting technical moves\|Requesting technical moves]].'
	return err(msg, argsByNum, args.reason, argsByNumCount)		return err(msg, argsByNum, args.reason, argsByNumCount)
		⚫	end

		⚫	-- Request to move a single page must be placed on that page's talk, or the page it redirects to
		⚫	if not multi and args.current1 ~= title.subjectPageTitle.prefixedText then
			local idealpage = mw.title.new(args.current1).talkPageTitle
			local rtarget = mRedirect.getTarget(idealpage)
			if rtarget == title.prefixedText then
			multi = true
			else
		⚫	local msg = 'Request to move a single page must be placed on that page\'s talk or the page its talk redirects to'
		⚫	return err(msg, argsByNum, args.reason, argsByNumCount)
			end
	end		end

Pppery: This doesn't seem to be fixable at all

2018-06-21T19:43:52Z

This doesn't seem to be fixable at all

← Previous revision		Revision as of 19:43, 21 June 2018
Line 5:		Line 5:
	local tableTools = require('Module:TableTools')		local tableTools = require('Module:TableTools')
	local yesno = require('Module:Yesno')		local yesno = require('Module:Yesno')
	local getredirect = require('Module:Redirect').getTarget

	-- Set static values		-- Set static values
Line 219:		Line 218:
	end		end

	local titletarg = getredirect(title)
	-- Request to move a single page must be placed on that page's talk		-- Request to move a single page must be placed on that page's talk
	if not multi and args.current1 ~= title.subjectPageTitle.prefixedText		if not multi and args.current1 ~= title.subjectPageTitle.prefixedText then
	and (not titletarg or args.current1 ~= titletarg.subjectPageTitle.prefixedText) then
	local msg = 'Request to move a single page must be placed on that page\'s talk'		local msg = 'Request to move a single page must be placed on that page\'s talk'
	return err(msg, argsByNum, args.reason, argsByNumCount)		return err(msg, argsByNum, args.reason, argsByNumCount)

Pppery: Fix redirect case

2018-06-21T19:42:03Z

Fix redirect case

← Previous revision		Revision as of 19:42, 21 June 2018
Line 219:		Line 219:
	end		end

			local titletarg = getredirect(title)
	-- Request to move a single page must be placed on that page's talk		-- Request to move a single page must be placed on that page's talk
	if not multi and args.current1 ~= title.subjectPageTitle.prefixedText		if not multi and args.current1 ~= title.subjectPageTitle.prefixedText
	and args.current1 ~= ~~getredirect(title)~~.subjectPageTitle.prefixedText then		and (not titletarg or args.current1 ~= titletarg.subjectPageTitle.prefixedText) then
	local msg = 'Request to move a single page must be placed on that page\'s talk'		local msg = 'Request to move a single page must be placed on that page\'s talk'
	return err(msg, argsByNum, args.reason, argsByNumCount)		return err(msg, argsByNum, args.reason, argsByNumCount)