Module:ResolveEntityId - Revision history

MSGJ: add check that page is valid

2022-11-02T15:33:48Z

add check that page is valid

← Previous revision		Revision as of 15:33, 2 November 2022
Line 30:		Line 30:
	else		else
	-- idOrTitle is a title, but no wikidata item exists for that title		-- idOrTitle is a title, but no wikidata item exists for that title
	local ~~rtarget~~ = mw.title.new(idOrTitle)~~.redirectTarget~~		local page = mw.title.new(idOrTitle)
	if ~~rtarget~~ then		if page then -- valid title
			local rtarget = page.redirectTarget
	-- title is a Wikipedia redirect		if rtarget then -- title is a Wikipedia redirect
	return p._id(rtarget.fullText, alt)		return p._id(rtarget.fullText, alt)
			end
	end		end
	end		end

Ahecht: Sync from sandbox. Follow Wikipedia redirects, remove _entityid() function. Feel free to revert if any more issues crop up.

2022-03-03T02:11:37Z

Sync from sandbox. Follow Wikipedia redirects, remove _entityid() function. Feel free to revert if any more issues crop up.

@@ Line 1: / Line 1: @@
 local p = {}
-function p._entityid(_,id,alt)
+function p._id(idOrTitle, alt)
 			end
 		else
-					return mw.wikibase.getEntity(id).id
+		if mw.wikibase.isValidEntityId(idOrTitle) then
 				end
 			end
 		end
 	end
-	return alt or nil
+	return alt
 end

MSGJ: Undid revision 1073834942 by Ahecht (talk) - causing errors

2022-02-25T08:27:51Z

Undid revision 1073834942 by Ahecht (talk) - causing errors

← Previous revision		Revision as of 08:27, 25 February 2022
Line 1:		Line 1:
	local p = {}		local p = {}

			function p._entityid(_,id,alt)
			-- backwards compatibility for deprecated _entityid function
		⚫	return p._id(id,alt)
		⚫	end

	function p._id(id,alt)		function p._id(id,alt)
Line 8:		Line 13:
	if mw.wikibase.isValidEntityId(id) then		if mw.wikibase.isValidEntityId(id) then
	-- id is valid		-- id is valid
	if mw.wikibase.~~entityExists~~(id) ~~then~~		id = mw.wikibase.getEntity(id)
		⚫	if id then
	-- entity exists		-- entity exists
	return ~~mw.wikibase.getEntityIdForTitle(mw.wikibase~~.~~getSitelink(~~id))		return id.id
	end		end
	end		end
	else		else
	~~eid~~ = mw.wikibase.getEntityIdForTitle(id)		id = mw.wikibase.getEntityIdForTitle(id)
	if ~~eid~~ then		if id then
	-- ~~entity~~ id is a title that matches a Wikidata entity		-- id is a title that matches a Wikidata entity
	local instanceOf = mw.wikibase.getBestStatements(~~eid~~, 'P31')[1] --instance of		local instanceOf = mw.wikibase.getBestStatements(id, 'P31')[1] --instance of
	if (instanceOf and instanceOf.mainsnak.datavalue.value.id ~= 'Q4167410'~~) or (instanceOf == nil and mw.wikibase.entityExists(eid))~~ then		if instanceOf and instanceOf.mainsnak.datavalue.value.id ~= 'Q4167410' then
	-- not disambiguation~~, or exists but is missing an instance-of value~~		-- not disambiguation
	~~local rtarget =~~ mw.~~title~~.~~new~~(~~eid~~).~~redirectTarget~~		return mw.wikibase.getEntity(id).id
	if ~~rtarget~~ ~= ~~false~~ then		elseif instanceOf == nil then
	-- ~~title~~ is a ~~Wikipedia~~ ~~redirect~~		-- id is a title, but is missing an instance-of value
	return p.~~_id(rtarget~~.~~fullText,alt~~)		return mw.wikibase.getEntity(id).id
	else
	-- title is neither disambiguation or redirect
	return mw.wikibase.getEntityIdForTitle(mw.wikibase.getSitelink(eid))
	end
⚫	end
	else
	-- no wikidata item exists
	local rtarget = mw.title.new(id).redirectTarget
⚫	if ~~rtarget ~= false~~ then
	-- title is a Wikipedia redirect
⚫	return p._id(~~rtarget.fullText~~,alt)
	end		end
	end		end

Ahecht: Sync from sandbox, follow Wikipedia redirects.

2022-02-24T22:36:42Z

Sync from sandbox, follow Wikipedia redirects.

← Previous revision		Revision as of 22:36, 24 February 2022
Line 1:		Line 1:
	local p = {}		local p = {}

	function p._entityid(_,id,alt)
	-- backwards compatibility for deprecated _entityid function
⚫	return p._id(id,alt)
⚫	end

	function p._id(id,alt)		function p._id(id,alt)
Line 13:		Line 8:
	if mw.wikibase.isValidEntityId(id) then		if mw.wikibase.isValidEntityId(id) then
	-- id is valid		-- id is valid
	~~id =~~ mw.wikibase.~~getEntity~~(id)		if mw.wikibase.entityExists(id) then
⚫	if id then
	-- entity exists		-- entity exists
	return id.id		return mw.wikibase.getEntityIdForTitle(mw.wikibase.getSitelink(id))
	end		end
	end		end
	else		else
	id = mw.wikibase.getEntityIdForTitle(id)		eid = mw.wikibase.getEntityIdForTitle(id)
	if id then		if eid then
	-- id is a title that matches a Wikidata entity		-- entity id is a title that matches a Wikidata entity
	local instanceOf = mw.wikibase.getBestStatements(id, 'P31')[1] --instance of		local instanceOf = mw.wikibase.getBestStatements(eid, 'P31')[1] --instance of
	if instanceOf and instanceOf.mainsnak.datavalue.value.id ~= 'Q4167410' then		if (instanceOf and instanceOf.mainsnak.datavalue.value.id ~= 'Q4167410') or (instanceOf == nil and mw.wikibase.entityExists(eid)) then
	-- not disambiguation		-- not disambiguation, or exists but is missing an instance-of value
	~~return~~ mw.~~wikibase~~.~~getEntity~~(id).id		local rtarget = mw.title.new(eid).redirectTarget
	~~elseif~~ ~~instanceOf~~ == ~~nil~~ then		if rtarget ~= false then
	-- id is a ~~title, but is missing an instance-of~~ ~~value~~		-- title is a Wikipedia redirect
	return mw.~~wikibase~~.~~getEntity(id~~)~~.id~~		return p._id(rtarget.fullText,alt)
			else
			-- title is neither disambiguation or redirect
			return mw.wikibase.getEntityIdForTitle(mw.wikibase.getSitelink(eid))
			end
		⚫	end
			else
			-- no wikidata item exists
			local rtarget = mw.title.new(id).redirectTarget
		⚫	if rtarget ~= false then
			-- title is a Wikipedia redirect
		⚫	return p._id(rtarget.fullText,alt)
	end		end
	end		end

Ahecht: -- backwards compatibility for deprecated _entityid function

2018-10-04T15:37:31Z

-- backwards compatibility for deprecated _entityid function

← Previous revision		Revision as of 15:37, 4 October 2018
Line 2:		Line 2:

	function p._entityid(_,id,alt)		function p._entityid(_,id,alt)
			-- backwards compatibility for deprecated _entityid function
	return p._id(id,alt)		return p._id(id,alt)
	end		end

Ahecht: No reason to pass the frame any more now that we're not using the hacky workaround

2018-10-04T15:21:19Z

No reason to pass the frame any more now that we're not using the hacky workaround

← Previous revision		Revision as of 15:21, 4 October 2018
Line 1:		Line 1:
	local p = {}		local p = {}

	function p._entityid(~~frame~~,id,alt)		function p._entityid(_,id,alt)
			return p._id(id,alt)
			end

			function p._id(id,alt)
	if type(id) == 'string' then		if type(id) == 'string' then
	id = mw.ustring.upper(mw.ustring.sub(id,1,1))..mw.ustring.sub(id,2)		id = mw.ustring.upper(mw.ustring.sub(id,1,1))..mw.ustring.sub(id,2)
Line 33:		Line 37:

	function p.entityid(frame)		function p.entityid(frame)
	return p.~~_entityid~~(~~frame,~~ frame.args[1], frame.args[2])		return p._id(frame.args[1], frame.args[2])
	end		end

Tom.Reding: +functionality for titles missing a value for instance of (P31) (e.g. Crassispira sulcata), from sandbox

2018-09-09T18:22:53Z

+functionality for titles missing a value for instance of (P31) (e.g. Crassispira sulcata), from sandbox

← Previous revision		Revision as of 18:22, 9 September 2018
Line 18:		Line 18:
	if id then		if id then
	-- id is a title that matches a Wikidata entity		-- id is a title that matches a Wikidata entity
	local instanceOf = mw.wikibase.getBestStatements(id, 'P31')[1]		local instanceOf = mw.wikibase.getBestStatements(id, 'P31')[1] --instance of
	if instanceOf and instanceOf.mainsnak.datavalue.value.id ~= 'Q4167410' then		if instanceOf and instanceOf.mainsnak.datavalue.value.id ~= 'Q4167410' then
	-- not disambiguation		-- not disambiguation
			return mw.wikibase.getEntity(id).id
			elseif instanceOf == nil then
			-- id is a title, but is missing an instance-of value
	return mw.wikibase.getEntity(id).id		return mw.wikibase.getEntity(id).id
	end		end

EdJohnston: Protected "Module:ResolveEntityId": High-risk Lua module: Request at WP:RFPP ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

2018-06-26T04:07:00Z

Protected "Module:ResolveEntityId": High-risk Lua module: Request at WP:RFPP ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

← Previous revision	Revision as of 04:07, 26 June 2018
(No difference)

Ahecht: alt

2018-04-16T17:46:25Z

alt

← Previous revision		Revision as of 17:46, 16 April 2018
Line 1:		Line 1:
	local p = {}		local p = {}

	function p._entityid(frame,id)		function p._entityid(frame,id,alt)
	if type(id) == 'string' then		if type(id) == 'string' then
	id = mw.ustring.upper(mw.ustring.sub(id,1,1))..mw.ustring.sub(id,2)		id = mw.ustring.upper(mw.ustring.sub(id,1,1))..mw.ustring.sub(id,2)
Line 26:		Line 26:
	end		end
	end		end
	return ~~frame.args[2]~~ or nil		return alt or nil
	end		end

	function p.entityid(frame)		function p.entityid(frame)
	return p._entityid(frame, frame.args[1])		return p._entityid(frame, frame.args[1], frame.args[2])
	end		end

Ahecht: frame.args[2]

2018-04-16T17:42:01Z

frame.args[2]

← Previous revision		Revision as of 17:42, 16 April 2018
Line 1:		Line 1:
	local p = {}		local p = {}

	function p.getEntity(frame)
	local z=mw.wikibase.getEntity(frame.args[1])
⚫	end

	function p._entityid(frame,id)		function p._entityid(frame,id)
Line 10:		Line 6:
	if mw.ustring.match(id,'^Q%d+$') then		if mw.ustring.match(id,'^Q%d+$') then
	-- id is in the proper format for a Wikidata entity		-- id is in the proper format for a Wikidata entity
			if mw.wikibase.isValidEntityId(id) then
	if frame:preprocess("{{#iferror:{{#invoke:ResolveEntityId\|getEntity\|".. id .. "}}\|error}}") ~= "error" then
	-- ~~getEntity(~~id) ~~doesn't~~ ~~return an error~~		-- id is valid
	~~return~~ mw.wikibase.getEntity(id)~~.id~~		id = mw.wikibase.getEntity(id)
			if id then
			-- entity exists
			return id.id
		⚫	end
	end		end
	else		else
Line 26:		Line 26:
	end		end
	end		end
	return nil		return frame.args[2] or nil
	end		end