Module:Roman - Revision history

Uzume: strict

2023-02-08T20:14:10Z

strict

← Previous revision		Revision as of 20:14, 8 February 2023
Line 1:		Line 1:
	-- This module implements {{Roman}}.		-- This module implements {{Roman}}.
			require[[strict]]

	local p = {}		local p = {}

Uzume: partial revert of 717267156 to avoid throwing errors from mw.ext.ParserFunctions.expr (as they are not very useful); delay until we throw an "Invalid number" error later

2023-02-08T19:31:17Z

partial revert of 717267156 to avoid throwing errors from mw.ext.ParserFunctions.expr (as they are not very useful); delay until we throw an "Invalid number" error later

← Previous revision		Revision as of 19:31, 8 February 2023
Line 119:		Line 119:
	-- Given mathematical expression, simplify to a number		-- Given mathematical expression, simplify to a number
	if type(args[1]) == 'string' then		if type(args[1]) == 'string' then
	~~args[1]~~ = mw.ext.ParserFunctions.expr(args[1])		local success, result = pcall(mw.ext.ParserFunctions.expr, args[1])
			if success then
			args[1] = result
			end -- else, pass to _main routine and try to let Lua's tonumber handle it
	end		end
	return _main(args)		return _main(args)

Xaosflux: update symbol on line 80, requested on talk

2018-11-03T16:03:52Z

update symbol on line 80, requested on talk

← Previous revision		Revision as of 16:03, 3 November 2018
Line 78:		Line 78:
	{ 1/2, 'S' }, { 5/12, "''':'''•''':'''" }, { 1/3, "'''::'''" },		{ 1/2, 'S' }, { 5/12, "''':'''•''':'''" }, { 1/3, "'''::'''" },
	{ 1/4, "''':'''•" }, { 1/6, "''':'''" }, { 1/12, '•' },		{ 1/4, "''':'''•" }, { 1/6, "''':'''" }, { 1/12, '•' },
	{ 1/24, 'Є' }, { 1/36, 'ƧƧ' }, { 1/48, 'Ɔ' }, { 1/72, 'Ƨ' }, { 1/144, 'ƻ' },		{ 1/24, 'Є' }, { 1/36, 'ƧƧ' }, { 1/48, 'Ɔ' }, { 1/72, 'Ƨ' }, { 1/144, '<s>Ƨ</s>' },
	{ 1/288, '℈' }, { 1/1728, '»' },		{ 1/288, '℈' }, { 1/1728, '»' },
	}		}

Jackmcbarn: try again to avoid pretending everything's fine when something is really wrong, this time without causing an error on 2016

2016-04-26T17:59:12Z

try again to avoid pretending everything's fine when something is really wrong, this time without causing an error on 2016

← Previous revision		Revision as of 17:59, 26 April 2016
Line 28:		Line 28:
	if args[1] == nil then return end		if args[1] == nil then return end
	local num = tonumber(args[1])		local num = tonumber(args[1])
	if ~~type(~~num) ~= ~~"number"~~ then		if not num or num < 0 or num == math.huge then
	error('Invalid ~~input,~~ ~~not~~ ~~recognized~~ ~~as a number'~~, 2)		error('Invalid number ' .. args[1], 2)
	elseif num < 0 or num == math.huge then
	error(string.format(args[1] .. ' is out of range'), 2)
	return
	elseif num == 0 then		elseif num == 0 then
	return 'N'		return 'N'
Line 121:		Line 118:
	if args == nil or args == {} then return end		if args == nil or args == {} then return end
	-- Given mathematical expression, simplify to a number		-- Given mathematical expression, simplify to a number
	if args[1] then		if type(args[1]) == 'string' then
	~~local success, result~~ = ~~pcall(~~mw.ext.ParserFunctions.expr, args[1])		args[1] = mw.ext.ParserFunctions.expr(args[1])
	if success then
	args[1] = result
	end -- else, pass to _main routine and try to let Lua's tonumber handle it
	end		end
	return _main(args)		return _main(args)

Waggers: Changed protection level of Module:Roman: Highly visible template ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

2016-04-26T09:05:59Z

Changed protection level of Module:Roman: Highly visible template ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

← Previous revision	Revision as of 09:05, 26 April 2016
(No difference)

Andy M. Wang: sync

2016-04-26T04:46:15Z

sync

← Previous revision		Revision as of 04:46, 26 April 2016
Line 25:		Line 25:
	-- The main control flow of the module.		-- The main control flow of the module.
	local function _main(args)		local function _main(args)
	-- Get input and exit displaying nothing if the input is ~~bad~~.		-- Get input and exit displaying nothing if the input is empty.
			if args[1] == nil then return end
	local num = tonumber(args[1])		local num = tonumber(args[1])
	if type(num) ~= "number" then		if type(num) ~= "number" then

Andy M. Wang: will complain how on non-numeric input

2016-04-26T04:39:16Z

will complain how on non-numeric input

← Previous revision		Revision as of 04:39, 26 April 2016
Line 26:		Line 26:
	local function _main(args)		local function _main(args)
	-- Get input and exit displaying nothing if the input is bad.		-- Get input and exit displaying nothing if the input is bad.
⚫	if args == nil then return end
	local num = tonumber(args[1])		local num = tonumber(args[1])
	if num == nil then return end
	if type(num) ~= "number" then		if type(num) ~= "number" then
	error('Invalid input, not recognized as a number', 2)		error('Invalid input, not recognized as a number', 2)
Line 119:		Line 117:
	end		end

			-- exit if not given anything
		⚫	if args == nil or args == {} then return end
	-- Given mathematical expression, simplify to a number		-- Given mathematical expression, simplify to a number
	if args[1] then		if args[1] then

Andy M. Wang: more explicit checks

2016-04-26T04:31:02Z

more explicit checks

← Previous revision		Revision as of 04:31, 26 April 2016
Line 26:		Line 26:
	local function _main(args)		local function _main(args)
	-- Get input and exit displaying nothing if the input is bad.		-- Get input and exit displaying nothing if the input is bad.
			if args == nil then return end
	local num = tonumber(args[1])		local num = tonumber(args[1])
	if num == nil then		if num == nil then return end
	~~error~~(~~string.format('Invalid~~ number ~~' .. args[1]), 2)~~		if type(num) ~= "number" then
			error('Invalid input, not recognized as a number', 2)
	elseif num < 0 or num == math.huge then		elseif num < 0 or num == math.huge then
	error(string.format(args[1] .. ' is out of range'), 2)		error(string.format(args[1] .. ' is out of range'), 2)

Andy M. Wang: explicit check for nil

2016-04-26T04:27:20Z

explicit check for nil

← Previous revision		Revision as of 04:27, 26 April 2016
Line 27:		Line 27:
	-- Get input and exit displaying nothing if the input is bad.		-- Get input and exit displaying nothing if the input is bad.
	local num = tonumber(args[1])		local num = tonumber(args[1])
	if ~~not~~ num ~~then~~ ~~return~~		if num == nil then
			error(string.format('Invalid number ' .. args[1]), 2)
	elseif num < 0 or num == math.huge then		elseif num < 0 or num == math.huge then
	error(string.format(args[1] .. ' is out of range'), 2)		error(string.format(args[1] .. ' is out of range'), 2)

Andy M. Wang: out of range message (could have been math.huge which is not negative)

2016-04-26T04:21:01Z

out of range message (could have been math.huge which is not negative)

← Previous revision		Revision as of 04:21, 26 April 2016
Line 27:		Line 27:
	-- Get input and exit displaying nothing if the input is bad.		-- Get input and exit displaying nothing if the input is bad.
	local num = tonumber(args[1])		local num = tonumber(args[1])
	if not num or num < 0 or num == math.huge then		if not num then return
			elseif num < 0 or num == math.huge then
	error(string.format(~~'Invalid~~ ~~number~~ ' .. ~~args[1]~~), 2)		error(string.format(args[1] .. ' is out of range'), 2)
	return		return
	elseif num == 0 then		elseif num == 0 then