Module:Roman/sandbox - Revision history

Chó Vàng Hài Hước at 13:22, 1 January 2025

2025-01-01T13:22:41Z

← Previous revision		Revision as of 13:22, 1 January 2025
Line 1:		Line 1:
	-- This module implements {{Roman}}.		-- This module implements {{Roman}}.
	require[[strict]]		require('strict')

	local p = {}		local p = {}

Uzume: strict

2023-02-08T19:33:07Z

strict

← Previous revision		Revision as of 19:33, 8 February 2023
Line 1:		Line 1:
	-- This module implements {{Roman}}.		-- This module implements {{Roman}}.
			require[[strict]]

	local p = {}		local p = {}
Line 78:		Line 79:
	{ 1/2, 'S' }, { 5/12, "''':'''•''':'''" }, { 1/3, "'''::'''" },		{ 1/2, 'S' }, { 5/12, "''':'''•''':'''" }, { 1/3, "'''::'''" },
	{ 1/4, "''':'''•" }, { 1/6, "''':'''" }, { 1/12, '•' },		{ 1/4, "''':'''•" }, { 1/6, "''':'''" }, { 1/12, '•' },
	{ 1/24, 'Є' }, { 1/36, 'ƧƧ' }, { 1/48, 'Ɔ' }, { 1/72, 'Ƨ' }, { 1/144, 'ƻ' },		{ 1/24, 'Є' }, { 1/36, 'ƧƧ' }, { 1/48, 'Ɔ' }, { 1/72, 'Ƨ' }, { 1/144, '<s>Ƨ</s>' },
	{ 1/288, '℈' }, { 1/1728, '»' },		{ 1/288, '℈' }, { 1/1728, '»' },
	}		}
Line 119:		Line 120:
	-- Given mathematical expression, simplify to a number		-- Given mathematical expression, simplify to a number
	if type(args[1]) == 'string' then		if type(args[1]) == 'string' then
	~~args[1]~~ = mw.ext.ParserFunctions.expr(args[1])		local success, result = pcall(mw.ext.ParserFunctions.expr, args[1])
			if success then
			args[1] = result
			end -- else, pass to _main routine and try to let Lua's tonumber handle it
	end		end
	return _main(args)		return _main(args)

ASiplas: Revert—duplicate of Module:ConvertNumeric's roman_to_numeral

2018-02-20T22:01:44Z

Revert—duplicate of Module:ConvertNumeric's roman_to_numeral

@@ Line 87: / Line 87: @@
     return ret
 end
@@ Line 135: / Line 104: @@
         origArgs = frame
     end
     -- Trim whitespace and remove blank arguments.
     local args = {}
@@ Line 154: / Line 118: @@
     if args == nil or args == {} then return end
     -- Given mathematical expression, simplify to a number
-    if type(args[1]) == 'string' and not toarabic then
+    if type(args[1]) == 'string' then
         args[1] = mw.ext.ParserFunctions.expr(args[1])
     end
 end

ASiplas: fix "Lua error in Module:Roman/sandbox at line 139: bad argument #1 to 'upper' (string expected, got nil).'"

2018-02-20T19:28:25Z

fix "Lua error in Module:Roman/sandbox at line 139: bad argument #1 to 'upper' (string expected, got nil).'"

← Previous revision		Revision as of 19:28, 20 February 2018
Line 136:		Line 136:
	end		end

			if origArgs[1] == nil then return end
	-- If matches a roman numeral, convert to arabic ('N' is from testcase here)		-- If matches a roman numeral, convert to arabic ('N' is from testcase here)
	local toarabic = string.upper(origArgs[1]):match("[IVXLCDMN]")		local toarabic = string.upper(origArgs[1]):match("[IVXLCDMN]")

ASiplas: remove confusing coercion of string match to true/false – matched character is not nil and is fine for "for if…and not…" conditional, non-match is nil anyways

2018-02-20T10:43:33Z

remove confusing coercion of string match to true/false – matched character is not nil and is fine for "for if…and not…" conditional, non-match is nil anyways

← Previous revision		Revision as of 10:43, 20 February 2018
Line 137:		Line 137:

	-- If matches a roman numeral, convert to arabic ('N' is from testcase here)		-- If matches a roman numeral, convert to arabic ('N' is from testcase here)
	local toarabic = ~~not (~~string.upper(origArgs[1]):match("[IVXLCDMN]"~~) == nil~~)		local toarabic = string.upper(origArgs[1]):match("[IVXLCDMN]")

	-- Trim whitespace and remove blank arguments.		-- Trim whitespace and remove blank arguments.

ASiplas: Working code for potential merge

2018-02-20T10:07:27Z

Working code for potential merge

@@ Line 87: / Line 87: @@
     return ret
 end
@@ Line 104: / Line 135: @@
         origArgs = frame
     end
     -- Trim whitespace and remove blank arguments.
     local args = {}
@@ Line 118: / Line 153: @@
     if args == nil or args == {} then return end
     -- Given mathematical expression, simplify to a number
-    if type(args[1]) == 'string' then
+    if type(args[1]) == 'string' and not toarabic then
         args[1] = mw.ext.ParserFunctions.expr(args[1])
     end
 end

Andy M. Wang: sync with live

2016-04-26T18:11:11Z

sync with live

← Previous revision		Revision as of 18:11, 26 April 2016
Line 28:		Line 28:
	if args[1] == nil then return end		if args[1] == nil then return end
	local num = tonumber(args[1])		local num = tonumber(args[1])
	if ~~type(~~num) ~= ~~"number"~~ then		if not num or num < 0 or num == math.huge then
	error('Invalid ~~input,~~ ~~not~~ ~~recognized~~ ~~as a number'~~, 2)		error('Invalid number ' .. args[1], 2)
	elseif num < 0 or num == math.huge then
	error(string.format(args[1] .. ' is out of range'), 2)
	return
	elseif num == 0 then		elseif num == 0 then
	return 'N'		return 'N'
Line 121:		Line 118:
	if args == nil or args == {} then return end		if args == nil or args == {} then return end
	-- Given mathematical expression, simplify to a number		-- Given mathematical expression, simplify to a number
	if args[1] then		if type(args[1]) == 'string' then
	~~local success, result~~ = ~~pcall(~~mw.ext.ParserFunctions.expr, args[1])		args[1] = mw.ext.ParserFunctions.expr(args[1])
	if success then
	args[1] = result
	end -- else, pass to _main routine and try to let Lua's tonumber handle it
	end		end
	return _main(args)		return _main(args)

Andy M. Wang: try without check

2016-04-26T04:45:36Z

try without check

← Previous revision		Revision as of 04:45, 26 April 2016
Line 123:		Line 123:
	if args[1] then		if args[1] then
	local success, result = pcall(mw.ext.ParserFunctions.expr, args[1])		local success, result = pcall(mw.ext.ParserFunctions.expr, args[1])
	if success ~~and type(result) == "number"~~ then		if success then
	args[1] = result		args[1] = result
	end -- else, pass to _main routine and try to let Lua's tonumber handle it		end -- else, pass to _main routine and try to let Lua's tonumber handle it

Andy M. Wang: checks

2016-04-26T04:43:00Z

checks

← Previous revision		Revision as of 04:43, 26 April 2016
Line 25:		Line 25:
	-- The main control flow of the module.		-- The main control flow of the module.
	local function _main(args)		local function _main(args)
	-- Get input and exit displaying nothing if the input is ~~bad~~.		-- Get input and exit displaying nothing if the input is empty.
			if args[1] == nil then return end
	local num = tonumber(args[1])		local num = tonumber(args[1])
	if type(num) ~= "number" then		if type(num) ~= "number" then
Line 122:		Line 123:
	if args[1] then		if args[1] then
	local success, result = pcall(mw.ext.ParserFunctions.expr, args[1])		local success, result = pcall(mw.ext.ParserFunctions.expr, args[1])
	if success then		if success and type(result) == "number" then
	args[1] = result		args[1] = result
	end -- else, pass to _main routine and try to let Lua's tonumber handle it		end -- else, pass to _main routine and try to let Lua's tonumber handle it

Andy M. Wang: rm some checks

2016-04-26T04:38:13Z

rm some checks

← Previous revision		Revision as of 04:38, 26 April 2016
Line 26:		Line 26:
	local function _main(args)		local function _main(args)
	-- Get input and exit displaying nothing if the input is bad.		-- Get input and exit displaying nothing if the input is bad.
⚫	if args == nil then return end
	local num = tonumber(args[1])		local num = tonumber(args[1])
	if num == nil then return end
	if type(num) ~= "number" then		if type(num) ~= "number" then
	error('Invalid input, not recognized as a number', 2)		error('Invalid input, not recognized as a number', 2)
Line 119:		Line 117:
	end		end

			-- exit if not given anything
		⚫	if args == nil or args == {} then return end
	-- Given mathematical expression, simplify to a number		-- Given mathematical expression, simplify to a number
	if args[1] then		if args[1] then