Module:Shogi diagram - Revision history

COArSe D1RTxxx: [ditto]

2024-12-22T16:50:29Z

[ditto]

← Previous revision		Revision as of 16:50, 22 December 2024
Line 114:		Line 114:
	pieceabbr = 'gyoku'		pieceabbr = 'gyoku'
	end		end
	-- convert abbreviation to Japanese character		-- convert abbreviation to Japanese character and return
	~~local piecechar =~~ piecesymbol(pieceabbr)		return {piecesymbol(pieceabbr), side, color, boldness}

	return {piecechar, side, color, boldness}
	end		end

COArSe D1RTxxx: why would you allocate a variable just to immediately return it

2024-12-22T16:49:32Z

why would you allocate a variable just to immediately return it

← Previous revision		Revision as of 16:49, 22 December 2024
Line 117:		Line 117:
	local piecechar = piecesymbol(pieceabbr)		local piecechar = piecesymbol(pieceabbr)

	~~local result =~~ {piecechar, side, color, boldness}		return {piecechar, side, color, boldness}
	return result
	end		end

COArSe D1RTxxx: Removed unneeded calculations in case of arrows

2024-12-22T16:47:19Z

Removed unneeded calculations in case of arrows

@@ Line 49: / Line 49: @@
 	-- strip whitespace
 	ss = mw.text.trim(ss)
 	-- get the last character of the string
 	local lastchar = mw.ustring.sub(ss, -1)
 	-- chop off last character of string
 	local restofstring = mw.ustring.sub(ss, 1, -2)
@@ Line 97: / Line 116: @@
 	-- convert abbreviation to Japanese character
 	local piecechar = piecesymbol(pieceabbr)
 	local result = {piecechar, side, color, boldness}

Billnyethefrenchfry: The single dumbest bug I have ever patched — Fixed alternate kings not working correctly, and you'll never guess how

2024-05-14T16:36:27Z

The single dumbest bug I have ever patched — Fixed alternate kings not working correctly, and you'll never guess how

← Previous revision		Revision as of 16:36, 14 May 2024
Line 60:		Line 60:
	-- then the font should be bold and we need to get a new string with the this 'l' chopped off (with a new last character)		-- then the font should be bold and we need to get a new string with the this 'l' chopped off (with a new last character)
	local boldness = 'normal'		local boldness = 'normal'
	if lastchar~~:match(~~'l') then		if lastchar == 'l' then
	boldness = 'bold'		boldness = 'bold'
	lastchar = mw.ustring.sub(restofstring, -1)		lastchar = mw.ustring.sub(restofstring, -1)
Line 76:		Line 76:
	-- if the piece is promoted (one the abbreviations below), then the piece should be red		-- if the piece is promoted (one the abbreviations below), then the piece should be red
	local color = 'black'		local color = 'black'
	if pieceabbr~~:match(~~'t') or pieceabbr~~:match(~~'pl') or pieceabbr~~:match(~~'pn') or pieceabbr~~:match(~~'ps') or pieceabbr~~:match(~~'h') or pieceabbr~~:match(~~'d') then		if pieceabbr == 't' or pieceabbr == 'pl' or pieceabbr == 'pn' or pieceabbr == 'ps' or pieceabbr == 'h' or pieceabbr == 'd' then
	color = 'red'		color = 'red'
	end		end
Line 82:		Line 82:
	-- gote's king is usually 王 instead of 玉 by convention,		-- gote's king is usually 王 instead of 玉 by convention,
	-- but it's convenient to use the 'k' code for both sente and gote and let the default character be side-dependent		-- but it's convenient to use the 'k' code for both sente and gote and let the default character be side-dependent
	if pieceabbr~~:match(~~'k') and side~~:match(~~'g') then		if pieceabbr == 'k' and side == 'g' then
	pieceabbr = 'ou'		pieceabbr = 'ou'
	end		end
	if pieceabbr~~:match(~~'k') and side~~:match(~~'s') then		if pieceabbr == 'k' and side == 's' then
	pieceabbr = 'gyoku'		pieceabbr = 'gyoku'
	end		end
	-- similar to above exception, reverse default		-- similar to above exception, reverse default
	if pieceabbr~~:match(~~'ak') and side~~:match(~~'s') then		if pieceabbr == 'ak' and side == 's' then
	pieceabbr = 'ou'		pieceabbr = 'ou'
	end		end
	if pieceabbr~~:match(~~'ak') and side~~:match(~~'g') then		if pieceabbr == 'ak' and side == 'g' then
	pieceabbr = 'gyoku'		pieceabbr = 'gyoku'
	end		end

Billnyethefrenchfry: 86th arg is already used for something else, even though it isn't anywhere in the code for some reason.

2024-05-14T16:15:19Z

86th arg is already used for something else, even though it isn't anywhere in the code for some reason.

← Previous revision		Revision as of 16:15, 14 May 2024
Line 189:		Line 189:
	-- special args		-- special args
	local special = {}		local special = {}
	if args[86] then		if args[87] then
	-- a list of arguments separated by spaces		-- a list of arguments separated by spaces
	for w in string.gmatch(args[86], "%w+") do		for w in string.gmatch(args[87], "%w+") do
	if string.sub(w, 1, 1) == "f" then -- flipped board		if string.sub(w, 1, 1) == "f" then -- flipped board
	special.flip = true		special.flip = true

Billnyethefrenchfry: Added flipped board and Japanese row labeling

2024-05-01T14:08:45Z

Added flipped board and Japanese row labeling

@@ Line 187: / Line 187: @@
 -- this is basically a <div> enclosing a .css <div> wrapper with a <table> inside
 function shogiboard(args)
 	-- these are the column coordinate labels 9-1
-	local colLabels = {'9', '8', '7', '6', '5', '4', '3', '2', '1', '&nbsp;'}
+	local colLabels
-	local rowLabels = {'1', '2', '3', '4', '5', '6', '7', '8', '9'}
+		colLabels = {'9', '8', '7', '6', '5', '4', '3', '2', '1', '&nbsp;'}
-	-- this isn't set up for use yet
+	-- these are the row coordinate labels
 	local headerarg = args[2]
@@ Line 220: / Line 247: @@
 		pieceinhandtopdiv:css('padding', '0')
 		pieceinhandtopdiv:css('font-size', '12px')
 	-- i was going to put the actual argument text into conditional <span> .css formating, but i couldn't get the logical test in an if/else structure right...
 	local piecesinhandtopspan = pieceinhandtopdiv:tag('span')
@@ Line 282: / Line 313: @@
 	-- this is the 'piece-in-hand' argument for sente (same as above for gote)
 	local strippedpieceinhandbottom = mw.text.trim(args[81+1+nx]) or ''
 	local pieceinhandbottomdiv = shogiboardwrapper:tag('div')
 		pieceinhandbottomdiv:css('padding', '0')
 		pieceinhandbottomdiv:css('font-size', '12px')
 	local piecesinhandbottomspan = pieceinhandbottomdiv:tag('span')
 		piecesinhandbottomspan:css('font-size', '13px')

Billnyethefrenchfry: Added comments for lines and arrows

2024-04-30T20:48:40Z

Added comments for lines and arrows

@@ Line 97: / Line 97: @@
 	-- convert abbreviation to Japanese character
 	local piecechar = piecesymbol(pieceabbr)
-           ss:match('da') or ss:match('dau') or ss:match('dad') or ss:match('daus') or ss:match('dads') or ss:match('daa') or
+	if ss:match('yy') or ss:match('gr') or ss:match('rat') or ss:match('lat') or ss:match('uat') or ss:match('dat') or
-           ss:match('kadr') or ss:match('kadl') or ss:match('rah') or ss:match('lah') or ss:match('dah') or ss:match('uah') or
+           ss:match('lra') or ss:match('las') or ss:match('ras') or ss:match('uda') or ss:match('das') or ss:match('uas') or
            ss:match('dul') or ss:match('dur') then
 		piecechar = '[[File:shogi_' .. ss .. '22.svg|20px]]'

Techie3: replace link with loop

2022-07-29T11:23:03Z

replace link with loop

@@ Line 248: / Line 248: @@
 	-- iterate over the 81 shogi piece arguments (left to right, top to bottom)
 	-- index number displacement/offset
@@ Line 255: / Line 253: @@
 	-- i just keep the piece arguments as indexes 1-81, then add nx to the index value
 	nx = 3
-		:css('border', 'none')
+			:css('font-size', colrowfontsize)
-		:css('font-size', colrowfontsize)
+			:css('padding-left', padrowlab)
-		:css('padding-left', padrowlab)
+			:css('padding-top', '0')
-		:css('padding-top', '0')
+			:css('padding-bottom', '0')
-		:css('padding-bottom', '0')
+			:css('background-color', '#f9f9f9')
 	end
 	-- this is the 'piece-in-hand' argument for sente (same as above for gote)

Ish ishwar: adjust comments

2017-09-30T21:29:23Z

adjust comments

← Previous revision		Revision as of 21:29, 30 September 2017
Line 212:		Line 212:
	pieceinhandtopdiv:css('padding', '0')		pieceinhandtopdiv:css('padding', '0')
	pieceinhandtopdiv:css('font-size', '12px')		pieceinhandtopdiv:css('font-size', '12px')
	-- △ is a white triangle symbol
	pieceinhandtopdiv:wikitext('☖ pieces in hand: ')		pieceinhandtopdiv:wikitext('☖ pieces in hand: ')
	-- i was going to put the actual argument text into conditional <span> .css formating, but i couldn't get the logical test in an if/else structure right...		-- i was going to put the actual argument text into conditional <span> .css formating, but i couldn't get the logical test in an if/else structure right...
Line 373:		Line 372:

	-- this is the 'piece-in-hand' argument for sente (same as above for gote)		-- this is the 'piece-in-hand' argument for sente (same as above for gote)
	-- only difference is the black ~~triangle~~ (~~▲~~)		-- only difference is the black shogi piece glyph (☗)
	local strippedpieceinhandbottom = mw.text.trim(args[81+1+nx]) or ''		local strippedpieceinhandbottom = mw.text.trim(args[81+1+nx]) or ''
	local pieceinhandbottomdiv = shogiboardwrapper:tag('div')		local pieceinhandbottomdiv = shogiboardwrapper:tag('div')

Ish ishwar: shogi pieces

2017-09-30T21:28:09Z

shogi pieces

← Previous revision		Revision as of 21:28, 30 September 2017
Line 213:		Line 213:
	pieceinhandtopdiv:css('font-size', '12px')		pieceinhandtopdiv:css('font-size', '12px')
	-- △ is a white triangle symbol		-- △ is a white triangle symbol
	pieceinhandtopdiv:wikitext('~~△~~ pieces in hand: ')		pieceinhandtopdiv:wikitext('☖ pieces in hand: ')
	-- i was going to put the actual argument text into conditional <span> .css formating, but i couldn't get the logical test in an if/else structure right...		-- i was going to put the actual argument text into conditional <span> .css formating, but i couldn't get the logical test in an if/else structure right...
	local piecesinhandtopspan = pieceinhandtopdiv:tag('span')		local piecesinhandtopspan = pieceinhandtopdiv:tag('span')
Line 378:		Line 378:
	pieceinhandbottomdiv:css('padding', '0')		pieceinhandbottomdiv:css('padding', '0')
	pieceinhandbottomdiv:css('font-size', '12px')		pieceinhandbottomdiv:css('font-size', '12px')
	pieceinhandbottomdiv:wikitext('~~▲~~ pieces in hand: ')		pieceinhandbottomdiv:wikitext('☗ pieces in hand: ')
	local piecesinhandbottomspan = pieceinhandbottomdiv:tag('span')		local piecesinhandbottomspan = pieceinhandbottomdiv:tag('span')
	piecesinhandbottomspan:css('font-size', '13px')		piecesinhandbottomspan:css('font-size', '13px')