Module:Sortkey - Revision history

Pppery: Fixed unintended global variable use

2021-10-05T18:54:13Z

Fixed unintended global variable use

← Previous revision		Revision as of 18:54, 5 October 2021
Line 28:		Line 28:

	function p._sortKeyForNumber(value)		function p._sortKeyForNumber(value)
			local sortkey
	if not valid_number(value) then		if not valid_number(value) then
	if value < 0 then		if value < 0 then

MusikAnimal: Protected "Module:Sortkey": High-risk Lua module ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

2019-01-24T21:05:10Z

Protected "Module:Sortkey": High-risk Lua module ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

← Previous revision	Revision as of 21:05, 24 January 2019
(No difference)

TheDJ at 20:38, 21 September 2018

2018-09-21T20:38:33Z

← Previous revision		Revision as of 20:38, 21 September 2018
Line 45:		Line 45:
	value = value + 10^(mag+1)		value = value + 10^(mag+1)
	end		end
	sortkey = string.format('%d', prefix) .. string.format('%015.0f', math.floor(value * 10^(math.min(14,14-mag))))		sortkey = string.format('%d', prefix) .. string.format('%015.0f', math.floor(value * 10^(math.min(28,14-mag))))
	end		end
	return sortkey;		return sortkey;

TheDJ: we can print at most 15 digits, so maximum of 14 on the exponent should avoid rounding errors

2018-09-21T20:20:42Z

we can print at most 15 digits, so maximum of 14 on the exponent should avoid rounding errors

← Previous revision		Revision as of 20:20, 21 September 2018
Line 45:		Line 45:
	value = value + 10^(mag+1)		value = value + 10^(mag+1)
	end		end
	sortkey = string.format('%d', prefix) .. string.format('%015.0f', math.floor(value * 10^(14-mag)))		sortkey = string.format('%d', prefix) .. string.format('%015.0f', math.floor(value * 10^(math.min(14,14-mag))))
	end		end
	return sortkey;		return sortkey;

TheDJ at 18:59, 18 September 2018

2018-09-18T18:59:23Z

← Previous revision		Revision as of 18:59, 18 September 2018
Line 37:		Line 37:
	sortkey = '5000000000000000000'		sortkey = '5000000000000000000'
	else		else
	local mag = floor(log10(abs(value)) + 1e-14)		local mag = math.floor(math.log10(math.abs(value)) + 1e-14)
	local prefix		local prefix
	if value > 0 then		if value > 0 then
Line 45:		Line 45:
	value = value + 10^(mag+1)		value = value + 10^(mag+1)
	end		end
	sortkey = format('%d', prefix) .. format('%015.0f', floor(value * 10^(14-mag)))		sortkey = string.format('%d', prefix) .. string.format('%015.0f', math.floor(value * 10^(14-mag)))
	end		end
	return sortkey;		return sortkey;

TheDJ at 18:57, 18 September 2018

2018-09-18T18:57:31Z

@@ Line 15: / Line 15: @@
 	local args = getArgs(frame);
 	return p._encode(args[1] or "")
 end

TheDJ at 18:56, 18 September 2018

2018-09-18T18:56:04Z

← Previous revision		Revision as of 18:56, 18 September 2018
Line 17:		Line 17:
	end		end

	function p.~~sortKeyForNumber~~(value)		function p._sortKeyForNumber(value)
	if not valid_number(value) then		if not valid_number(value) then
	if value < 0 then		if value < 0 then

TheDJ at 18:44, 18 September 2018

2018-09-18T18:44:39Z

@@ Line 15: / Line 15: @@
 	local args = getArgs(frame);
 	return p._encode(args[1] or "")
 end

Johnuniq: Module:Arguments defaults to removing blank arguments but gives an error with string.find; for example List of rampage killers (Asia) uses {{hs|}}

2018-06-28T01:43:55Z

Module:Arguments defaults to removing blank arguments but gives an error with string.find; for example List of rampage killers (Asia) uses {{hs|}}

← Previous revision		Revision as of 01:43, 28 June 2018
Line 14:		Line 14:
	function p.encode(frame)		function p.encode(frame)
	local args = getArgs(frame);		local args = getArgs(frame);
	return p._encode(args[1])		return p._encode(args[1] or "")
	end		end

TheDJ at 18:30, 27 June 2018

2018-06-27T18:30:49Z

← Previous revision		Revision as of 18:30, 27 June 2018
Line 1:		Line 1:
			local getArgs = require('Module:Arguments').getArgs

	local p = {}		local p = {}

⚫	function p.encode(frame)
			function p._encode(sortkey)
⚫	local ~~sortkey~~ = frame~~.args[1]~~;
	-- Protect against sortkey nesting.		-- Protect against sortkey nesting.
	-- Example: {{sort\|{{dts\|2013\|07\|07}}\|{{dts\|1990\|12\|01}}}}		-- Example: {{sort\|{{dts\|2013\|07\|07}}\|{{dts\|1990\|12\|01}}}}
	if string.find(sortkey, "sortkey") then		if string.find(sortkey, "sortkey") or string.find(sortkey, "data-sort-value") then
	return "";		return "";
	end		end
	return mw.text.encode(sortkey)		return mw.text.encode(sortkey)
	end		end

		⚫	function p.encode(frame)
		⚫	local args = getArgs(frame);
			return p._encode(args[1])
			end

	return p		return p