Module:URL to diff - Revision history

Pppery: Pppery moved page Module:ConvertDiff to Module:URL to diff without leaving a redirect: Match name with template

2020-09-11T01:12:03Z

Pppery moved page Module:ConvertDiff to Module:URL to diff without leaving a redirect: Match name with template

← Previous revision	Revision as of 01:12, 11 September 2020
(No difference)

Pigsonthewing: fix after move

2017-02-06T12:16:10Z

fix after move

← Previous revision		Revision as of 12:16, 6 February 2017
Line 60:		Line 60:
	function p.url(frame)		function p.url(frame)
	local args = require('Module:Arguments').getArgs(frame, {		local args = require('Module:Arguments').getArgs(frame, {
	wrappers = 'Template:~~Url~~ to diff',		wrappers = 'Template:URL to diff',
	})		})
	return p._url(args)		return p._url(args)

Mr. Stradivarius: more specific wrapper template name

2015-01-01T16:25:51Z

more specific wrapper template name

← Previous revision		Revision as of 16:25, 1 January 2015
Line 60:		Line 60:
	function p.url(frame)		function p.url(frame)
	local args = require('Module:Arguments').getArgs(frame, {		local args = require('Module:Arguments').getArgs(frame, {
	wrappers = 'Template:~~Make~~ diff',		wrappers = 'Template:Url to diff',
	})		})
	return p._url(args)		return p._url(args)

Mr. Stradivarius: on second thoughts, don't try and validate the URL parameters; MediaWiki already does this when it parses the URL, and we don't really need to duplicate the functionality

2015-01-01T16:23:07Z

on second thoughts, don't try and validate the URL parameters; MediaWiki already does this when it parses the URL, and we don't really need to duplicate the functionality

@@ Line 4: / Line 4: @@
 local p = {}
 local function decodeUrl(url)
@@ Line 40: / Line 14: @@
 	end
 	local data = {}
 	data.title = url.query.title and mw.uri.decode(url.query.title, 'WIKI')
-	data.oldid = validateId(url.query.oldid)
+	data.diff = url.query.diff
 	data.diffonly = url.query.diffonly
 	return data

Mr. Stradivarius: finish the encoding function

2015-01-01T16:18:33Z

finish the encoding function

← Previous revision		Revision as of 16:18, 1 January 2015
Line 1:		Line 1:
	-- This module converts Wikipedia diff URLs to the {{diff}} template format.		-- This module converts Wikipedia diff URLs to the {{diff}} template format.

			local newBuffer = require('Module:OutputBuffer')

	local p = {}		local p = {}
Line 39:		Line 41:
	local data = {}		local data = {}
	data.diff = validateDiffParam(url.query.diff)		data.diff = validateDiffParam(url.query.diff)
⚫	if ~~not~~ data.~~diff~~ then
⚫	return nil
⚫	end
	data.title = url.query.title and mw.uri.decode(url.query.title, 'WIKI')		data.title = url.query.title and mw.uri.decode(url.query.title, 'WIKI')
	data.oldid = validateId(url.query.oldid)		data.oldid = validateId(url.query.oldid)
			data.diffonly = url.query.diffonly
	mw.logObject(data)
	return data		return data
	end		end

	local function encodeDiffTemplate(data)		local function encodeDiffTemplate(data)
			if not data.title and not data.diff and not data.oldid then
		⚫	return nil
		⚫	end
	local isNamed = false -- Track whether we need to use named parameters		local isNamed = false -- Track whether we need to use named parameters
	for _, ~~key~~ in ~~ipairs{'title', 'label'}~~ do		for k, v in pairs(data) do
	if ~~data[key] and~~ string.find(~~data[key]~~, '=') then		if string.find(v, '=') then
	isNamed = true		isNamed = true
	break		break
	end		end
	end		end
	local ~~ret~~ = {}		local getBuffer, print, printf = newBuffer()
			print('diff')
			printf('%s%s', isNamed and 'page=' or '', data.title or '')
			printf('%s%s', isNamed and 'diff=' or '', data.diff or '')
			printf('%s%s', isNamed and 'oldid=' or '', data.oldid or '')
		⚫	if data.label then
			printf('%s%s', isNamed and 'label=' or '', data.label)
			end
			if data.diffonly then
			printf('diffonly=%s', data.diffonly)
			end
			local ret = getBuffer('\|')
			ret = '{{' .. ret .. '}}'
			return ret
	end		end

Mr. Stradivarius: hmm, looks like "prev" got lost somewhere

2015-01-01T15:55:47Z

hmm, looks like "prev" got lost somewhere

← Previous revision		Revision as of 15:55, 1 January 2015
Line 5:		Line 5:
	local validDiffValues = {		local validDiffValues = {
	cur = true,		cur = true,
			prev = true,

	['next'] = true		['next'] = true
	}		}

Mr. Stradivarius: start work on the encoding function

2015-01-01T15:55:07Z

start work on the encoding function

← Previous revision		Revision as of 15:55, 1 January 2015
Line 5:		Line 5:
	local validDiffValues = {		local validDiffValues = {
	cur = true,		cur = true,

	prev = true,
	['next'] = true		['next'] = true
	}		}

	local function ~~isValidId~~(s)		local function validateId(s)
	local id = tonumber(s)		local id = tonumber(s)
	~~return~~ id and id > 0		if id and id > 0 then
			return id
			else
			return nil
			end
	end		end

	local function ~~isValidDiffParam~~(s)		local function validateDiffParam(s)
			if not s then
⚫	~~return~~ ~~s and (~~validDiffValues[s] ~~or isValidId(s))~~
			return nil
			end
		⚫	if validDiffValues[s] then
			return s
			else
			return validateId(s)
			end
	end		end

Line 23:		Line 34:
	end		end
	url = mw.uri.new(url)		url = mw.uri.new(url)
	if not url or url.host ~= 'en.wikipedia.org' ~~or not isValidDiffParam(url.query.diff)~~ then		if not url or url.host ~= 'en.wikipedia.org' then
	return nil		return nil
	end		end
	local data = {}		local data = {}
			data.diff = validateDiffParam(url.query.diff)
			if not data.diff then
			return nil
			end
			data.title = url.query.title and mw.uri.decode(url.query.title, 'WIKI')
			data.oldid = validateId(url.query.oldid)
	mw.logObject(data)		mw.logObject(data)
			return data
	end		end

	local function encodeDiffTemplate(data)		local function encodeDiffTemplate(data)
			local isNamed = false -- Track whether we need to use named parameters
			for _, key in ipairs{'title', 'label'} do
			if data[key] and string.find(data[key], '=') then
			isNamed = true
			break
			end
			end
			local ret = {}
	end		end

	function p._url(args)		function p._url(args)
	local ~~url~~ = args~~[1]~~		local data = decodeUrl(args.url)
	local data = decodeUrl(url)
	if data then		if data then
			data.label = args.label
	return encodeDiffTemplate(data)		return encodeDiffTemplate(data)
	else		else

Mr. Stradivarius: add some validation stuff

2015-01-01T15:35:08Z

add some validation stuff

@@ Line 2: / Line 2: @@
 local p = {}
 local function decodeUrl(url)
 	if type(url) ~= 'string' then
 	end
 	url = mw.uri.new(url)
 	end
 end
@@ Line 26: / Line 36: @@
 	local url = args[1]
 	local data = decodeUrl(url)
-	return encodeDiffTemplate(data)
+	if data then
 end

Mr. Stradivarius: make a start at a URL to {{diff}} converter

2015-01-01T15:13:04Z

make a start at a URL to {{diff}} converter

New page

-- This module converts Wikipedia diff URLs to the {{diff}} template format.

local p = {}

local function decodeUrl(url)
if type(url) ~= 'string' then
error('no URL provided', 2)
end
url = mw.uri.new(url)
if not url then
error('invalid URL provided', 2)
end
if url.host ~= 'en.wikipedia.org' then
error(string.format(
"invalid host '%s'; this template only accepts diff URLs from en.wikipedia.org",
tostring(url.host)
), 2)
end
mw.logObject(url.host)
end

local function encodeDiffTemplate(data)
end

function p._url(args)
local url = args[1]
local data = decodeUrl(url)
return encodeDiffTemplate(data)
end

function p.url(frame)
local args = require('Module:Arguments').getArgs(frame, {
wrappers = 'Template:Make diff',
})
return p._url(args)
end

return p