Module:Validate gadgets - Revision history

SD0001: use message existence check for validity of rights and actions as well

2024-02-23T13:54:57Z

use message existence check for validity of rights and actions as well

← Previous revision		Revision as of 13:54, 23 February 2024
Line 16:		Line 16:
	-- (unlike namespaces that can be accessed from mw.site.namespaces)		-- (unlike namespaces that can be accessed from mw.site.namespaces)
	local VALID_CONTENT_MODELS = {'wikitext', 'javascript', 'css', 'json', 'MassMessageListContent', 'Scribunto', 'sanitized-css'}		local VALID_CONTENT_MODELS = {'wikitext', 'javascript', 'css', 'json', 'MassMessageListContent', 'Scribunto', 'sanitized-css'}
	local VALID_RIGHTS = {'edit', 'minoredit', 'viewmywatchlist', 'rollback', 'autoconfirmed', 'extendedconfirmed', 'delete', 'patrol', 'review', 'block'} -- not exhaustive
	local VALID_ACTIONS = {'view', 'edit', 'history', 'info', 'move', 'delete', 'undelete', 'protect', 'block' } -- not exhaustive

	p.validate = function (frame)		p.validate = function (frame)
Line 100:		Line 98:
	if options.actions ~= nil then		if options.actions ~= nil then
	for _, action in ipairs(mw.text.split(options.actions, ',', false)) do		for _, action in ipairs(mw.text.split(options.actions, ',', false)) do
	if not ~~arr_contains~~(~~VALID_ACTIONS,~~ action) then		if not mw.message.new('action-' .. action):exists() then
	table.insert(warnings, 'Action '..action..' is unrecognised')		table.insert(warnings, 'Action '..action..' is unrecognised')
	end		end
Line 121:		Line 119:
	if options.rights ~= nil then		if options.rights ~= nil then
	for _, right in ipairs(mw.text.split(options.rights, ',', false)) do		for _, right in ipairs(mw.text.split(options.rights, ',', false)) do
	if not ~~arr_contains~~(~~VALID_RIGHTS,~~ right) then		if not mw.message.new('right-' .. right):exists() then
	table.insert(warnings, 'User right '..right..' does not exist')		table.insert(warnings, 'User right '..right..' does not exist')
	end		end

SD0001: smarter way to check if skin name is valid, credit to User:Stjn

2024-02-23T13:23:21Z

smarter way to check if skin name is valid, credit to User:Stjn

← Previous revision		Revision as of 13:23, 23 February 2024
Line 15:		Line 15:
	-- Lists of valid options for things that aren't exposed to lua		-- Lists of valid options for things that aren't exposed to lua
	-- (unlike namespaces that can be accessed from mw.site.namespaces)		-- (unlike namespaces that can be accessed from mw.site.namespaces)
	local VALID_SKINS = {'vector', 'vector-2022', 'minerva', 'timeless', 'monobook', 'modern', 'cologneblue'}
	local VALID_CONTENT_MODELS = {'wikitext', 'javascript', 'css', 'json', 'MassMessageListContent', 'Scribunto', 'sanitized-css'}		local VALID_CONTENT_MODELS = {'wikitext', 'javascript', 'css', 'json', 'MassMessageListContent', 'Scribunto', 'sanitized-css'}
	local VALID_RIGHTS = {'edit', 'minoredit', 'viewmywatchlist', 'rollback', 'autoconfirmed', 'extendedconfirmed', 'delete', 'patrol', 'review', 'block'} -- not exhaustive		local VALID_RIGHTS = {'edit', 'minoredit', 'viewmywatchlist', 'rollback', 'autoconfirmed', 'extendedconfirmed', 'delete', 'patrol', 'review', 'block'} -- not exhaustive
Line 115:		Line 114:
	if options.skins ~= nil then		if options.skins ~= nil then
	for _, skin in ipairs(mw.text.split(options.skins, ',', false)) do		for _, skin in ipairs(mw.text.split(options.skins, ',', false)) do
	if not ~~arr_contains~~(~~VALID_SKINS,~~ skin) then		if not mw.message.new('skinname-' .. skin):exists() then
	table.insert(warnings, 'Skin '..skin..' is not available')		table.insert(warnings, 'Skin '..skin..' is not available')
	end		end

SD0001: setting targets in gadget definition is deprecated

2024-02-23T13:17:30Z

setting targets in gadget definition is deprecated

← Previous revision		Revision as of 13:17, 23 February 2024
Line 88:		Line 88:
	end		end
	if options.targets ~= nil then		if options.targets ~= nil then
			table.insert(warnings, 'Setting targets in gadget defintion is deprecated and no longer has any effect')
	for _, target in ipairs(mw.text.split(options.targets, ',', false)) do
	if target ~= 'desktop' and target ~= 'mobile' then
	table.insert(warnings, 'Target '..target..' is invalid. Allowed values: desktop, mobile')
	end
	end
	end		end
	if options.namespaces ~= nil then		if options.namespaces ~= nil then

ToBeFree: Changed protection settings for "Module:Validate gadgets": restoring previous protection level / undoing my full protection: Invocation is inside noinclude, which appears to be safe ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

2024-02-01T18:59:17Z

Changed protection settings for "Module:Validate gadgets": restoring previous protection level / undoing my full protection: Invocation is inside noinclude, which appears to be safe ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

← Previous revision	Revision as of 18:59, 1 February 2024
(No difference)

ToBeFree: Changed protection settings for "Module:Validate gadgets": invoked by interface-admin-protected page MediaWiki:Gadgets-definition ([Edit=Require administrator access] (indefinite) [Move=Require administrator access] (indefinite))

2024-02-01T18:22:02Z

Changed protection settings for "Module:Validate gadgets": invoked by interface-admin-protected page MediaWiki:Gadgets-definition ([Edit=Require administrator access] (indefinite) [Move=Require administrator access] (indefinite))

← Previous revision	Revision as of 18:22, 1 February 2024
(No difference)

SD0001: use PascalCase convention for requires

2024-01-23T10:46:39Z

use PascalCase convention for requires

← Previous revision		Revision as of 10:46, 23 January 2024
Line 1:		Line 1:
	local ~~messageBox~~ = require('Module:Message box')		local MessageBox = require('Module:Message box')
	local ~~gadgets~~ = require('Module:Gadgets')		local Gadgets = require('Module:Gadgets')

	local p = {}		local p = {}
Line 31:		Line 31:
	for _, line in ipairs(lines) do		for _, line in ipairs(lines) do
	if line:sub(1, 1) == '*' then		if line:sub(1, 1) == '*' then
	local name, options, pages = ~~gadgets~~.parse_line(line)		local name, options, pages = Gadgets.parse_line(line)
	if not name or #pages == 0 then		if not name or #pages == 0 then
	table.insert(allWarnings, '* Invalid definition: '..line)		table.insert(allWarnings, '* Invalid definition: '..line)
Line 48:		Line 48:

	if #allWarnings ~= 0 then		if #allWarnings ~= 0 then
	return ~~messageBox~~.main('ombox', {		return MessageBox.main('ombox', {
	text = '<b>Issues in gadget definitions:</b>\n' .. table.concat(allWarnings, '\n'),		text = '<b>Issues in gadget definitions:</b>\n' .. table.concat(allWarnings, '\n'),
	type = 'delete',		type = 'delete',
Line 54:		Line 54:
	})		})
	elseif require('Module:If preview/configuration').preview then		elseif require('Module:If preview/configuration').preview then
	return ~~messageBox~~.main('ombox', {		return MessageBox.main('ombox', {
	text = '<b>Issues in gadget definitions:</b> <i>No issues found!</i>',		text = '<b>Issues in gadget definitions:</b> <i>No issues found!</i>',
	type = 'notice',		type = 'notice',
Line 203:		Line 203:
	if repo[peer] == nil then		if repo[peer] == nil then
	table.insert(warnings, 'Peer gadget '..peer..' is not defined')		table.insert(warnings, 'Peer gadget '..peer..' is not defined')
	elseif ~~gadgets~~.get_type(repo[peer]) == 'general' then		elseif Gadgets.get_type(repo[peer]) == 'general' then
	table.insert(warnings, 'Peer gadget '..peer..' must be styles-only gadget')		table.insert(warnings, 'Peer gadget '..peer..' must be styles-only gadget')
	end		end

SD0001: reuse parse_line and get_type functions from Module:Gadgets

2024-01-23T10:26:33Z

reuse parse_line and get_type functions from Module:Gadgets

@@ Line 1: / Line 1: @@
 local messageBox = require('Module:Message box')
 local p = {}
@@ Line 25: / Line 26: @@
 	local repo = {}
 	local allWarnings = {}
 	for _, line in ipairs(lines) do
 		if line:sub(1, 1) == '*' then
-			local name, options, pages = p.parse_line(line)
+			local name, options, pages = gadgets.parse_line(line)
 			if not name or #pages == 0 then
 				table.insert(allWarnings, '* Invalid definition: '..line)
@@ Line 59: / Line 63: @@
 		return ''
 	end
 end
@@ Line 232: / Line 203: @@
 			if repo[peer] == nil then
 				table.insert(warnings, 'Peer gadget '..peer..' is not defined')
-			elseif p.get_type(repo[peer]) == 'general' then
+			elseif gadgets.get_type(repo[peer]) == 'general' then
 				table.insert(warnings, 'Peer gadget '..peer..' must be styles-only gadget')
 			end
@@ Line 250: / Line 221: @@
 	return warnings
 end

SD0001: fix nil title handling

2024-01-10T14:00:04Z

fix nil title handling

← Previous revision		Revision as of 14:00, 10 January 2024
Line 169:		Line 169:
	if title == nil or not title.exists then		if title == nil or not title.exists then
	table.insert(warnings, 'Page [['..page..']] does not exist')		table.insert(warnings, 'Page [['..page..']] does not exist')
	~~end~~		else
	local ext = title.text:match("%.([^%.]+)$")		local ext = title.text:match("%.([^%.]+)$")
	if ext == 'js' then		if ext == 'js' then
	if title.contentModel ~= 'javascript' then		if title.contentModel ~= 'javascript' then
	table.insert(warnings, 'Page [['..page..']] is not of JavaScript content model')		table.insert(warnings, 'Page [['..page..']] is not of JavaScript content model')
	else		else
	table.insert(scripts, page)		table.insert(scripts, page)
	end		end
	elseif ext == 'css' then		elseif ext == 'css' then
	if title.contentModel ~= 'css' then		if title.contentModel ~= 'css' then
	table.insert(warnings, 'Page [['..page..']] is not of CSS content model')		table.insert(warnings, 'Page [['..page..']] is not of CSS content model')
	else		else
	table.insert(styles, page)		table.insert(styles, page)
	end		end
	elseif ext == 'json' then		elseif ext == 'json' then
	if title.contentModel ~= 'json' then		if title.contentModel ~= 'json' then
	table.insert(warnings, 'Page [['..page..']] is not of JSON content model')		table.insert(warnings, 'Page [['..page..']] is not of JSON content model')
	else		else
	table.insert(jsons, page)		table.insert(jsons, page)
	end		end
	else		else
	table.insert(warnings, 'Page [['..page..']] is not JS/CSS/JSON, will be ignored')		table.insert(warnings, 'Page [['..page..']] is not JS/CSS/JSON, will be ignored')
	end		end
		⚫	end
	end		end

Line 222:		Line 223:
	table.insert(warnings, 'ResourceLoader option must be set')		table.insert(warnings, 'ResourceLoader option must be set')
	end		end
⚫
	-- Causes warnings on styles-only gadgets using skins param		-- Causes warnings on styles-only gadgets using skins param
	-- if options.hidden ~= nil and (options.namespaces ~= nil or options.actions ~= nil or options.rights ~= nil or options.contentModels ~= nil or options.skins ~= nil) then		-- if options.hidden ~= nil and (options.namespaces ~= nil or options.actions ~= nil or options.rights ~= nil or options.contentModels ~= nil or options.skins ~= nil) then

Pppery: Protected "Module:Validate gadgets": High-risk template or module ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

2024-01-08T01:28:01Z

Protected "Module:Validate gadgets": High-risk template or module ([Edit=Require template editor access] (indefinite) [Move=Require template editor access] (indefinite))

← Previous revision	Revision as of 01:28, 8 January 2024
(No difference)

SD0001 at 14:27, 4 January 2024

2024-01-04T14:27:25Z

← Previous revision		Revision as of 14:27, 4 January 2024
Line 222:		Line 222:
	table.insert(warnings, 'ResourceLoader option must be set')		table.insert(warnings, 'ResourceLoader option must be set')
	end		end
		⚫
⚫	if options.hidden ~= nil and (options.namespaces ~= nil or options.actions ~= nil or options.rights ~= nil or options.contentModels ~= nil or options.skins ~= nil) then
			-- Causes warnings on styles-only gadgets using skins param
⚫	table.insert(warnings, 'Conditional load options are not applicable for hidden gadget')
		⚫	-- if options.hidden ~= nil and (options.namespaces ~= nil or options.actions ~= nil or options.rights ~= nil or options.contentModels ~= nil or options.skins ~= nil) then
⚫	~~end~~
		⚫	-- table.insert(warnings, 'Conditional load options are not applicable for hidden gadget')
			-- end

	if options.peers ~= nil then		if options.peers ~= nil then