Module:WikiProject banner - Revision history

MSGJ: fix

2025-01-31T20:50:23Z

fix

← Previous revision		Revision as of 20:50, 31 January 2025
Line 555:		Line 555:
	tf_importance = importance		tf_importance = importance
	end		end
	tf_importance_category = tf_importance .. '-' .. importance_name .. ' ' .. tf_assessment_cat .. ' ' .. (~~importance~~=='NA' and 'pages' or 'articles')		tf_importance_category = tf_importance .. '-' .. importance_name .. ' ' .. tf_assessment_cat .. ' ' .. (tf_importance=='NA' and 'pages' or 'articles')
	add_category(tf_importance_category)		add_category(tf_importance_category)
	end		end

MSGJ: allow drafts to be rated for importance, remove temporary code for category renames, tweak to logic for displaying class, remove listas parameter

2025-01-30T22:35:03Z

allow drafts to be rated for importance, remove temporary code for category renames, tweak to logic for displaying class, remove listas parameter

Show changes

MSGJ: improve fall-back code and include checks for "pages" and "articles" suffices

2024-12-18T10:18:21Z

improve fall-back code and include checks for "pages" and "articles" suffices

@@ Line 322: / Line 322: @@
 	assessment_link = nil
 end
 local check_fallbacks = function(class, category)
 		return class
-	else -- check fallbacks for non-article classes
+	-- check fallbacks for non-article classes
-		local category_exists = function(class)
+	local new_class = class
-			local cat =  mw.title.new(cfg.quality.assessment_category:format(class, category .. ' ' .. (article and 'articles' or 'pages')))
+		local cat = mw.title.new(cfg.quality.assessment_category:format(
 		end
 	end
 end
 local class = raw_args.class
@@ Line 381: / Line 402: @@
 		if class=='' then -- local class is blank
 			class = check_fallbacks(article_class, assessment_cat) -- check fallbacks again now that class may have changed
 		elseif class==article_class then -- local class matches article class or is blank
 			check_redundant()
@@ Line 388: / Line 410: @@
 				warning = warning .. display_error(cfg.banner_shell.piqa_warning)
 			end
-		elseif args.QUALITY_CRITERIA=='custom' then -- project uses custom criteria and class differs
+		elseif article_class=='FM' and args.QUALITY_CRITERIA~='custom' then
 			check_redundant()
 		elseif not article and class~='FM' then -- article class and local class are both non-article classes
 			check_redundant()
 		else -- article class exists and differs from local class
 			show = 'conflict'
@@ Line 402: / Line 424: @@
 		show = true
 	end
-	local category = (class=='' and 'Unassessed' or class..'-Class') .. ' ' .. assessment_cat -- .. ' ' .. (article and 'articles' or 'pages')
+	local category = (class=='' and 'Unassessed' or class..'-Class') .. ' ' .. assessment_cat
 	else
 		category = category .. ' articles'
@@ Line 614: / Line 639: @@
 		local tf_class = check_fallbacks(class, tf_assessment_cat)
 		local category = (tf_class=='' and 'Unassessed' or tf_class..'-Class') .. ' ' .. tf_assessment_cat
-		if not article and mw.title.new('Category:' .. category .. ' pages').exists then
+		-- use "pages" for non-articles if the category exists: temporary transition code
 		else
 			category = category .. ' articles'

MSGJ: use "pages" instead of "articles" for non-article categories with temporary code to check existence during transition, general tidy of code for quality rating logic

2024-12-16T21:07:46Z

use "pages" instead of "articles" for non-article categories with temporary code to check existence during transition, general tidy of code for quality rating logic

Show changes

MSGJ: change for rename of :Category:FM-Class pages

2024-12-07T08:28:22Z

change for rename of Category:FM-Class pages

← Previous revision		Revision as of 08:28, 7 December 2024
Line 238:		Line 238:
	-- Primary image/text -----		-- Primary image/text -----
	---------------------------		---------------------------
			local assessment_category = function(cat, name)
⚫	local assessment_cat = args.ASSESSMENT_CAT or project ~~.. ' articles'~~
			if cat then
			return cat:gsub(' articles', '') -- remove "articles" from category
			else
			return name or ''
		⚫	end
		⚫	end
		⚫	local assessment_cat = assessment_category(args.ASSESSMENT_CAT, project)
	local primary_image = function(image_name, size)		local primary_image = function(image_name, size)
	local cell = mw.html.create('td')		local cell = mw.html.create('td')
Line 328:		Line 335:
	local check_exists = function(class, assessment_cat) -- check if category exists and is not blank		local check_exists = function(class, assessment_cat) -- check if category exists and is not blank
	if not isarticle(class) then		if not isarticle(class) then
	local cat = mw.title.new('Category:' .. class .. '-Class' .. ' ' .. assessment_cat)		local cat = mw.title.new('Category:' .. class .. '-Class' .. ' ' .. assessment_cat .. ' ' .. (class=='FM' and 'pages' or 'articles'))
	return (cat.exists and #cat:getContent()>0) and class or 'NA' -- automatically use NA for non-article pages if category does not exist		return (cat.exists and #cat:getContent()>0) and class or 'NA' -- automatically use NA for non-article pages if category does not exist
	else		else
Line 365:		Line 372:
	else		else
	class = p.class_mask(class, title, true, pagetype)		class = p.class_mask(class, title, true, pagetype)
		⚫	end
		⚫	if not isarticle(class) then -- check fallbacks for non-article classes
		⚫	local category_exists = function(class)
		⚫	local cat = mw.title.new(cfg.quality.assessment_category:format(class, assessment_cat .. ' articles'))
		⚫	return cat.exists and #cat:getContent()>0 -- check if category exists and is not blank
		⚫	end
		⚫	if class=='FM' and not category_exists('FM') then
		⚫	class = 'File' -- fall back to File-class if FM category does not exist
		⚫	end
		⚫	if not category_exists(class) then
		⚫	class = 'NA' -- automatically use NA for non-article pages if category does not exist
			end
		⚫	--if raw_args.class~='' and args.QUALITY_CRITERIA~='custom' then
		⚫	-- add_category(cfg.banner_shell.category.redundant_class)
			--end
	end		end
	if article_class then -- banner shell exists		if article_class then -- banner shell exists
Line 387:		Line 409:
	end		end
	end		end
		⚫	local category = (class=='' and 'Unassessed' or class..'-Class') .. ' ' .. assessment_cat .. ' ' .. (class=='FM' and 'pages' or 'articles')
⚫	if not isarticle(class) then -- check fallbacks for non-article classes
⚫	local category_exists = function(class)
⚫	local cat = mw.title.new(cfg.quality.assessment_category:format(class, assessment_cat))
⚫	return cat.exists and #cat:getContent()>0 -- check if category exists and is not blank
⚫	end
⚫	if class=='FM' and not category_exists('FM') then
⚫	class = 'File' -- fall back to File-class if FM category does not exist
⚫	end
⚫	if not category_exists(class) then
⚫	class = 'NA' -- automatically use NA for non-article pages if category does not exist
⚫	end
⚫	--if raw_args.class~='' and args.QUALITY_CRITERIA~='custom' then
⚫	-- add_category(cfg.banner_shell.category.redundant_class)
⚫	--end
⚫	end
⚫	local category = (class=='' and 'Unassessed' or class..'-Class') .. ' ' .. assessment_cat
	if show_quality then -- quality rating shown in banner		if show_quality then -- quality rating shown in banner
	local rating		local rating
Line 452:		Line 459:
	local importance_name = args.IMPN or (raw_args.priority and 'priority' or cfg.importance.default_name)		local importance_name = args.IMPN or (raw_args.priority and 'priority' or cfg.importance.default_name)
	if importance then -- banner gives importance ratings		if importance then -- banner gives importance ratings
	local category = importance .. '-' .. importance_name .. ' ' .. assessment_cat		local category = importance .. '-' .. importance_name .. ' ' .. assessment_cat .. ' articles'
	if importance~='NA' then -- display importance rating		if importance~='NA' then -- display importance rating
	local rating = importance=='Unknown' and cfg.importance.not_yet or cfg.importance.rated:format(importance, importance_name)		local rating = importance=='Unknown' and cfg.importance.not_yet or cfg.importance.rated:format(importance, importance_name)
Line 538:		Line 545:
	for _, k in ipairs(task_forces) do		for _, k in ipairs(task_forces) do
	local tf_prefix = 'TF_' .. k .. '_'		local tf_prefix = 'TF_' .. k .. '_'
	local tf_assessment_cat = args[tf_prefix..'ASSESSMENT_CAT'] ~~or (~~args[tf_prefix..'NAME'] ~~or ''~~)~~..' articles'~~		local tf_assessment_cat = assessment_category(args[tf_prefix..'ASSESSMENT_CAT'], args[tf_prefix..'NAME'])
	local tf_importance		local tf_importance
	if raw_args['tf '..k..' importance'] then		if raw_args['tf '..k..' importance'] then
Line 563:		Line 570:
	and tf_importance~='Unknown'		and tf_importance~='Unknown'
	and ' ' .. cfg.task_force.importance:format(		and ' ' .. cfg.task_force.importance:format(
	wikilink(':Category:' .. tf_importance .. '-' .. importance_name .. ' ' .. tf_assessment_cat, tf_importance .. '-' .. importance_name)		wikilink(
			':Category:' .. tf_importance .. '-' .. importance_name .. ' ' .. tf_assessment_cat .. ' articles',
			tf_importance .. '-' .. importance_name
			)
	) or ''		) or ''
	text = portal .. cfg.task_force.text:format(		text = portal .. cfg.task_force.text:format(
Line 591:		Line 601:
	if yesno(args[tf_prefix..'QUALITY']) and class then		if yesno(args[tf_prefix..'QUALITY']) and class then
	local tf_class = check_exists(class, tf_assessment_cat)		local tf_class = check_exists(class, tf_assessment_cat)
	add_category((tf_class=='' and 'Unassessed' or tf_class..'-Class') .. ' ' .. tf_assessment_cat)		add_category((tf_class=='' and 'Unassessed' or tf_class..'-Class') .. ' ' .. tf_assessment_cat .. ' ' .. (tf_class=='FM' and 'pages' or 'articles'))
	end		end
	if tf_importance then		if tf_importance then
	add_category(tf_importance .. '-' .. importance_name .. ' ' .. tf_assessment_cat)		add_category(tf_importance .. '-' .. importance_name .. ' ' .. tf_assessment_cat .. ' articles')
	end		end
	if args[tf_prefix..'QII_FORMAT'] then		if args[tf_prefix..'QII_FORMAT'] then

MSGJ: Changed protection settings for "Module:WikiProject banner": repeated untested changes by users who should know better ([Edit=Require administrator access] (indefinite) [Move=Require administrator access] (indefinite))

2024-11-24T22:20:20Z

Changed protection settings for "Module:WikiProject banner": repeated untested changes by users who should know better ([Edit=Require administrator access] (indefinite) [Move=Require administrator access] (indefinite))

← Previous revision	Revision as of 22:20, 24 November 2024
(No difference)

Gonnym: sadly this won't work as template banners automatically assign an empty value to the module so restoring this check

2024-11-24T22:15:21Z

sadly this won't work as template banners automatically assign an empty value to the module so restoring this check

← Previous revision		Revision as of 22:15, 24 November 2024
Line 372:		Line 372:
	class = article_class		class = article_class
	end		end
	if args.QUALITY_CRITERIA~='custom' then		if raw_args.class~='' and args.QUALITY_CRITERIA~='custom' then
	add_category(cfg.banner_shell.category.redundant_class)		add_category(cfg.banner_shell.category.redundant_class)
	end		end

Gonnym: unclear why the class is changed in this block as class isn't used here and has side effects. Hacking this fix here but this really should be moved to the correct place

2024-11-24T22:08:32Z

unclear why the class is changed in this block as class isn't used here and has side effects. Hacking this fix here but this really should be moved to the correct place

← Previous revision		Revision as of 22:08, 24 November 2024
Line 369:		Line 369:
	if class=='' or class==article_class or article_class=='FM' or class=='Disambig' or class=='Redirect' or article_class=='NA' then -- local class matches article class or is blank		if class=='' or class==article_class or article_class=='FM' or class=='Disambig' or class=='Redirect' or article_class=='NA' then -- local class matches article class or is blank
	show_quality = false -- hide quality class in project banner		show_quality = false -- hide quality class in project banner
			if article_class~='NA' then
	class = article_class		class = article_class
			end
	if args.QUALITY_CRITERIA~='custom' then		if args.QUALITY_CRITERIA~='custom' then
	add_category(cfg.banner_shell.category.redundant_class)		add_category(cfg.banner_shell.category.redundant_class)

Gonnym: allow NA (category, etc) pages also be included in tracking category; allow empty class= to also be included

2024-11-24T22:00:59Z

allow NA (category, etc) pages also be included in tracking category; allow empty class= to also be included

← Previous revision		Revision as of 22:00, 24 November 2024
Line 367:		Line 367:
	end		end
	if article_class then -- banner shell exists		if article_class then -- banner shell exists
	if class=='' or class==article_class or article_class=='FM' or class=='Disambig' or class=='Redirect' then -- local class matches article class or is blank		if class=='' or class==article_class or article_class=='FM' or class=='Disambig' or class=='Redirect' or article_class=='NA' then -- local class matches article class or is blank
	show_quality = false -- hide quality class in project banner		show_quality = false -- hide quality class in project banner
	class = article_class		class = article_class
	if ~~raw_args.class~='' and~~ args.QUALITY_CRITERIA~='custom' then		if args.QUALITY_CRITERIA~='custom' then
	add_category(cfg.banner_shell.category.redundant_class)		add_category(cfg.banner_shell.category.redundant_class)
	end		end

Gonnym: remove the class from Redirect pages also

2024-11-24T18:49:06Z

remove the class from Redirect pages also

← Previous revision		Revision as of 18:49, 24 November 2024
Line 367:		Line 367:
	end		end
	if article_class then -- banner shell exists		if article_class then -- banner shell exists
	if class=='' or class==article_class or article_class=='FM' or class=='Disambig' then -- local class matches article class or is blank		if class=='' or class==article_class or article_class=='FM' or class=='Disambig' or class=='Redirect' then -- local class matches article class or is blank
	show_quality = false -- hide quality class in project banner		show_quality = false -- hide quality class in project banner
	class = article_class		class = article_class