Module:YouTubeSubscribers - Revision history

Tom.Reding: Improve readability of long, compound if-statements

2024-02-24T03:12:47Z

Improve readability of long, compound if-statements

← Previous revision		Revision as of 03:12, 24 February 2024
Line 108:		Line 108:
	end		end
	local pointInTime = pointsInTime[1]		local pointInTime = pointsInTime[1]
	if pointInTime and pointInTime['datavalue'] and pointInTime['datavalue']['value'] and pointInTime['datavalue']['value']['time'] then		if pointInTime and
			pointInTime['datavalue'] and
			pointInTime['datavalue']['value'] and
			pointInTime['datavalue']['value']['time']
			then
	return parseDate(pointInTime['datavalue']['value']['time'])		return parseDate(pointInTime['datavalue']['value']['time'])
	end		end
Line 185:		Line 189:
	if #chanIds == 1 then		if #chanIds == 1 then
	local chan = chanIds[1]		local chan = chanIds[1]
	if chan and chan["mainsnak"] and chan["mainsnak"]["datavalue"] and chan["mainsnak"]["datavalue"]["value"] then		if chan and
			chan["mainsnak"] and
			chan["mainsnak"]["datavalue"] and
			chan["mainsnak"]["datavalue"]["value"]
			then
	return chan["mainsnak"]["datavalue"]["value"]		return chan["mainsnak"]["datavalue"]["value"]
	end		end
Line 242:		Line 250:
	if chanId then		if chanId then
	local s = newestMatching(e, SUB_COUNT_PID, YT_CHAN_ID_PID, chanId)		local s = newestMatching(e, SUB_COUNT_PID, YT_CHAN_ID_PID, chanId)
			if s and
	if s and s["mainsnak"] and s['mainsnak']["datavalue"] and s['mainsnak']["datavalue"]["value"] and s['mainsnak']["datavalue"]['value']['amount'] then
			s["mainsnak"] and
			s['mainsnak']["datavalue"] and
			s['mainsnak']["datavalue"]["value"] and
			s['mainsnak']["datavalue"]['value']['amount']
			then
	subCount = s['mainsnak']["datavalue"]['value']['amount']		subCount = s['mainsnak']["datavalue"]['value']['amount']
	end		end

Wbm1058: see Wikipedia talk:WikiProject YouTube#Category:Pages with YouTubeSubscribers module errors

2023-05-25T23:29:40Z

see Wikipedia talk:WikiProject YouTube#Category:Pages with YouTubeSubscribers module errors

← Previous revision		Revision as of 23:29, 25 May 2023
Line 171:		Line 171:
	qid = mw.wikibase.getEntityIdForCurrentPage()		qid = mw.wikibase.getEntityIdForCurrentPage()
	end		end
			if not qid then
⚫	assert(~~qid~~, "No qid found for page. Please make a Wikidata item for this article")
			local e = nil
			return e
			end
	local e = mw.wikibase.getEntity(qid)		local e = mw.wikibase.getEntity(qid)
	assert(e, "No such item found: " .. qid)		assert(e, "No such item found: " .. qid)
Line 196:		Line 199:
	function p.date( frame )		function p.date( frame )
	local e = getEntity(frame)		local e = getEntity(frame)
		⚫	assert(e, "No qid found for page. Please make a Wikidata item for this article")
	local chanId = getBestYtChanId(e)		local chanId = getBestYtChanId(e)
	assert(chanId, "Could not find a single best YouTube channel ID for this item. Add a YouTube channel ID or set the rank of one channel ID to be preferred")		assert(chanId, "Could not find a single best YouTube channel ID for this item. Add a YouTube channel ID or set the rank of one channel ID to be preferred")
Line 229:		Line 233:
	-- the most up to date number of subscribers		-- the most up to date number of subscribers
	function p.subCount( frame )		function p.subCount( frame )
⚫	local e = getEntity(frame)
	local subCount = nil		local subCount = nil
		⚫	local e = getEntity(frame)
			if not e then
			subCount = -424
			return tonumber(subCount)
			end
	local chanId = getBestYtChanId(e)		local chanId = getBestYtChanId(e)
	if chanId then		if chanId then

Wbm1058: see Wikipedia talk:WikiProject YouTube#Category:Pages with YouTubeSubscribers module errors

2023-05-22T17:12:44Z

see Wikipedia talk:WikiProject YouTube#Category:Pages with YouTubeSubscribers module errors

← Previous revision		Revision as of 17:12, 22 May 2023
Line 243:		Line 243:
	return tonumber(subCount)		return tonumber(subCount)
	else		else
			subCount = -412
	error("Found an associated YouTube channel ID but could not find a most recent value for social media followers (i.e. P8687 qualified with P585 and P2397)")
			return tonumber(subCount)
	end		end
	end		end

Wbm1058: see Wikipedia talk:WikiProject YouTube#Category:Pages with YouTubeSubscribers module errors

2023-05-21T19:15:34Z

see Wikipedia talk:WikiProject YouTube#Category:Pages with YouTubeSubscribers module errors

← Previous revision		Revision as of 19:15, 21 May 2023
Line 238:		Line 238:
	end		end
	else		else
			subCount = -404
	error("Could not find a single best YouTube channel ID for this item. Add a YouTube channel ID or set the rank of one channel ID to be preferred")
	end		end
	if subCount then		if subCount then
Line 250:		Line 250:
	local status, obj = pcall(p.subCount, frame)		local status, obj = pcall(p.subCount, frame)
	if status then		if status then
			if obj >= 0 then
	return frame:expandTemplate{title="Format price", args = {obj}}		return frame:expandTemplate{title="Format price", args = {obj}}
			else
			return obj
			end
	else		else
	return returnError(frame, obj)		return returnError(frame, obj)

Lemondoge: Trimmed redundancy, made code easier to read, and fixed a minor error from attempting to escape a character with a backslash like in Regex. If this edit somehow breaks Wikipedia, please inform me via trout.

2023-04-04T19:48:41Z

Trimmed redundancy, made code easier to read, and fixed a minor error from attempting to escape a character with a backslash like in Regex. If this edit somehow breaks Wikipedia, please inform me via trout.

← Previous revision		Revision as of 19:48, 4 April 2023
Line 37:		Line 37:
	if i then		if i then
	-- year		-- year
	parts[index] = tonumber(mw.ustring.gsub(dateStr:sub(ptr, i-1), "^\+(.+)$", "%1"), 10) -- remove '+' sign (explicitly give base 10 to prevent error)		parts[index] = tonumber(mw.ustring.gsub(dateStr:sub(ptr, i-1), "^%+(.+)$", "%1"), 10) -- remove '+' sign (explicitly give base 10 to prevent error)

	if parts[index] == -0 then		if parts[index] == -0 then
Line 87:		Line 87:
	if aY < bY then		if aY < bY then
	return true		return true
		⚫	elseif aY > bY then
	end

⚫	if aY > bY then
	return false		return false
		⚫	elseif aM < bM then
	end

⚫	if aM < bM then
	return true		return true
		⚫	elseif aM > bM then
	end

⚫	if aM > bM then
	return false		return false
		⚫	elseif aD < bD then
	end

⚫	if aD < bD then
	return true		return true
	end		end
Line 179:		Line 171:
	qid = mw.wikibase.getEntityIdForCurrentPage()		qid = mw.wikibase.getEntityIdForCurrentPage()
	end		end
		⚫	assert(qid, "No qid found for page. Please make a Wikidata item for this article")
	if not qid then
⚫	~~error~~("No qid found for page. Please make a Wikidata item for this article")
	end
	local e = mw.wikibase.getEntity(qid)		local e = mw.wikibase.getEntity(qid)
		⚫	assert(e, "No such item found: " .. qid)
	if not e then
⚫	~~error~~("No such item found: " .. qid)
	end
	return e		return e
	end		end
Line 209:		Line 197:
	local e = getEntity(frame)		local e = getEntity(frame)
	local chanId = getBestYtChanId(e)		local chanId = getBestYtChanId(e)
		⚫	assert(chanId, "Could not find a single best YouTube channel ID for this item. Add a YouTube channel ID or set the rank of one channel ID to be preferred")
	if not chanId then
⚫	~~error~~("Could not find a single best YouTube channel ID for this item. Add a YouTube channel ID or set the rank of one channel ID to be preferred")
	end
	local s = newestMatching(e, SUB_COUNT_PID, YT_CHAN_ID_PID, chanId)		local s = newestMatching(e, SUB_COUNT_PID, YT_CHAN_ID_PID, chanId)
	if s then		if s then

MusikBot II: Protected "Module:YouTubeSubscribers": High-risk template or module: 2510 transclusions (more info) ([Edit=Require extended confirmed access] (indefinite) [Move=Require extended confirmed access] (indefinite))

2023-03-23T18:00:06Z

Protected "Module:YouTubeSubscribers": High-risk template or module: 2510 transclusions (more info) ([Edit=Require extended confirmed access] (indefinite) [Move=Require extended confirmed access] (indefinite))

← Previous revision	Revision as of 18:00, 23 March 2023
(No difference)

BrokenSegue: add dateNice

2023-03-02T05:53:10Z

add dateNice

← Previous revision		Revision as of 05:53, 2 March 2023
Line 230:		Line 230:
	end		end
	error("Could not find a date for YouTube subscriber information. Is there a social media followers statement (P8687) qualified with good values for P585 and P2397?")		error("Could not find a date for YouTube subscriber information. Is there a social media followers statement (P8687) qualified with good values for P585 and P2397?")
			end

			function p.dateNice( frame )
			local status, obj = pcall(p.date, frame)
			if status then
			return obj
			else
			return returnError(frame, obj)
			end
	end		end

BrokenSegue: expandTemplate again

2023-03-02T05:48:36Z

expandTemplate again

← Previous revision		Revision as of 05:48, 2 March 2023
Line 255:		Line 255:
	local status, obj = pcall(p.subCount, frame)		local status, obj = pcall(p.subCount, frame)
	if status then		if status then
	return "{{Format price\|" .. obj ~~.. "~~}}"		return frame:expandTemplate{title="Format price", args = {obj}}
	else		else
	return returnError(frame, obj)		return returnError(frame, obj)

BrokenSegue: expand format date template

2023-03-02T05:47:18Z

expand format date template

← Previous revision		Revision as of 05:47, 2 March 2023
Line 227:		Line 227:
	--end		--end
	end		end
	return "{{Format date\|" ~~..dateString~~ .. "}}"		return frame:expandTemplate{title="Format date", args = {yt_year, yt_month, yd_day}}
	end		end
	error("Could not find a date for YouTube subscriber information. Is there a social media followers statement (P8687) qualified with good values for P585 and P2397?")		error("Could not find a date for YouTube subscriber information. Is there a social media followers statement (P8687) qualified with good values for P585 and P2397?")

BrokenSegue: frame:expandTemplate

2023-03-02T05:41:42Z

frame:expandTemplate

← Previous revision		Revision as of 05:41, 2 March 2023
Line 201:		Line 201:
	end		end

	function returnError(eMessage)		function returnError(frame, eMessage)
	return "{{error\|" .. eMessage .. "}} ~~foo~~ [[Category:Pages with YouTubeSubscribers module errors]]"		return frame:expandTemplate{ title = 'error', args = { eMessage } } .. "[[Category:Pages with YouTubeSubscribers module errors]]"
	end		end

Line 257:		Line 257:
	return "{{Format price\|" .. obj .. "}}"		return "{{Format price\|" .. obj .. "}}"
	else		else
	return returnError(obj)		return returnError(frame, obj)
	end		end
	end		end